From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#14785: 24.3.50; isearchb.el; char-to-string and last-command-event Date: Thu, 04 Jul 2013 02:37:25 +0300 Organization: JURTA Message-ID: <87k3l75i6i.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1372894869 31843 80.91.229.3 (3 Jul 2013 23:41:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 3 Jul 2013 23:41:09 +0000 (UTC) To: 14785@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 04 01:41:09 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UuWfd-0006Xt-6t for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Jul 2013 01:41:09 +0200 Original-Received: from localhost ([::1]:36555 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UuWfc-0001al-SK for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Jul 2013 19:41:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54749) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UuWfY-0001aS-Be for bug-gnu-emacs@gnu.org; Wed, 03 Jul 2013 19:41:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UuWfW-00014S-Vj for bug-gnu-emacs@gnu.org; Wed, 03 Jul 2013 19:41:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33130) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UuWfW-00014L-QY for bug-gnu-emacs@gnu.org; Wed, 03 Jul 2013 19:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1UuWfW-00062c-BE for bug-gnu-emacs@gnu.org; Wed, 03 Jul 2013 19:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Jul 2013 23:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 14785 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.137289485523204 (code B ref -1); Wed, 03 Jul 2013 23:41:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 3 Jul 2013 23:40:55 +0000 Original-Received: from localhost ([127.0.0.1]:55679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UuWfN-000628-Nf for submit@debbugs.gnu.org; Wed, 03 Jul 2013 19:40:54 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52849) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UuWfK-00061h-Hs for submit@debbugs.gnu.org; Wed, 03 Jul 2013 19:40:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UuWfA-0000gI-Gp for submit@debbugs.gnu.org; Wed, 03 Jul 2013 19:40:44 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:35877) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UuWf9-0000gD-PM for submit@debbugs.gnu.org; Wed, 03 Jul 2013 19:40:40 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UuWf6-0001Yt-6g for bug-gnu-emacs@gnu.org; Wed, 03 Jul 2013 19:40:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UuWf5-0000e2-9A for bug-gnu-emacs@gnu.org; Wed, 03 Jul 2013 19:40:36 -0400 Original-Received: from ps18281.dreamhost.com ([69.163.218.105]:44169 helo=ps18281.dreamhostps.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UuWf5-0000dx-3h for bug-gnu-emacs@gnu.org; Wed, 03 Jul 2013 19:40:35 -0400 Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id A5195258B9E915 for ; Wed, 3 Jul 2013 16:40:33 -0700 (PDT) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:75873 Archived-At: After loading isearchb.el, evaluating (isearchb-set-keybindings 'super) and typing `s-a', it fails with the error Wrong type argument: characterp, 8388721 This patch seems to fix the bug: === modified file 'lisp/isearchb.el' --- lisp/isearchb.el 2013-01-01 09:11:05 +0000 +++ lisp/isearchb.el 2013-07-03 23:36:20 +0000 @@ -139,7 +139,8 @@ (defun isearchb () (if last-command-event (setq iswitchb-rescan t iswitchb-text (concat iswitchb-text - (char-to-string last-command-event)))) + (char-to-string + (event-basic-type last-command-event))))) (iswitchb-set-matches) (let* ((match (car iswitchb-matches)) (buf (and match (get-buffer match)))) PS: I wonder whether other similar places should be fixed too? Grepping for `char-to-string' and `last-command-event': ./calc/calc-aent.el:282: (calc-alg-entry (and auto (char-to-string last-command-event)))))) ./calc/calc-aent.el:457: (t (char-to-string last-command-event))))) ./calc/calc-misc.el:591: (if (keymapp (key-binding (char-to-string last-command-event))) ./calc/calc.el:2438: (insert (char-to-string last-command-event)) ./emulation/vi.el:987: (setq this-command (lookup-key vi-com-map (char-to-string last-command-event))) ./emulation/vi.el:992: (setq this-command (lookup-key vi-com-map (char-to-string last-command-event)))) ./eshell/esh-mode.el:477: (char-to-string (if (symbolp last-command-event) ./international/quail.el:1599: (concat quail-current-key (char-to-string last-command-event))) ./wdired.el:771: (let ((new-bit (char-to-string last-command-event)) Maybe they don't fail when `last-command-event' is expected to be only a character event. But I don't know how to test most of these functions to verify whether they fail or not.