From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark Date: Tue, 10 Dec 2013 08:53:38 +0100 Message-ID: <87k3fdcfb1.fsf@tsdh.uni-koblenz.de> References: <87a9gbb7wi.fsf@hochschule-trier.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1386662054 4386 80.91.229.3 (10 Dec 2013 07:54:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 10 Dec 2013 07:54:14 +0000 (UTC) Cc: 16090@debbugs.gnu.org, Andreas Politz To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 10 08:54:18 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VqI92-0007lQ-25 for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Dec 2013 08:54:16 +0100 Original-Received: from localhost ([::1]:47745 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqI91-0000eZ-Nm for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Dec 2013 02:54:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46853) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqI8u-0000cW-Gb for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2013 02:54:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VqI8o-0006gC-S8 for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2013 02:54:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55542) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqI8o-0006g8-Oi for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2013 02:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VqI8o-0006dE-4b for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2013 02:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Dec 2013 07:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16090 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 16090-submit@debbugs.gnu.org id=B16090.138666202425459 (code B ref 16090); Tue, 10 Dec 2013 07:54:02 +0000 Original-Received: (at 16090) by debbugs.gnu.org; 10 Dec 2013 07:53:44 +0000 Original-Received: from localhost ([127.0.0.1]:41328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VqI8U-0006cU-RA for submit@debbugs.gnu.org; Tue, 10 Dec 2013 02:53:43 -0500 Original-Received: from deliver.uni-koblenz.de ([141.26.64.15]:57755) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VqI8R-0006cL-S3 for 16090@debbugs.gnu.org; Tue, 10 Dec 2013 02:53:40 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by deliver.uni-koblenz.de (Postfix) with ESMTP id 437451A8453; Tue, 10 Dec 2013 08:53:39 +0100 (CET) X-Virus-Scanned: amavisd-new at uni-koblenz.de Original-Received: from deliver.uni-koblenz.de ([127.0.0.1]) by localhost (deliver.uni-koblenz.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o7Q6YNR9vTV1; Tue, 10 Dec 2013 08:53:38 +0100 (CET) X-CHKRCPT: Envelopesender noch tsdh@gnu.org Original-Received: from tsdh.uni-koblenz.de (tsdh.uni-koblenz.de [141.26.67.142]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by deliver.uni-koblenz.de (Postfix) with ESMTPSA id DED9D1A844C; Tue, 10 Dec 2013 08:53:38 +0100 (CET) In-Reply-To: (Stefan Monnier's message of "Mon, 09 Dec 2013 21:51:48 -0500") User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:81665 Archived-At: Stefan Monnier writes: >> The reason is that the buffer is not yet displayed, when >> doc-view-bookmark-jump tries to change the page. This results in, >> for obscure reasons, trying to change the page in which ever window >> is currently selected. Solution: Defer changing the page after >> bookmark--jump-via has displayed the page. > > Thanks for the report. And thanks for the patch, tho it shouldn't be > installed as is: using a timer is not a good solution. The code is > already equipped to handle non-displayed buffers (it keeps track of > the "default current page" which is later used when/if the buffer gets > displayed in a window). Yes, but I think that doesn't suffice. The problem with bookmarks is that the display window function is run after the bookmark handler, so we have no clue in which window the bookmarked page is going to be shown. It may be the current window, an existing other window (which might already show another page of the doc and thus already has an entry in `image-mode-winprops-alist'), or a completely new window. Bye, Tassilo