From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ivan Shmakov Newsgroups: gmane.emacs.bugs Subject: bug#16204: eww does not respect shr-width customization Date: Sat, 21 Dec 2013 11:08:24 +0000 Message-ID: <87k3eywjfb.fsf@violet.siamics.net> References: <87ob4bwj6l.fsf@violet.siamics.net> <874n624gz5.fsf@dhcp-193-97.nrt.redhat.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1387624151 28599 80.91.229.3 (21 Dec 2013 11:09:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 21 Dec 2013 11:09:11 +0000 (UTC) To: 16204@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 21 12:09:17 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VuKQm-00006e-EI for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Dec 2013 12:09:16 +0100 Original-Received: from localhost ([::1]:53807 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VuKQm-0000yk-0I for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Dec 2013 06:09:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60978) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VuKQd-0000y5-Nl for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2013 06:09:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VuKQY-0008VB-Qk for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2013 06:09:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46874) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VuKQY-0008V5-Gw for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2013 06:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VuKQX-00019o-Rm for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2013 06:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ivan Shmakov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Dec 2013 11:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16204 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16204-submit@debbugs.gnu.org id=B16204.13876241174406 (code B ref 16204); Sat, 21 Dec 2013 11:09:01 +0000 Original-Received: (at 16204) by debbugs.gnu.org; 21 Dec 2013 11:08:37 +0000 Original-Received: from localhost ([127.0.0.1]:60893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VuKQ8-000190-SZ for submit@debbugs.gnu.org; Sat, 21 Dec 2013 06:08:37 -0500 Original-Received: from fely.am-1.org ([78.47.74.50]:56508) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VuKQ6-00018o-4Z for 16204@debbugs.gnu.org; Sat, 21 Dec 2013 06:08:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=1VBu9BZlI8AqG4aoBP+lM3keeosc+lp1xFPNbCR6N0o=; b=q994p2AW/zpAB9WhNwjRjbFoOtVbPaDt385spDIhqdCunSoAXCrfk6b7CjpXhCGpG1tbJCbJowAaCiFAiS3MHnLXv3D3GLfOaEa3gv56tW8QPjjuFGGuc5VUqDgOr4M9/x/jDUMoFBrZowk30EqAh0xvA6eD284FxB4CffR8r9c=; Original-Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1VuKQ4-000072-Kv for 16204@debbugs.gnu.org; Sat, 21 Dec 2013 11:08:33 +0000 Original-Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1VuKPx-0006d7-FZ for 16204@debbugs.gnu.org; Sat, 21 Dec 2013 18:08:25 +0700 In-Reply-To: <874n624gz5.fsf@dhcp-193-97.nrt.redhat.com> (Kenjiro NAKAYAMA's message of "Sat, 21 Dec 2013 19:48:46 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:82321 Archived-At: >>>>> Kenjiro NAKAYAMA writes: >>>>> ivan@siamics.net writes: >> Package: emacs Severity: wishlist >> As currently implemented, eww-display-html simply resets shr-width >> to nil, disrespecting any user=E2=80=99s customization thereof, and >> providing no easy way to specify the HTML rendering width to use in >> EWW buffers. > Yes, I think so too. I wrote the patch to cusomize rendering-width > (shr-width) easily by users. ACK, thanks! [=E2=80=A6] > --- a/lisp/net/eww.el > +++ b/lisp/net/eww.el > @@ -129,6 +129,7 @@ See also `eww-form-checkbox-selected-symbol'." > (defvar eww-home-url nil) > (defvar eww-start-url nil) > (defvar eww-contents-url nil) > +(defvar eww-rendering-width nil) Shouldn=E2=80=99t it rather be defcustom? > (defvar eww-local-regex "localhost" > "When this regex is found in the URL, it's not a keyword but an addre= ss.") > @@ -255,7 +256,7 @@ word(s) will be searched for via `eww-search-prefix'= ." > (setq eww-current-dom document) > (let ((inhibit-read-only t) > (after-change-functions nil) > - (shr-width nil) > + (shr-width eww-rendering-width) I=E2=80=99d also ask for a separate =E2=80=9Cdo not override=E2=80=9D valu= e. That is: (shr-width (if (DO-NOT-SET-P eww-rendering-width) shr-width eww-rendering-width)) (And, similarly, defcustom=E2=80=99s :type above being a =E2=80=98choice= =E2=80=99.) > (shr-target-id (url-target (url-generic-parse-url url))) > (shr-external-rendering-functions > '((title . eww-tag-title) [=E2=80=A6] > @@ -543,6 +546,15 @@ appears in a or tag." > (url-retrieve eww-current-url 'eww-render > (list eww-current-url (point)))) > +(defun eww-set-rendering-width (width) > + "Set the redering width." > + (interactive "nSet new redering width (0: window-width) :") > + (if (zerop width) > + (setq eww-rendering-width nil) > + (if (wholenump width) > + (setq eww-rendering-width width) > + (message "Set Number to rendering width")))) Shouldn=E2=80=99t this rather be =E2=80=98error=E2=80=99? > + > ;; Form support. > (defvar eww-form nil) --=20 FSF associate member #7257