From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Bremner Newsgroups: gmane.emacs.bugs Subject: bug#18513: 24.3; message-mode sends unencrypted on error Date: Mon, 29 Sep 2014 14:14:00 +0200 Message-ID: <87k34mei9j.fsf@maritornes.cs.unb.ca> References: <878ulebz1x.fsf@maritornes.cs.unb.ca> <87zjdid6ny.fsf-ueno@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1411992932 18027 80.91.229.3 (29 Sep 2014 12:15:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 29 Sep 2014 12:15:32 +0000 (UTC) Cc: 18513@debbugs.gnu.org To: Daiki Ueno Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 29 14:15:26 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XYZrM-0005rs-15 for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Sep 2014 14:15:20 +0200 Original-Received: from localhost ([::1]:36178 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYZrL-0006k0-JU for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Sep 2014 08:15:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46083) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYZrE-0006ja-UK for bug-gnu-emacs@gnu.org; Mon, 29 Sep 2014 08:15:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYZr9-0007RP-RZ for bug-gnu-emacs@gnu.org; Mon, 29 Sep 2014 08:15:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35101) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYZr9-0007LK-Oi for bug-gnu-emacs@gnu.org; Mon, 29 Sep 2014 08:15:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XYZr3-0004Kd-V6 for bug-gnu-emacs@gnu.org; Mon, 29 Sep 2014 08:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: David Bremner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Sep 2014 12:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18513 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18513-submit@debbugs.gnu.org id=B18513.141199285016581 (code B ref 18513); Mon, 29 Sep 2014 12:15:01 +0000 Original-Received: (at 18513) by debbugs.gnu.org; 29 Sep 2014 12:14:10 +0000 Original-Received: from localhost ([127.0.0.1]:54898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XYZqE-0004JN-44 for submit@debbugs.gnu.org; Mon, 29 Sep 2014 08:14:10 -0400 Original-Received: from yantan.tethera.net ([199.188.72.155]:38305) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XYZqB-0004JC-Cc for 18513@debbugs.gnu.org; Mon, 29 Sep 2014 08:14:08 -0400 Original-Received: from remotemail by yantan.tethera.net with local (Exim 4.80) (envelope-from ) id 1XYZq8-0001Qx-QA; Mon, 29 Sep 2014 09:14:04 -0300 Original-Received: (nullmailer pid 22617 invoked by uid 1000); Mon, 29 Sep 2014 12:14:00 -0000 In-Reply-To: <87zjdid6ny.fsf-ueno@gnu.org> User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93866 Archived-At: Daiki Ueno writes: > I've installed the following simple fix in the trunk. Does it work for you? > === modified file 'lisp/gnus/mml.el' > --- lisp/gnus/mml.el 2014-03-24 01:56:03 +0000 > +++ lisp/gnus/mml.el 2014-09-29 11:00:11 +0000 > @@ -257,7 +257,9 @@ > ((string= mode "encrypt") > (setq tags (list "encrypt" method))) > ((string= mode "signencrypt") > - (setq tags (list "sign" method "encrypt" method)))) > + (setq tags (list "sign" method "encrypt" method))) > + (t > + (error "Unknown secure mode %s" mode))) > (eval `(mml-insert-tag ,secure-mode > ,@tags > ,(if keyfile "keyfile") It's definitely an improvement, and it fixes the scenario I reported. On the other hand, if the use corrupts the #secure tag then essentially the same behaviour results. Would it be possible to have a strict mode where any unknown mml tag causes an error? David