* bug#10602: Visiting archives changes directory time
@ 2012-01-25 20:03 Juri Linkov
2012-04-17 1:59 ` Glenn Morris
0 siblings, 1 reply; 5+ messages in thread
From: Juri Linkov @ 2012-01-25 20:03 UTC (permalink / raw)
To: 10602
Using archive-mode or tar-mode to visit archives touches
directory modification dates. This is especially annoying
when archives are located in backup directories. The problem
is in the function `insert' that temporarily modifies the
archive summary buffer causing lock-file to create a lock file
in the current directory that modifies the directory timestamp.
A similar bug#2295 was fixed by let-binding `buffer-file-truename'
to nil to prevent directory time modification in `lock_file'.
This is not a regression, so I propose to install in 24.2 something like
=== modified file 'lisp/arc-mode.el'
--- lisp/arc-mode.el 2012-01-19 07:21:25 +0000
+++ lisp/arc-mode.el 2012-01-25 19:54:01 +0000
@@ -783,7 +784,8 @@ (defun archive-summarize (&optional shut
Optional argument SHUT-UP, if non-nil, means don't print messages
when parsing the archive."
(widen)
- (let ((inhibit-read-only t))
+ (let ((buffer-file-truename nil) ; avoid changing dir mtime by lock_file
+ (inhibit-read-only t))
(setq archive-proper-file-start (copy-marker (point-min) t))
(set (make-local-variable 'change-major-mode-hook) 'archive-desummarize)
(or shut-up
=== modified file 'lisp/tar-mode.el'
--- lisp/tar-mode.el 2012-01-19 07:21:25 +0000
+++ lisp/tar-mode.el 2012-01-25 19:54:01 +0000
@@ -520,12 +520,13 @@ (defun tar-summarize-buffer ()
(progress-reporter-done progress-reporter)
(message "Warning: premature EOF parsing tar file"))
(goto-char (point-min))
- (let ((inhibit-read-only t)
+ (let ((buffer-file-truename nil) ; avoid changing dir mtime by lock_file
+ (inhibit-read-only t)
(total-summaries
(mapconcat 'tar-header-block-summarize tar-parse-info "\n")))
- (insert total-summaries "\n"))
+ (insert total-summaries "\n")
(goto-char (point-min))
- (restore-buffer-modified-p modified)))
+ (restore-buffer-modified-p modified))))
\f
(defvar tar-mode-map
(let ((map (make-keymap)))
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#10602: Visiting archives changes directory time
2012-01-25 20:03 bug#10602: Visiting archives changes directory time Juri Linkov
@ 2012-04-17 1:59 ` Glenn Morris
2012-04-18 5:27 ` Juri Linkov
0 siblings, 1 reply; 5+ messages in thread
From: Glenn Morris @ 2012-04-17 1:59 UTC (permalink / raw)
To: Juri Linkov; +Cc: 10602
Juri Linkov wrote:
> This is not a regression, so I propose to install in 24.2 something like
You could install this now if you like...
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#10602: Visiting archives changes directory time
2012-04-17 1:59 ` Glenn Morris
@ 2012-04-18 5:27 ` Juri Linkov
2014-12-08 23:33 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 5+ messages in thread
From: Juri Linkov @ 2012-04-18 5:27 UTC (permalink / raw)
To: Glenn Morris; +Cc: 10602
>> This is not a regression, so I propose to install in 24.2 something like
>
> You could install this now if you like...
There are more patches I submitted for 24.2 and some of them are
not a complete solution. Next week I'll start going through the list
of open issues and look if they could be improved before committing.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#10602: Visiting archives changes directory time
2012-04-18 5:27 ` Juri Linkov
@ 2014-12-08 23:33 ` Lars Magne Ingebrigtsen
2014-12-09 0:34 ` Juri Linkov
0 siblings, 1 reply; 5+ messages in thread
From: Lars Magne Ingebrigtsen @ 2014-12-08 23:33 UTC (permalink / raw)
To: Juri Linkov; +Cc: 10602
Juri Linkov <juri@jurta.org> writes:
>>> This is not a regression, so I propose to install in 24.2 something like
>>
>> You could install this now if you like...
>
> There are more patches I submitted for 24.2 and some of them are
> not a complete solution. Next week I'll start going through the list
> of open issues and look if they could be improved before committing.
This is also marked as pending, but has not been applied in two years...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#10602: Visiting archives changes directory time
2014-12-08 23:33 ` Lars Magne Ingebrigtsen
@ 2014-12-09 0:34 ` Juri Linkov
0 siblings, 0 replies; 5+ messages in thread
From: Juri Linkov @ 2014-12-09 0:34 UTC (permalink / raw)
To: Lars Magne Ingebrigtsen; +Cc: 10602
forcemerge 2295 10602
thanks
> This is also marked as pending, but has not been applied in two years...
Sorry, I forgot to merge it with bug#2295 where I already installed
this patch two years ago.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-12-09 0:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-25 20:03 bug#10602: Visiting archives changes directory time Juri Linkov
2012-04-17 1:59 ` Glenn Morris
2012-04-18 5:27 ` Juri Linkov
2014-12-08 23:33 ` Lars Magne Ingebrigtsen
2014-12-09 0:34 ` Juri Linkov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).