From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Benjamin Riefenstahl Newsgroups: gmane.emacs.bugs Subject: bug#22250: 25.0.50; Eww fails to break RTL paragraph Date: Mon, 28 Dec 2015 19:15:50 +0100 Message-ID: <87k2nyigmh.fsf@justinian.turtle-trading.net> References: <8760zj3dvr.fsf@justinian.i-did-not-set--mail-host-address--so-tickle-me> <83twn3g0ac.fsf@gnu.org> <8760zjbi9s.fsf@justinian.turtle-trading.net> <83k2nzfdt9.fsf@gnu.org> <87twn2il10.fsf@justinian.turtle-trading.net> <83bn9afqfz.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1451326585 11570 80.91.229.3 (28 Dec 2015 18:16:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Dec 2015 18:16:25 +0000 (UTC) Cc: 22250@debbugs.gnu.org, larsi@gnus.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 28 19:16:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aDcL6-0003HD-Pu for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Dec 2015 19:16:12 +0100 Original-Received: from localhost ([::1]:45725 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDcL6-0001ys-7G for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Dec 2015 13:16:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53692) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDcKz-0001yN-HR for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2015 13:16:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aDcKw-000863-BK for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2015 13:16:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39047) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDcKw-00085y-7j for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2015 13:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aDcKv-0006lH-Sv for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2015 13:16:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Benjamin Riefenstahl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Dec 2015 18:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22250 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 22250-submit@debbugs.gnu.org id=B22250.145132655925981 (code B ref 22250); Mon, 28 Dec 2015 18:16:01 +0000 Original-Received: (at 22250) by debbugs.gnu.org; 28 Dec 2015 18:15:59 +0000 Original-Received: from localhost ([127.0.0.1]:46649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDcKs-0006kz-Sz for submit@debbugs.gnu.org; Mon, 28 Dec 2015 13:15:59 -0500 Original-Received: from odoacer.turtle-trading.net ([217.91.34.180]:48797) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDcKr-0006kj-7a for 22250@debbugs.gnu.org; Mon, 28 Dec 2015 13:15:57 -0500 Original-Received: from justinian.turtle-trading.net ([192.168.2.118]) by odoacer.turtle-trading.net with esmtp (Exim 4.80) (envelope-from ) id 1aDcKk-0001hn-PC; Mon, 28 Dec 2015 19:15:50 +0100 Original-Received: from benny by justinian.turtle-trading.net with local (Exim 4.84) (envelope-from ) id 1aDcKk-0001U9-LE; Mon, 28 Dec 2015 19:15:50 +0100 In-Reply-To: <83bn9afqfz.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 28 Dec 2015 19:12:00 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:110903 Archived-At: >> Eli Zaretskii writes: >> > Does the patch below fix the problem? >> From: Benjamin Riefenstahl >> Sorry, no, no change here with that. Eli Zaretskii writes: > ??? It certainly solved the problem with your original HTML file > visited with eww-open-file. Doesn't it solve that for you? Are you > sure you tested correctly? And what exactly did you test? Ah, I'm sorry, I forgot about that one, my bad. You are right, my first test case is indeed fixed by your patch. Just my actual problem is not, including the last script-based test case I made. (Which I was working on the whole evening yesterday :-() >> I looked at the code though and I noticed the call stack >> >> shr-fill-line >> -> shr-vertical-motion >> -> vertical-motion >> >> which is used to find the line break point. It seems the idea here is >> that Emacs' normal line wrap is used, we just go one line down, and >> vertical-motion gets us to the place where Emacs has wrapped. > > No, that's not how this works, AFAIK. (But Lars can correct me if I'm > wrong.) What it does is go to the column where it wants to wrap and > then checks if it's at EOL. If not, it goes back and looks for a > place to insert a newline. Rinse, repeat. Fact is that vertical-motion is called in the course of determining the break (I think as part of "go to the column where it wants to wrap") and that my actual problems and the script test case seem to be solved by setting truncate-lines to nil. We have two different bugs here, because my first test case is *not* fixed just by setting truncate-lines to nil. >> I'm wondering why this bug depends on RTL layout. Here I was talking about the script test case I sent, not the first test case, which I had entirely forgotten about. > I'm wondering why it happens at all, after the patch I sent. When > bidi-display-reordering is set to nil, there is no RTL layout, any > text is laid out in strict logical left-to-right order. > >> I tried my test case without dir=rtl and with "abc" as text, but >> that works fine, so RTL really is a factor. > > It cannot be, not when bidi-display-reordering is bound to nil. > Something else is at work there. Again, I am sorry for the confusion.