unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Benjamin Riefenstahl <b.riefenstahl@turtle-trading.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 22250@debbugs.gnu.org, larsi@gnus.org
Subject: bug#22250: 25.0.50; Eww fails to break RTL paragraph
Date: Mon, 28 Dec 2015 19:15:50 +0100	[thread overview]
Message-ID: <87k2nyigmh.fsf@justinian.turtle-trading.net> (raw)
In-Reply-To: <83bn9afqfz.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 28 Dec 2015 19:12:00 +0200")

>> Eli Zaretskii writes:
>> > Does the patch below fix the problem?

>> From: Benjamin Riefenstahl <b.riefenstahl@turtle-trading.net>
>> Sorry, no, no change here with that. 

Eli Zaretskii writes:
> ??? It certainly solved the problem with your original HTML file
> visited with eww-open-file.  Doesn't it solve that for you?  Are you
> sure you tested correctly?  And what exactly did you test?

Ah, I'm sorry, I forgot about that one, my bad.  You are right, my first
test case is indeed fixed by your patch.

Just my actual problem is not, including the last script-based test case
I made.  (Which I was working on the whole evening yesterday :-()

>> I looked at the code though and I noticed the call stack
>> 
>>   shr-fill-line
>>    -> shr-vertical-motion
>>       -> vertical-motion
>> 
>> which is used to find the line break point.  It seems the idea here is
>> that Emacs' normal line wrap is used, we just go one line down, and
>> vertical-motion gets us to the place where Emacs has wrapped.
>
> No, that's not how this works, AFAIK.  (But Lars can correct me if I'm
> wrong.)  What it does is go to the column where it wants to wrap and
> then checks if it's at EOL.  If not, it goes back and looks for a
> place to insert a newline.  Rinse, repeat.

Fact is that vertical-motion is called in the course of determining the
break (I think as part of "go to the column where it wants to wrap") and
that my actual problems and the script test case seem to be solved by
setting truncate-lines to nil.

We have two different bugs here, because my first test case is *not*
fixed just by setting truncate-lines to nil.

>> I'm wondering why this bug depends on RTL layout.

Here I was talking about the script test case I sent, not the first test
case, which I had entirely forgotten about.

> I'm wondering why it happens at all, after the patch I sent.  When
> bidi-display-reordering is set to nil, there is no RTL layout, any
> text is laid out in strict logical left-to-right order.
>
>> I tried my test case without dir=rtl and with "abc" as text, but
>> that works fine, so RTL really is a factor.
>
> It cannot be, not when bidi-display-reordering is bound to nil.
> Something else is at work there.

Again, I am sorry for the confusion.





  parent reply	other threads:[~2015-12-28 18:15 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-27 19:11 bug#22250: 25.0.50; Eww fails to break RTL paragraph Benjamin Riefenstahl
2015-12-27 19:27 ` Eli Zaretskii
2015-12-27 23:09   ` Benjamin Riefenstahl
2015-12-28  3:32     ` Eli Zaretskii
2015-12-28 16:40       ` Benjamin Riefenstahl
2015-12-28 17:12         ` Eli Zaretskii
2015-12-28 17:49           ` Eli Zaretskii
2015-12-28 18:15           ` Benjamin Riefenstahl [this message]
2015-12-28 18:30             ` Eli Zaretskii
2015-12-28 21:23               ` Benjamin Riefenstahl
2015-12-29 16:47                 ` Eli Zaretskii
2015-12-29 20:55                   ` Benjamin Riefenstahl
2015-12-29 21:03                     ` Eli Zaretskii
2015-12-29 22:33                       ` Benjamin Riefenstahl
2015-12-30 17:04                         ` Eli Zaretskii
2015-12-30 20:22                           ` Benjamin Riefenstahl
2015-12-30 20:30                             ` Benjamin Riefenstahl
2015-12-31 15:26                             ` Eli Zaretskii
2015-12-31 18:10                               ` Benjamin Riefenstahl
2015-12-31 18:23                                 ` Eli Zaretskii
2015-12-30 17:15                       ` Eli Zaretskii
2015-12-28 16:46       ` Lars Ingebrigtsen
2015-12-28 19:07     ` Benjamin Riefenstahl
2015-12-28 19:29       ` Eli Zaretskii
2015-12-27 19:30 ` Lars Ingebrigtsen
2015-12-27 19:38   ` Eli Zaretskii
2015-12-27 19:45   ` Eli Zaretskii
2015-12-27 19:49     ` Lars Ingebrigtsen
2015-12-27 20:22       ` Eli Zaretskii
2015-12-27 20:28         ` Eli Zaretskii
2015-12-27 21:00           ` Eli Zaretskii
2015-12-27 21:10             ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k2nyigmh.fsf@justinian.turtle-trading.net \
    --to=b.riefenstahl@turtle-trading.net \
    --cc=22250@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).