From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#14776: 24.3.50; [PATCH] parse-time-string performance Date: Tue, 01 Mar 2016 12:05:34 +1100 Message-ID: <87k2ln3t41.fsf@gnus.org> References: <87sizwxwu2.fsf@hochschule-trier.de> <87li5m1geu.fsf@hochschule-trier.de> <87k3l6jedt.fsf@hochschule-trier.de> <87ppuyhw32.fsf@hochschule-trier.de> <87hagaeztj.fsf@hochschule-trier.de> <87hag7zor2.fsf@building.gnus.org> <87y59jwuvd.fsf@hochschule-trier.de> <87r4fby95z.fsf@building.gnus.org> <87k3l3r365.fsf@hochschule-trier.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1456794443 32702 80.91.229.3 (1 Mar 2016 01:07:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 1 Mar 2016 01:07:23 +0000 (UTC) Cc: 14776@debbugs.gnu.org To: Andreas Politz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 01 02:07:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aaYmN-0005QV-6X for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Mar 2016 02:07:11 +0100 Original-Received: from localhost ([::1]:40042 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaYmM-0003Yh-CZ for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Feb 2016 20:07:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaYmJ-0003Ya-2h for bug-gnu-emacs@gnu.org; Mon, 29 Feb 2016 20:07:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aaYmE-0006iO-3I for bug-gnu-emacs@gnu.org; Mon, 29 Feb 2016 20:07:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57245) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aaYmD-0006i8-W7 for bug-gnu-emacs@gnu.org; Mon, 29 Feb 2016 20:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aaYmD-0007my-Re for bug-gnu-emacs@gnu.org; Mon, 29 Feb 2016 20:07:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Mar 2016 01:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14776 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 14776-submit@debbugs.gnu.org id=B14776.145679437829890 (code B ref 14776); Tue, 01 Mar 2016 01:07:01 +0000 Original-Received: (at 14776) by debbugs.gnu.org; 1 Mar 2016 01:06:18 +0000 Original-Received: from localhost ([127.0.0.1]:54372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aaYlS-0007lx-Sw for submit@debbugs.gnu.org; Mon, 29 Feb 2016 20:06:18 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:54985) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aaYlO-0007ll-0h for 14776@debbugs.gnu.org; Mon, 29 Feb 2016 20:06:13 -0500 Original-Received: from 109.179.251.45.tmi.telenormobil.no ([109.179.251.45] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aaYkx-0001Jm-Q2; Tue, 01 Mar 2016 02:05:44 +0100 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Mon, 08 Jul 2013 16:51:11 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aaYkx-0001Jm-Q2 MailScanner-NULL-Check: 1457399145.13661@/hcYeWgxlJ7Tc13SWlsaYg X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:114189 Archived-At: Lars Magne Ingebrigtsen writes: >> Anyway here is an updated version, incorporating 2-digit years and >> textual timezones. > > Looks good. I did some further tests (after the version of parse-time-string on the Emacs trunk had been ... fixed), and the regexp version is still 3x faster (down from 10x). It is, though, a stricter RFC2822 parser than the version we currently have, so it fails on some of the test cases (dates without times, for instance). So I'm still not sure whether this is a suitable replacement for parse-time-string. And it seems odd to have two completely different functions that almost parse the same thing... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no