From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#11028: 24.0.94; bad lighter and menus for `text-scale-mode' Date: Sun, 01 May 2016 21:46:39 +0200 Message-ID: <87k2jdy31c.fsf@gnus.org> References: <0F3DD8B617604CB59C5138747164263F@us.oracle.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1462132066 30287 80.91.229.3 (1 May 2016 19:47:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 1 May 2016 19:47:46 +0000 (UTC) Cc: 11028@debbugs.gnu.org To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 01 21:47:29 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1awxKz-0007ng-Cr for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 May 2016 21:47:29 +0200 Original-Received: from localhost ([::1]:34126 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awxKv-0005GR-2X for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 May 2016 15:47:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35852) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awxKn-00054W-4G for bug-gnu-emacs@gnu.org; Sun, 01 May 2016 15:47:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1awxKb-0000XI-Fi for bug-gnu-emacs@gnu.org; Sun, 01 May 2016 15:47:11 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48679) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awxKb-0000Vd-CS for bug-gnu-emacs@gnu.org; Sun, 01 May 2016 15:47:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1awxKY-0006fP-0j for bug-gnu-emacs@gnu.org; Sun, 01 May 2016 15:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 May 2016 19:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11028 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11028-submit@debbugs.gnu.org id=B11028.146213200325603 (code B ref 11028); Sun, 01 May 2016 19:47:01 +0000 Original-Received: (at 11028) by debbugs.gnu.org; 1 May 2016 19:46:43 +0000 Original-Received: from localhost ([127.0.0.1]:32783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awxKF-0006et-GA for submit@debbugs.gnu.org; Sun, 01 May 2016 15:46:43 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:40868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awxKE-0006em-I2 for 11028@debbugs.gnu.org; Sun, 01 May 2016 15:46:42 -0400 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1awxKB-0001kW-Or; Sun, 01 May 2016 21:46:41 +0200 In-Reply-To: <0F3DD8B617604CB59C5138747164263F@us.oracle.com> (Drew Adams's message of "Fri, 16 Mar 2012 11:54:49 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117539 Archived-At: "Drew Adams" writes: > -1 > ------------------- > Turn Off minor mode > Help for minor mode [...] > Which minor mode? No idea still. This seems like it's been kinda hackishly implemented. This is the function that shows the menu... (defun mouse-minor-mode-menu (event) "Show minor-mode menu for EVENT on minor modes area of the mode line." (interactive "@e") (let ((indicator (car (nth 4 (car (cdr event)))))) (debug event) (minor-mode-menu-from-indicator indicator))) Hm... but then (defun minor-mode-menu-from-indicator (indicator) [...] (let* ((minor-mode (lookup-minor-mode-from-indicator indicator)) (mm-fun (or (get minor-mode :minor-mode-function) minor-mode))) Wow, that's a roundabout way of doing it... Anyway, we then have the mode symbol... What about using a pretty version of the mode symbol as the menu header? That would be "Text Scale Mode" in this case. I think that would be better than using the lighter as the menu header. What's the name of the function that creates pretty strings from symbol names? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no