From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#23982: [master] Treat errno EINPROGRESS and ENOTCONN as EAGAIN for async connection Date: Fri, 15 Jul 2016 23:33:00 -0400 Message-ID: <87k2gmdzpv.fsf@users.sourceforge.net> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1468640066 18747 80.91.229.3 (16 Jul 2016 03:34:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 Jul 2016 03:34:26 +0000 (UTC) Cc: 23982@debbugs.gnu.org To: Jun Hao Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 16 05:34:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bOGMn-0001Mo-If for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Jul 2016 05:34:13 +0200 Original-Received: from localhost ([::1]:35796 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOGMm-0002ul-Bu for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Jul 2016 23:34:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54631) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOGMg-0002tr-Pt for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2016 23:34:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bOGMc-0004Em-Ks for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2016 23:34:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41063) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOGMc-0004Ei-Gg for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2016 23:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bOGMc-0003iO-47 for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2016 23:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Jul 2016 03:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23982 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 23982-submit@debbugs.gnu.org id=B23982.146863998914220 (code B ref 23982); Sat, 16 Jul 2016 03:34:02 +0000 Original-Received: (at 23982) by debbugs.gnu.org; 16 Jul 2016 03:33:09 +0000 Original-Received: from localhost ([127.0.0.1]:53400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bOGLl-0003hI-2i for submit@debbugs.gnu.org; Fri, 15 Jul 2016 23:33:09 -0400 Original-Received: from mail-io0-f180.google.com ([209.85.223.180]:35658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bOGLi-0003gq-PC for 23982@debbugs.gnu.org; Fri, 15 Jul 2016 23:33:07 -0400 Original-Received: by mail-io0-f180.google.com with SMTP id m101so119853014ioi.2 for <23982@debbugs.gnu.org>; Fri, 15 Jul 2016 20:33:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=whli1bIgj//TQ9bdJHjIYzTrznGnyvGxqWWOe9D91pk=; b=07ikP8MsbG8RjTXl+PrLgdILV481Bv0cFDsTe7s0balg8IW1DUhPunEKpsEyEfcY0c hXY/8JSjNzFhSWFXDBaWo3C+yoxsbzcL856RIKJoBADUJGno/QoPEYlMODe6/wwRNeez N+l5CEbII2TldfRuBmBr3sR/tVEYI5jMmxHw9AgrOv/mxRcHZKW4UQshHEaSDks+rzZs 2hlaKHPOUTAyCL+M67Smsyk/vjj4zl6a5YC2GoY2wyg51l+CAu8QIvM+fXQ8RvPjjMTI oBZeDwP1QAOJHrCeByRitLTVtP9YVeoLwhfLZ6TtmOnlWx8Zik5MqceEJ6d5rxUlYF8t 9OKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=whli1bIgj//TQ9bdJHjIYzTrznGnyvGxqWWOe9D91pk=; b=HkneAeI9xFtewcEN1qXYI+IgAL8/mn2DnM2aP76a33Ak+Brm4uqNkBNL1z0cnz42Ra vTaSRhQRYEqDGRjGDzS5SsGUAdbos8O+8Lmn4PHA8jszZLfaC1PCiHUaAXIzX3FEPX9C TpMAgsueF3y3XxY/sNKQK5PAi+bETeHww7R+nPK1/GLqMsrof8yV3CIv6q7lUNq2e0X8 MF3g414qbLV6R8PcORy+1jI59n2vaNJFHC6jsjHVbjG7sHaWY/TO++mFNjuyA/FsTMfh tiLEEOwPk9fIjXpYgvJCCfm+s6zI60fnbjyFDJDyeo9+BU+kKRsBQ33yWL46wEI2qeQS AntA== X-Gm-Message-State: ALyK8tJs7lMg9dOeYX6TdBx1Cc0aGuZPTe20PuVuFUETsw9OSqMrkTzewPfgtfwmZijgFQ== X-Received: by 10.107.13.82 with SMTP id 79mr27226591ion.97.1468639981011; Fri, 15 Jul 2016 20:33:01 -0700 (PDT) Original-Received: from zony (206-188-64-44.cpe.distributel.net. [206.188.64.44]) by smtp.googlemail.com with ESMTPSA id v21sm358320ita.0.2016.07.15.20.33.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Jul 2016 20:33:00 -0700 (PDT) In-Reply-To: (Jun Hao's message of "Thu, 14 Jul 2016 22:17:13 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121132 Archived-At: Jun Hao writes: > > For latest master branch, when try to use gnutls with async connection, > the handshake will return fatal error if socket is in ENOTCONN or > EINPROGRESS since gnutls treat these errors as fatal during push/pull > and gives up. The later retry will fail because gnutls will mark the > session invalid. > > This patch is asking gnutls to treat them as EAGAIN which is non-fatal. > > I only tested with OSX. Please see if you can reproduce it on Windows or > Linux and if this patch works for them too. > > To reproduce run: > > emacs -Q --eval "(erc-tls :server \"irc.freenode.net\" :port 6697 :nick \"test\")" > > Current master branch will gave up connecting. On both Window and GNU/Linux this successfully connect both with and without the patch, i.e., patch seems not to be needed on non-OSX platforms, but it doesn't seem to hurt either.