From: npostavs@users.sourceforge.net
To: "Clément Pit--Claudel" <clement.pitclaudel@live.com>
Cc: 24176@debbugs.gnu.org
Subject: bug#24176: Confusing interaction between define-derived-mode and font-lock-add-keywords
Date: Wed, 24 Aug 2016 20:53:15 -0400 [thread overview]
Message-ID: <87k2f5u0sk.fsf_-_@users.sourceforge.net> (raw)
In-Reply-To: <0a87c159-8bd5-3fda-0b03-d1426e6a26d0@live.com> ("Clément Pit--Claudel"'s message of "Sun, 7 Aug 2016 02:57:19 -0400")
severity 24176 minor
tags 24176 confirmed
found 24176 25.1
quit
Clément Pit--Claudel <clement.pitclaudel@live.com> writes:
> Sorry, the original report had a confusing example; here is a fixed copy.
>
> (define-derived-mode ~/a fundamental-mode "~/a"
> (font-lock-add-keywords nil `(("a" 0 'font-lock-keyword-face))))
> (define-derived-mode ~/b ~/a "~/b"
> (font-lock-add-keywords nil `(("b" 0 'font-lock-builtin-face))))
> (define-derived-mode ~/c ~/b "~/c"
> (font-lock-add-keywords nil `(("c" 0 'font-lock-constant-face))))
>
> Explicitly calling (setq font-lock-major-mode major-mode) before calling font-lock-add-keywords yields the expected behaviour.
Yeah, it seems `font-lock-set-defaults' (called from
`font-lock-add-keywords') deletes the parent mode's added keywords since
they were not from the "correct" mode.
(defun font-lock-set-defaults ()
"Set fontification defaults appropriately for this mode.
Sets various variables using `font-lock-defaults' and
`font-lock-maximum-decoration'."
;; Set fontification defaults if not previously set for correct major mode.
(unless (and font-lock-set-defaults
(eq font-lock-major-mode major-mode))
(setq font-lock-major-mode major-mode)
(setq font-lock-set-defaults t)
...
next prev parent reply other threads:[~2016-08-25 0:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-07 6:41 bug#24176: Confusing interaction between define-derived-mode and font-lock-add-keywords Clément Pit--Claudel
[not found] ` <handler.24176.B.14705521086608.ack@debbugs.gnu.org>
2016-08-07 6:57 ` bug#24176: Acknowledgement (Confusing interaction between define-derived-mode and font-lock-add-keywords) Clément Pit--Claudel
2016-08-25 0:53 ` npostavs [this message]
2019-11-17 6:59 ` bug#24176: Confusing interaction between define-derived-mode and font-lock-add-keywords Lars Ingebrigtsen
2019-11-17 18:55 ` Stefan Monnier
2022-01-24 10:56 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2f5u0sk.fsf_-_@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=24176@debbugs.gnu.org \
--cc=clement.pitclaudel@live.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).