From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#17544: 24.3; [PATCH] Improved diff-mode navigation/manipulation Date: Sat, 03 Sep 2016 23:27:50 -0400 Message-ID: <87k2es9weh.fsf@users.sourceforge.net> References: <87ha4jgw53.fsf@secretsauce.net> <87si0ion1c.fsf@gnus.org> <87k2et8hr4.fsf@secretsauce.net> <83a8fpe1dr.fsf@gnu.org> <87h99w8ynv.fsf@secretsauce.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1472959701 2935 195.159.176.226 (4 Sep 2016 03:28:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 4 Sep 2016 03:28:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: Andreas Schwab , 17544@debbugs.gnu.org To: Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 04 05:28:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgO6R-0008Lm-3I for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Sep 2016 05:28:16 +0200 Original-Received: from localhost ([::1]:48572 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgO6O-0001Q9-IL for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Sep 2016 23:28:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgO6H-0001Ps-RQ for bug-gnu-emacs@gnu.org; Sat, 03 Sep 2016 23:28:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bgO6E-0006eS-MI for bug-gnu-emacs@gnu.org; Sat, 03 Sep 2016 23:28:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51340) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgO6E-0006eO-Ie for bug-gnu-emacs@gnu.org; Sat, 03 Sep 2016 23:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bgO6E-0006Y0-Bi for bug-gnu-emacs@gnu.org; Sat, 03 Sep 2016 23:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Sep 2016 03:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17544 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 17544-submit@debbugs.gnu.org id=B17544.147295965725138 (code B ref 17544); Sun, 04 Sep 2016 03:28:02 +0000 Original-Received: (at 17544) by debbugs.gnu.org; 4 Sep 2016 03:27:37 +0000 Original-Received: from localhost ([127.0.0.1]:49052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgO5p-0006XN-6q for submit@debbugs.gnu.org; Sat, 03 Sep 2016 23:27:37 -0400 Original-Received: from mail-it0-f49.google.com ([209.85.214.49]:37762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bgO5o-0006XC-71 for 17544@debbugs.gnu.org; Sat, 03 Sep 2016 23:27:36 -0400 Original-Received: by mail-it0-f49.google.com with SMTP id e124so101033341ith.0 for <17544@debbugs.gnu.org>; Sat, 03 Sep 2016 20:27:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=EIskTG9ZvIOQIpts4+v2EI+nTypRA7bE0QHWvL5dsrM=; b=B+N3qNQQ1j7GeTFnFt/42m2VhgfBlRoNev2IBHKq9wJquctI+xs0OkiTpFmvXeyJV8 X0gYRR2fv138alcmtdehJN0SwIbBWI6EJmcghtybsElh4J80MovvjBBcz3LcgqLCdEg2 sC3mIbDaN0h8O64R0GYY2tcGjSadVN+XW37FQruZeqSNQnIjhW5TGyZcCONZfh/m1j68 Mq4/+wBvlpVbKTgj5COiZme6Wnumx/O+VPh6cuw4CyZHUJSDvJJniP3OCz62/zCrnqhs bcQCakP3kNOYldc80FeCFjOY0mLKnHWF+LVsU3zZGTAtLG9fS7LPeq2NDu6l1Qoz5Gy/ pb7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=EIskTG9ZvIOQIpts4+v2EI+nTypRA7bE0QHWvL5dsrM=; b=X8JneKrLfCLb+mA0qpZzwfyUAKxg4KRlX6k1fPnQFOW2AqkvBBLHJCubj+AL/J9irl dN4o25bZIW2p4sT7tDZmSEm77nHiiXU2qa9u0Ks48bjUOQ2C2vRKkhx+bm/PExpuIWGh UUIMRhiMdAOKC0wMB+fWjftPWMIsXqjH1WySZIuk/qx4jMsDbbPJIxQz8BwVjxInWDA9 Ec83KQMBLlJ5IGITfAPzA7d8/n+pQkR8GKODFD6GRdNwitr+oV4zDYX0evCuTH1duufd iU64x6QjB/5r4k7c7NUHdWvZn+xH4m4A4LNh69llXum6oucoKvGhiRXmXfu6rlFaPM+l hzMQ== X-Gm-Message-State: AE9vXwP450JXPd+w1Vhd6FYgML/C35yVZbSm5sfotO2df1qxZ7zn6gcX4is0fNXvJcVB2w== X-Received: by 10.36.214.193 with SMTP id o184mr14911399itg.5.1472959650666; Sat, 03 Sep 2016 20:27:30 -0700 (PDT) Original-Received: from zony ([45.2.7.130]) by smtp.googlemail.com with ESMTPSA id z125sm3384413itc.0.2016.09.03.20.27.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 03 Sep 2016 20:27:30 -0700 (PDT) In-Reply-To: <87h99w8ynv.fsf@secretsauce.net> (Dima Kogan's message of "Sat, 03 Sep 2016 14:24:20 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122918 Archived-At: Dima Kogan writes: > >> and the whole issue of testing called-interactively-p that goes with >> it. Can you explain? > > I'm guessing the interactivity checking in diff-hunk-next and > diff-hunk-prev was intended to keep scripts working as before. Again, it > has been too long to remember specifically. IMO, it would make more sense to just define your new commands directly, something like: (defun diff-hunk-next-command (&optional count) "." (interactive "p") (let ((start (point))) (let ((hunk-bounds (diff-bounds-of-hunk))) (goto-char (car hunk-bounds))) (diff-hunk-next count) (when (not (looking-at diff-hunk-header-re)) (goto-char start) (user-error "No next hunk")))) And then just give the *binding* of `diff-hunk-next' to `diff-hunk-next-command'. No need to make a higher order wrapper function just for defining 2 functions.