From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#24362: 25.1.50; Inconsistent docstring between pcase-let and pcase-let* Date: Thu, 15 Sep 2016 23:36:21 +0200 Message-ID: <87k2ecalre.fsf@web.de> References: <87fup2nkry.fsf@cochranmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1473975450 5941 195.159.176.226 (15 Sep 2016 21:37:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 15 Sep 2016 21:37:30 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: Chunyang Xu , 24362@debbugs.gnu.org To: Robert Cochran Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 15 23:37:26 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkeLL-0000AJ-4h for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Sep 2016 23:37:15 +0200 Original-Received: from localhost ([::1]:37497 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkeLI-0007We-U9 for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Sep 2016 17:37:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkeLC-0007WF-8e for bug-gnu-emacs@gnu.org; Thu, 15 Sep 2016 17:37:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkeL8-0003Bm-3O for bug-gnu-emacs@gnu.org; Thu, 15 Sep 2016 17:37:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34870) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkeL8-0003Bh-0I for bug-gnu-emacs@gnu.org; Thu, 15 Sep 2016 17:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bkeL7-00014W-My for bug-gnu-emacs@gnu.org; Thu, 15 Sep 2016 17:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Sep 2016 21:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24362 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24362-submit@debbugs.gnu.org id=B24362.14739754054099 (code B ref 24362); Thu, 15 Sep 2016 21:37:01 +0000 Original-Received: (at 24362) by debbugs.gnu.org; 15 Sep 2016 21:36:45 +0000 Original-Received: from localhost ([127.0.0.1]:60815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkeKr-000143-I8 for submit@debbugs.gnu.org; Thu, 15 Sep 2016 17:36:45 -0400 Original-Received: from mout.web.de ([212.227.17.12]:59521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkeKp-00013p-H0 for 24362@debbugs.gnu.org; Thu, 15 Sep 2016 17:36:44 -0400 Original-Received: from drachen.dragon ([90.186.1.83]) by smtp.web.de (mrweb103) with ESMTPSA (Nemesis) id 0MCqkB-1bsf4d3bZj-009ko6; Thu, 15 Sep 2016 23:36:33 +0200 In-Reply-To: <87fup2nkry.fsf@cochranmail.com> (Robert Cochran's message of "Wed, 14 Sep 2016 16:06:57 -0700") X-Provags-ID: V03:K0:eL6MXGebYtpvRruUQHHbK/kp0Zl+2VJdz/JknTGEOhljmkg4gp6 3f0zChWD+tpxqxHBOTnAOMrPUWAzdoAs7byVxtHlvUKKR+mmoCPDV10am7BYVUUW2aVU1bX 7ZEtPFzH5amEtTv3s7KcxmK8HdYnPV7+G/ZKQpCEQJj7Ji4y7gc9rnut+NWwQm0CXAr8bRQ CU3tRfNeJwJb58gy4zFzg== X-UI-Out-Filterresults: notjunk:1;V01:K0:9PKs+I4mdOc=:tO4JRn697Fe/2AsCU2FFhh 7+tJvutTJQm16hiX4lnzgdE0A+JE+6yx+QPAf6LJ9URiG5j1PdgzlfG6ls7l9RTNrueSRz/1V yHn56T0+8pPJng9x6Sjr5zntSzCtxkSR9k+hU5ovkApBvBGrj4bEjD6mBsGJYSx+4zF0xGrx6 VYPQ06Jfds8eIW47vIY7FMfp0zjt0FQFx2KP8aRIKJz6lu0hH1qRmbr0AbQSuZrWRSK6KaxMb J+l0unDhTKQxEOIYRwyUqgtqQ+0+8ufnXeMavM2f8toU2ocgGl57Fm/8FRD0z61uqNLDGP3J/ 6kGpAEIHzRtIM22idTTqEGzJtzL1sj7K5JLN+DNOOCObUVy9h6ZGsXzl2Othx/VvEtizG/px3 Qzd11q5G9nRKJkfFvThg0A1udlVTehMy3ampNEG2Aq2LJkODJtX45SKR2GE6k+OKXHbyLpCJm Z7tBfEbQvaF61G5vlHZaHFHWad9kNVfNS+Pv/IZeqPl9pPtEfWdQ9+GcEA+sCnbxoKnSyQNih ZLa6Q3NENUK2h7xV/Op8+9NdMUo/vQCPXIOogSSXN2LNkrYQL46SFh2ZegsaF3MqlL8yRdzt3 iIFWlF3D2UQSjwZ8BjKtTpwhm1l7YYmxL6jgWYuQl8rCkRuFf1QMHr9HxMH4V+kbCGTKuUGqP ZqvE3nF0gq0LzhWfg4U2tru/djBB0RBn22K87XLLcGvvBlIFLGZTMx27EgNfMVDiPh5gJhBN/ gGOGX4NwuMy3hpMoGzATP3cqOX/CssA7npO/b2tootLFKf8huMd5SK7L4pU+1GYagHul4/4z X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123360 Archived-At: Robert Cochran writes: > This patch changes the pcase-let* docstring to match the pcase-let > docstring, but IMO I don't think that the phrase 'a list of > expressions' is exactly the right term for this. That (to me) implies > that we are wrapping the whole body in a list, which you don't. Isn't this just normal "Elisp speak" for a &rest parameter? Sure, the value of the parameter doesn't appear in the code (only "spliced in") - but we use this wording all the time. > diff --git a/lisp/emacs-lisp/pcase.el b/lisp/emacs-lisp/pcase.el > index 0b8dddf..2d61642 100644 > --- a/lisp/emacs-lisp/pcase.el > +++ b/lisp/emacs-lisp/pcase.el > @@ -261,7 +261,7 @@ pcase--let* > ;;;###autoload > (defmacro pcase-let* (bindings &rest body) > "Like `let*' but where you can use `pcase' patterns for bindings. > -BODY should be an expression, and BINDINGS should be a list of bindings > +BODY should be a list of expressions, and BINDINGS should be a list of bindings Looks ok to me. Michael.