From: Tino Calancha <tino.calancha@gmail.com>
To: 27584@debbugs.gnu.org
Cc: nicolas petton <nicolas@petton.fr>,
stefan monnier <monnier@iro.umontreal.ca>
Subject: bug#27584: 26.0.50; alist-get: Add optional arg TESTFN
Date: Wed, 05 Jul 2017 17:53:29 +0900 [thread overview]
Message-ID: <87k23n8dti.fsf@calancha-pc> (raw)
In-Reply-To: <87tw2rva7v.fsf@calancha-pc>
>
> -(defun assoc-default (key alist &optional test default)
> +(defun assoc-default (key alist &optional test default full)
> "Find object KEY in a pseudo-alist ALIST.
> ALIST is a list of conses or objects. Each element
> (or the element's car, if it is a cons) is compared with KEY by
> calling TEST, with two arguments: (i) the element or its car,
> and (ii) KEY.
> If that is non-nil, the element matches; then `assoc-default'
> - returns the element's cdr, if it is a cons, or DEFAULT if the
> - element is not a cons.
> + returns the element, if it is a cons and FULL is non-nil,
> + or the element's cdr, if it is a cons and FULL is nil,
> + or DEFAULT if the element is not a cons.
>
> If no element matches, the value is nil.
> If TEST is omitted or nil, `equal' is used."
> (let (found (tail alist) value)
> (while (and tail (not found))
> (let ((elt (car tail)))
> - (when (funcall (or test 'equal) (if (consp elt) (car elt) elt) key)
> - (setq found t value (if (consp elt) (cdr elt) default))))
> + (when (funcall (or test 'equal) (if (consp elt) (car elt) elt) key)
> + (setq found t
> + value (cond ((consp elt)
> + (if full elt (cdr elt)))
> + (t default)))))
> (setq tail (cdr tail)))
> value))
If we go in this direction, then i think it has sense to add
something with less parameters, like this:
(defsubst assoc-predicate (key alist test)
"Like `assoc' but compare keys with TEST."
(assoc-default key alist test nil 'full))
next prev parent reply other threads:[~2017-07-05 8:53 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 3:22 bug#27584: 26.0.50; alist-get: Add optional arg TESTFN Tino Calancha
2017-07-05 8:53 ` Tino Calancha [this message]
2017-07-05 9:19 ` Nicolas Petton
2017-07-05 13:18 ` Tino Calancha
2017-07-06 6:05 ` Tino Calancha
2017-07-06 6:13 ` Stefan Monnier
2017-07-06 6:20 ` Tino Calancha
2017-07-06 9:36 ` Nicolas Petton
2017-07-06 10:55 ` Tino Calancha
2017-07-06 11:06 ` Nicolas Petton
2017-07-06 15:07 ` Stefan Monnier
2017-07-07 6:48 ` Tino Calancha
2017-07-07 7:46 ` Eli Zaretskii
2017-07-07 8:09 ` Nicolas Petton
2017-07-07 15:53 ` Stefan Monnier
2017-07-09 14:45 ` Tino Calancha
2017-07-10 12:04 ` Michael Heerdegen
2017-07-10 12:28 ` Tino Calancha
2017-07-10 12:38 ` Michael Heerdegen
2017-07-10 12:47 ` Michael Heerdegen
2017-07-10 13:02 ` Tino Calancha
2017-07-10 13:18 ` Michael Heerdegen
2017-07-10 12:50 ` Michael Heerdegen
2017-07-06 14:56 ` Nicolas Petton
2017-07-07 6:39 ` Tino Calancha
2017-07-07 8:11 ` Nicolas Petton
2017-07-07 8:22 ` Tino Calancha
2017-07-07 8:34 ` Nicolas Petton
2017-07-07 15:49 ` Stefan Monnier
2017-07-07 15:54 ` Nicolas Petton
2017-07-07 19:47 ` Nicolas Petton
2017-07-08 6:30 ` Eli Zaretskii
2017-07-08 7:02 ` Tino Calancha
2017-07-08 7:14 ` Eli Zaretskii
2017-07-08 11:32 ` Nicolas Petton
2017-07-08 11:46 ` Eli Zaretskii
2017-07-09 14:48 ` Tino Calancha
2017-07-09 19:18 ` Nicolas Petton
2017-07-11 8:08 ` Nicolas Petton
2017-07-11 9:19 ` Tino Calancha
2017-07-12 17:36 ` Michael Heerdegen
2017-07-14 5:19 ` Tino Calancha
2017-07-14 11:16 ` Nicolas Petton
2017-07-17 13:38 ` Tino Calancha
2017-08-01 16:37 ` Nicolas Petton
2017-08-01 16:49 ` Nicolas Petton
2017-08-01 18:53 ` Eli Zaretskii
2017-07-08 11:29 ` Nicolas Petton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k23n8dti.fsf@calancha-pc \
--to=tino.calancha@gmail.com \
--cc=27584@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=nicolas@petton.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).