From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#20890: 25.0.50; build from git crashes on startup Date: Tue, 03 Apr 2018 11:39:10 +0200 Message-ID: <87k1towrwh.fsf@gmail.com> References: <55B54371.4000907@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1522748357 17304 195.159.176.226 (3 Apr 2018 09:39:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 3 Apr 2018 09:39:17 +0000 (UTC) Cc: Robert Marshall , Paul Eggert To: 20890@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 03 11:39:13 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f3IPJ-0004OU-3U for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Apr 2018 11:39:13 +0200 Original-Received: from localhost ([::1]:47657 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f3IRM-0007UB-Q4 for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Apr 2018 05:41:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50056) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f3IQC-0006eJ-6j for bug-gnu-emacs@gnu.org; Tue, 03 Apr 2018 05:40:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f3IQ6-0007JW-6m for bug-gnu-emacs@gnu.org; Tue, 03 Apr 2018 05:40:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56165) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f3IQ6-0007JK-30 for bug-gnu-emacs@gnu.org; Tue, 03 Apr 2018 05:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f3IQ5-0001GT-Ky for bug-gnu-emacs@gnu.org; Tue, 03 Apr 2018 05:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Apr 2018 09:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20890 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20890-submit@debbugs.gnu.org id=B20890.15227483594800 (code B ref 20890); Tue, 03 Apr 2018 09:40:01 +0000 Original-Received: (at 20890) by debbugs.gnu.org; 3 Apr 2018 09:39:19 +0000 Original-Received: from localhost ([127.0.0.1]:35829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f3IPO-0001FM-Nj for submit@debbugs.gnu.org; Tue, 03 Apr 2018 05:39:18 -0400 Original-Received: from mail-wr0-f175.google.com ([209.85.128.175]:39667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f3IPN-0001F8-Nv for 20890@debbugs.gnu.org; Tue, 03 Apr 2018 05:39:18 -0400 Original-Received: by mail-wr0-f175.google.com with SMTP id c24so17920583wrc.6 for <20890@debbugs.gnu.org>; Tue, 03 Apr 2018 02:39:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=ZqvLG+xkbfrzFgW1YkZyhUmrSVbSEfT1oHoW95flWSw=; b=R7SOj85M2P2+RyX/qXgCpki4mUsdn1cVKi/H+QIhnXrt3NagD/q0Ymig6schpbOgcb 6js4RCp5rmpiWaVOvkNj76EBGzopp9O4eJHcN44inMUKbm6xuHq2COZfhrIJV7Ejav/P 1gGbJ/oFQUgNaYs4rqqh9FCCd6Da/n7EDwntErAIZLXaBDH2FtHsEAuA43JLxI638bIm Z5htWZB4hR2HIa+pyfYxcIzent+7I2hggkAkogDYCSAtxqVZarAztOTYiAD32zXs6A0r cKfsDbaOEEKrBb1ExwTMj+Z5/tCf5E4fPuXUHoomOMOFig1PWA6qbZ60hmuzt5/FmXc6 CVXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=ZqvLG+xkbfrzFgW1YkZyhUmrSVbSEfT1oHoW95flWSw=; b=JNnyMxxl7gMFCOs0ICqC87V0q+r95yglY9DMsOzdtICAE51cAnvmwXym5z6XHXYArM +CrrM5g9DBQFPobmBFm8CBaqCSMJd6j+1jjMGyi2DiMIUEQo6Q9IAobBCngsEF6N2J/M hFBSKur+WQAAajdbxkmkyvhiu3KsDlMBqg6AH/lUhQRYpdxpdal6KEO8SNc2UqfuL1vK GDUs2nleYRl4tFx0XnfTVbfB0dTRh8+SD7cSI9vGrpxWHySFBX1Hz9/LXyFECk2/gF/I z6CJZSPIhSg2GA5wIyqnhVmKHvHN6P+vMdv2pu1FrKipV4QG0vSD8k0MPDdF5dZr84hF iCMA== X-Gm-Message-State: AElRT7Fu0ErHdFAjDYBQQMJ4JHHJk6RAZRn23nI/gZ9gTx0CcRlvuHkO UOU2/FraK54WdmKIFg3bRns= X-Google-Smtp-Source: AIpwx48iWA7yiZFAwJ44kCN1HYF+BU2WrbETMrEtruRlPVh10uX3R22vnBSjhqs4EqcCZkeBXTRGcQ== X-Received: by 10.223.208.202 with SMTP id z10mr10312073wrh.15.1522748351755; Tue, 03 Apr 2018 02:39:11 -0700 (PDT) Original-Received: from rpluim ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id j126sm214050wmb.33.2018.04.03.02.39.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 03 Apr 2018 02:39:11 -0700 (PDT) In-Reply-To: <55B54371.4000907@cs.ucla.edu> (Paul Eggert's message of "Sun, 26 Jul 2015 13:30:41 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144838 Archived-At: tags 20890 patch Paul Eggert writes: > Thanks for the bug report. From the backtrace it appears that > ftfont_close's implementation incorrectly assumes that ftfont_close > can't be called from the garbage collector. I've installed the > attached FIXME comment and am CC'ing Kenichi Handa, who's an expert in > ftfont.c. Following Eli's suggestion in , I=CA=BCve tested the following workaround. It works, but it doesn=CA=BCt feel like the right thing to do. However, without it, cairo builds are completely unusable, and cairo is something we will need to enable by default in future. Robert diff --git i/src/ftfont.c w/src/ftfont.c index 24a92dd52e..5eda61af0e 100644 --- i/src/ftfont.c +++ w/src/ftfont.c @@ -1249,6 +1249,11 @@ ftfont_close (struct font *font) struct ftfont_info *ftfont_info =3D (struct ftfont_info *) font; Lisp_Object val, cache; =20 +#ifdef USE_CAIRO + /* Bug#20890 workaround. */ + if (gc_in_progress) + return; +#endif val =3D Fcons (font->props[FONT_FILE_INDEX], make_number (ftfont_info->i= ndex)); cache =3D ftfont_lookup_cache (val, FTFONT_CACHE_FOR_FACE); eassert (CONSP (cache));