unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: John Goerzen <jgoerzen@complete.org>
Cc: 30639@debbugs.gnu.org
Subject: bug#30639: 25.1; ERC buffer name not unique, broken on reconnect [patch]
Date: Sat, 14 Apr 2018 20:11:15 +0200	[thread overview]
Message-ID: <87k1t94q0s.fsf@mouse.gnus.org> (raw)
In-Reply-To: <877eqyrv80.fsf@complete.org> (John Goerzen's message of "Tue, 27 Feb 2018 15:15:30 -0600")

John Goerzen <jgoerzen@complete.org> writes:

> The comments in the function as given are reasonable, but the logic
> differs.  In particular, the test in the dolist always fails when
> (get-buffer candidate) is nil; that is, the test always fails when the
> buffer does not already exist.  This causes the test to drop through to
> the section at the bottom every time, which results not only in the
> server appending logic never being used, but also in the concatenation
> of /server never being attempted.
>
> Here is a working replacement:

Thanks; applied to Emacs 27.1.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2018-04-14 18:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-27 21:15 bug#30639: 25.1; ERC buffer name not unique, broken on reconnect [patch] John Goerzen
2018-04-14 18:11 ` Lars Ingebrigtsen [this message]
2020-06-24  9:12 ` Kevin Brubeck Unhammer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1t94q0s.fsf@mouse.gnus.org \
    --to=larsi@gnus.org \
    --cc=30639@debbugs.gnu.org \
    --cc=jgoerzen@complete.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).