From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dima Kogan Newsgroups: gmane.emacs.bugs Subject: bug#25271: 26.0.50; [PATCH] comint-insert-previous-argument logic improvements Date: Sun, 17 Jun 2018 19:25:03 -0700 Message-ID: <87k1qwltkw.fsf@secretsauce.net> References: <87eg0veqe2.fsf@secretsauce.net> <87in86on2u.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1529288653 500 195.159.176.226 (18 Jun 2018 02:24:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 18 Jun 2018 02:24:13 +0000 (UTC) User-Agent: mu4e 0.9.19; emacs 25.2.2 Cc: 25271@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 18 04:24:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUjpt-0008PR-94 for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jun 2018 04:24:06 +0200 Original-Received: from localhost ([::1]:57052 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUjs0-0002dY-8F for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Jun 2018 22:26:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40257) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUjrr-0002dI-7l for bug-gnu-emacs@gnu.org; Sun, 17 Jun 2018 22:26:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fUjrm-0006PH-7K for bug-gnu-emacs@gnu.org; Sun, 17 Jun 2018 22:26:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46320) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fUjrm-0006Oz-0B for bug-gnu-emacs@gnu.org; Sun, 17 Jun 2018 22:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fUjrl-0005Rp-Px for bug-gnu-emacs@gnu.org; Sun, 17 Jun 2018 22:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dima Kogan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Jun 2018 02:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25271 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25271-submit@debbugs.gnu.org id=B25271.152928870820871 (code B ref 25271); Mon, 18 Jun 2018 02:26:01 +0000 Original-Received: (at 25271) by debbugs.gnu.org; 18 Jun 2018 02:25:08 +0000 Original-Received: from localhost ([127.0.0.1]:54217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUjqu-0005QZ-8y for submit@debbugs.gnu.org; Sun, 17 Jun 2018 22:25:08 -0400 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:53161) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUjqr-0005QR-W9 for 25271@debbugs.gnu.org; Sun, 17 Jun 2018 22:25:06 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 66BCE21ADF; Sun, 17 Jun 2018 22:25:05 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 17 Jun 2018 22:25:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secretsauce.net; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=pK1+M1Xklb6RCpGbZyOUrwRW73Ph1GNlqYd8kHhzVHE=; b=ZBKVDlE4 rNE4ghVSw6Gf70jq+dTARqpET4fJPgNygceNEmQdx35zD3co/fnHjEnxnuy0K+u4 zG6EnFq7EqQ8XbPICnldgdBrHBcDmB6u+7hw//k+T5whqhM2056QsuSHWke5R5do 0zl63JGxHoDeRvGuNMq2Nzdz+4DR9z02auj6QwaG0fLa9MooDwhw+YOE8Uvh+r3h HEEbz3Lf8QJIKjtMc6d0/D1sja98/QJp9OX6R4eTQHcEjx0ZCpyyCC0sLwvqY2vq 04UjQjcZPzyb7Ioy1ePi4oRMuZ8/pJLcTln3IKrRTJxgLhzlloFRx2NTr+qB1n6i IwxNioZbCzxhrg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=pK1+M1Xklb6RCpGbZyOUrwRW73Ph1 GNlqYd8kHhzVHE=; b=ASUs0LtQhZkGiqyrokyT2aLsbbfbDRwlr5mL8j0UPqWeS I4H6bDgSwLd2+JD+JvGMa8nq2PoU5STpCy4mV/87I7nTffjN5o5BpeUKZzyjypvX 7FQFflgs6K/BOkiFVFfxi8IQKjMxXUskI6lOjjACr3fNYJxR07tN24BvCJUtifUY 7xFy9P2DiAjjHKwBDye8nnMM3HXe+syiFH50tRDdY3UW4k/SPU4g7VBXuxh2ma9d YrLser1WuwDm124SYqqWo7lT+FVg4BJiic7BLl+eWraEFdkvylIXd5Cl+initgiR /8T/mU6DrNkaSMGN+rPbXioVkIai6mXlVaKoWyfnw== X-ME-Proxy: X-ME-Sender: Original-Received: from scrawny (107-210-213-243.lightspeed.irvnca.sbcglobal.net [107.210.213.243]) by mail.messagingengine.com (Postfix) with ESMTPA id C635FE4154; Sun, 17 Jun 2018 22:25:04 -0400 (EDT) Original-Received: from dima by scrawny with local (Exim 4.90_1) (envelope-from ) id 1fUjqp-0007ob-E0; Sun, 17 Jun 2018 19:25:03 -0700 In-reply-to: <87in86on2u.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147589 Archived-At: Noam Postavsky writes: > Dima Kogan writes: > >> +(defvar-local comint-insert-previous-argument-from-end nil > >> +This variable is buffer-local. To get the zsh behavior in `M-x >> +shell' sessions, do something like this: >> + >> + (add-hook >> + 'shell-mode-hook >> + (lambda () >> + (setq comint-insert-previous-argument-from-end t)))") >> + > > Seems simpler to just make it a defcustom. The user could still > setq-local if they really want per-buffer settings. Yes. I agree, actually. Want a new patch, and we can merge this?