From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 32839@debbugs.gnu.org
Subject: bug#32839: 27.0.50; recenter doesn't redisplay
Date: Sun, 30 Sep 2018 02:38:03 +0300 [thread overview]
Message-ID: <87k1n3c0vo.fsf@mail.linkov.net> (raw)
In-Reply-To: <8736txjvkg.fsf@mail.linkov.net>
>> The docstring of window-scroll-functions says:
>>
>> These functions are called whenever the ‘window-start’ marker is modified,
>> either to point into another buffer (e.g. via ‘set-window-buffer’) or another
>> place in the same buffer.
>
> You've omitted the first line of the doc string:
>
> List of functions to call before redisplaying a window with scrolling.
> ^^^^^^^^^^^^^^
But (info "(emacs) Recentering") says that recentering is scrolling:
Typing ‘C-l’ twice in a row (‘C-l C-l’) scrolls the window so that
^^^^^^^
point is on the topmost screen line. Typing a third ‘C-l’ scrolls the
^^^^^^^
window so that point is on the bottom-most screen line. Each successive
‘C-l’ cycles through these three positions.
So 'C-l C-l C-l' is eligible for the calls of window-scroll-functions.
>> Maybe it will be called in the new hook window-state-change-functions
>> proposed by Martin.
>
> I hope not.
I grepped for window-scroll-functions, and see that the current situation
is quite bad:
1. tabulated-list-window-scroll-function is not called on 'C-u -1 C-l'
when the last window line is fully visible, so it doesn't adjust
the width for display-line-numbers in this case.
2. linum-mode relies more on post-command-hook because
window-scroll-functions is not reliable.
3. erc-scroll-to-bottom was forced to replace window-scroll-functions
with post-command-hook because window-scroll-functions doesn't
support altering the way the window is scrolled.
The only hope to fix these problems and to close this report is to call
the new hook window-state-change-functions at the very end when the
redisplay is completely finished, probably at the same time when
post-command-hook is called.
next prev parent reply other threads:[~2018-09-29 23:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 19:11 bug#32839: 27.0.50; recenter doesn't redisplay Juri Linkov
2018-09-25 20:08 ` Eli Zaretskii
2018-09-25 20:55 ` Juri Linkov
2018-09-26 5:39 ` Eli Zaretskii
2018-09-26 23:55 ` Juri Linkov
2018-09-27 6:44 ` Eli Zaretskii
2018-09-27 22:59 ` Juri Linkov
2018-09-28 6:22 ` Eli Zaretskii
2018-09-29 23:32 ` Juri Linkov
2018-09-30 6:08 ` Eli Zaretskii
2018-09-30 19:40 ` Juri Linkov
2018-10-01 5:34 ` Eli Zaretskii
2018-09-29 23:38 ` Juri Linkov [this message]
2018-09-30 6:22 ` Eli Zaretskii
2018-09-30 19:46 ` Juri Linkov
2018-10-01 6:58 ` Eli Zaretskii
2018-10-08 22:56 ` Juri Linkov
2018-10-09 7:44 ` martin rudalics
2020-02-07 0:30 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1n3c0vo.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=32839@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).