unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Nicolas Petton <nicolas@petton.fr>
Cc: Michael Heerdegen <michael_heerdegen@web.de>,
	"Miguel V. S. Frasson" <mvsfrasson@gmail.com>,
	34852@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#34852: 26.1; seq-intersection ignores nil as element
Date: Thu, 14 Mar 2019 17:08:55 +0000	[thread overview]
Message-ID: <87k1h1criw.fsf@tcd.ie> (raw)
In-Reply-To: <87d0mtpfqb.fsf@petton.fr> (Nicolas Petton's message of "Thu, 14 Mar 2019 17:45:16 +0100")

Nicolas Petton <nicolas@petton.fr> writes:

> Michael Heerdegen <michael_heerdegen@web.de> writes:
>
> Hi Michael,
>
>> We also have `seq-some' which can be used as a contain predicate,
>> e.g. to fix this bug:
>
> Using seq-contains was wrong, and I think seq-some should have been used
> instead, so I like your patch better (it's IMO better to use seq-some
> used as a predicate than seq-position).
>
> Unless somebody disagrees, I'll install your patch.

If you go with the seq-some patch then please edit it to avoid using
apply-partially, which is quite inefficient.

The implementations of seq-set-equal-p, seq-uniq, and seq-difference
will also need to be updated, in addition to that of seq-intersection.

-- 
Basil





  reply	other threads:[~2019-03-14 17:08 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-14  2:16 bug#34852: 26.1; seq-intersection ignores nil as element Miguel V. S. Frasson
2019-03-14 12:07 ` Michael Heerdegen
2019-03-14 13:09   ` Nicolas Petton
2019-03-14 12:22 ` Basil L. Contovounesios
2019-03-14 12:52   ` Miguel V. S. Frasson
2019-03-14 16:16     ` Basil L. Contovounesios
2019-03-14 13:09   ` Michael Heerdegen
2019-03-14 13:34     ` Stefan Monnier
2019-03-14 16:19       ` Basil L. Contovounesios
2019-03-14 16:45         ` Michael Heerdegen
2019-03-14 17:14           ` Basil L. Contovounesios
2019-03-14 19:08       ` Miguel V. S. Frasson
2019-03-14 21:43         ` Stefan Monnier
2019-03-14 23:08           ` Miguel V. S. Frasson
2019-03-14 23:14             ` Stefan Monnier
2019-03-14 23:21               ` Miguel V. S. Frasson
2019-03-14 23:42               ` Michael Heerdegen
2019-03-15  2:40                 ` Stefan Monnier
2019-03-15 12:26                   ` Michael Heerdegen
2019-03-15 14:47                     ` Stefan Monnier
2019-03-14 23:45             ` Miguel V. S. Frasson
2019-03-14 23:15         ` Michael Heerdegen
2019-03-15 15:56           ` Basil L. Contovounesios
2019-03-15 16:08             ` Miguel V. S. Frasson
2019-03-16 20:33               ` Miguel V. S. Frasson
2019-03-16 20:49                 ` Basil L. Contovounesios
2019-03-16 21:32                   ` Miguel V. S. Frasson
2019-03-15 15:55         ` Basil L. Contovounesios
2019-03-14 16:17     ` Basil L. Contovounesios
2019-03-14 16:35       ` Michael Heerdegen
2019-03-14 17:02         ` Basil L. Contovounesios
2019-03-14 17:23           ` Basil L. Contovounesios
2019-03-14 16:45     ` Nicolas Petton
2019-03-14 17:08       ` Basil L. Contovounesios [this message]
2019-03-18 11:55         ` Nicolas Petton
2019-03-18 19:06           ` Michael Heerdegen
2019-03-18 20:14             ` Nicolas Petton
2019-03-20 20:51           ` Nicolas Petton
2019-03-20 22:33             ` Michael Heerdegen
2019-03-21  8:02               ` Nicolas Petton
2019-03-21 17:46             ` Basil L. Contovounesios
2019-03-21 20:01               ` Nicolas Petton
2019-03-21 20:16               ` Nicolas Petton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1h1criw.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=34852@debbugs.gnu.org \
    --cc=michael_heerdegen@web.de \
    --cc=monnier@iro.umontreal.ca \
    --cc=mvsfrasson@gmail.com \
    --cc=nicolas@petton.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).