From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#35058: [PATCH] Use display-graphic-p in more cases Date: Sun, 31 Mar 2019 13:45:50 +0100 Message-ID: <87k1gf9pq9.fsf@tcd.ie> References: <8736n4ndav.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="138182"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35058@debbugs.gnu.org To: Alex Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 31 14:47:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hAZrj-000Zmz-Gg for geb-bug-gnu-emacs@m.gmane.org; Sun, 31 Mar 2019 14:47:11 +0200 Original-Received: from localhost ([127.0.0.1]:55377 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAZri-0000Gk-Ew for geb-bug-gnu-emacs@m.gmane.org; Sun, 31 Mar 2019 08:47:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60371) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAZrb-0000Du-95 for bug-gnu-emacs@gnu.org; Sun, 31 Mar 2019 08:47:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hAZra-0002WO-F1 for bug-gnu-emacs@gnu.org; Sun, 31 Mar 2019 08:47:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52528) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hAZra-0002WC-2R for bug-gnu-emacs@gnu.org; Sun, 31 Mar 2019 08:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hAZrZ-0005Cr-UH for bug-gnu-emacs@gnu.org; Sun, 31 Mar 2019 08:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 31 Mar 2019 12:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35058 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35058-submit@debbugs.gnu.org id=B35058.155403636419946 (code B ref 35058); Sun, 31 Mar 2019 12:47:01 +0000 Original-Received: (at 35058) by debbugs.gnu.org; 31 Mar 2019 12:46:04 +0000 Original-Received: from localhost ([127.0.0.1]:37839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hAZqe-0005Be-2F for submit@debbugs.gnu.org; Sun, 31 Mar 2019 08:46:04 -0400 Original-Received: from mail-ed1-f66.google.com ([209.85.208.66]:35713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hAZqZ-0005An-Ab for 35058@debbugs.gnu.org; Sun, 31 Mar 2019 08:46:02 -0400 Original-Received: by mail-ed1-f66.google.com with SMTP id s39so5792633edb.2 for <35058@debbugs.gnu.org>; Sun, 31 Mar 2019 05:45:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=N81TmQ67MxCSUMEQOTk0mgAuPnA5nor5eEwbSkmCu+Y=; b=c+D/jausst30kADJBwn+jhMpDeV4vn8HIB1YgwJbS4edKwHf3Qm+iN/Hku0bkPtjWs 30OnrQtnmbxQ0NznhvLkefWzB9E/gCYAzzqnH29Rj7ffCSYROEpR8iKN19F2TD7cfI7G PGy+mzT9syYfpV6lBkF74KDHuXhpweoGdoHu5xjaruS2P0LVp/MjuFPBpjBP8TtTp76Q O8xz2jMoK8/es4hvTrm4UWkyGz/POZmM5r/Lh4iPWV8k2Lo2lDrpk9E3AmFqHTRazlyU xXTpKpicaS8XWUiWtFoiBd4izgRu+ciFDmZXQsbkhxDX/8MBDQeXIXm0aPN8fvC9e4Es 7oaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=N81TmQ67MxCSUMEQOTk0mgAuPnA5nor5eEwbSkmCu+Y=; b=CfRMTnV+mF//dBc5qTue7n7vApkambHWA13XUwJOJ+/Mtg3wfXTKgeFGgcxxbpplBm sg2TAwQY4kYlVsuNra+ZSDGWYnQpHeesEztNjbR01iGLr4A52lixv9XqB3t81BwyLmAN qRidn+m6HIb2nB4LSl4hrpxCpvIWQxB88eAAiFMLj2QB/SozI+PFxB+zdQLdYa/uzSqX gSB8xpVqXgcJfPfzmS10Vc/JE1Wxhc4JU8TkIDKBN67SxrnBn/6puluU9Svmu6qXhvnz 04bsxSjd31cOFe3XDhhpwejxkJWX9wzE/LI0mlTxwdLgDkFYLftIS1yQEMAXZ9InLxhZ gN9A== X-Gm-Message-State: APjAAAVEf9qWVK38oTG3OmnvnGpIy1yXAuaKf/cWAsibIGPEyGeW2jDD r9YpohDWxStCWn20V/eqdQ295A== X-Google-Smtp-Source: APXvYqx9araCctDoL26S6ljDPGaJuseZC2slowafOq/vx9ECwUjyTdMKdYwpdCQthusSi3YmSUmOUg== X-Received: by 2002:a50:e610:: with SMTP id y16mr4742837edm.67.1554036353663; Sun, 31 Mar 2019 05:45:53 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:f786:805d:f4ab:1006]) by smtp.gmail.com with ESMTPSA id br19sm1344576ejb.48.2019.03.31.05.45.52 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 31 Mar 2019 05:45:52 -0700 (PDT) In-Reply-To: <8736n4ndav.fsf@gmail.com> (Alex's message of "Sat, 30 Mar 2019 17:38:16 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156970 Archived-At: Just a minor comment from me. Alex writes: > diff --git a/lisp/frame.el b/lisp/frame.el > index 6cb1247372..f5ad3152a0 100644 > --- a/lisp/frame.el > +++ b/lisp/frame.el > @@ -2078,12 +2069,12 @@ display-planes > If DISPLAY is omitted or nil, it defaults to the selected frame's display." > (let ((frame-type (framep-on-display display))) > (cond > - ((memq frame-type '(x w32 ns)) > - (x-display-planes display)) > ((eq frame-type 'pc) > 4) > + ((memq frame-type '(nil t)) > + (truncate (log (length (tty-color-alist)) 2))) > (t > - (truncate (log (length (tty-color-alist)) 2)))))) > + (x-display-planes display))))) > > (declare-function x-display-color-cells "xfns.c" (&optional terminal)) I suggest also changing (truncate (log (length (tty-color-alist)) 2)) to (logb (length (tty-color-alist))). Thanks, -- Basil