bug#35121: [debbugs.el] debbugs-make-control-message doesn't always ask for version

bug#35121: [debbugs.el] debbugs-make-control-message doesn't always ask for version

[Noam Postavsky]

[-- Attachment #1: Type: text/plain, Size: 629 bytes --]

Severity: minor
Tags: patch

When using debbugs-make-control-message to make a "done" or "fixed"
control message from a message-mode buffer, it doesn't ask for for a
version number.  That's because (debbugs-gnu-current-status) returns nil
outside the *Bugs* buffer, so the (member "emacs" (cdr (assq 'package
status))) check always fails.

I think it should be okay to fallback to cache, or debbugs-get-status if
the cache is empty, right?

By the way, I wonder if we should ask for version even if the package is
not Emacs (obviously the initial-input suggestion only works for Emacs),
surely other packages have versions too?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 1332 bytes --]

From fbaec0d15b816892c5f774ea9cfdfa6536956d8e Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@users.sourceforge.net>
Date: Wed, 3 Apr 2019 09:03:13 -0400
Subject: [PATCH v1] Try harder to debbugs status if d-g-current-status missing

* packages/debbugs/debbugs-gnu.el (debbugs-gnu-make-control-message):
Fallback to debbugs-cache-data or debbugs-get-status if
debbugs-gnu-current-status returns nil, otherwise we fail to ask for
version number when fixing/finding/closing/etc Emacs bugs from a
message-mode buffer.
---
 packages/debbugs/debbugs-gnu.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/packages/debbugs/debbugs-gnu.el b/packages/debbugs/debbugs-gnu.el
index 33860c2d5..8f914d5c1 100644
--- a/packages/debbugs/debbugs-gnu.el
+++ b/packages/debbugs/debbugs-gnu.el
@@ -1586,7 +1586,9 @@ (defun debbugs-gnu-make-control-message (message bugid &optional reverse buffer)
            current-prefix-arg
            (when (derived-mode-p 'message-mode)
              (current-buffer)))))
-  (let* ((status (debbugs-gnu-current-status))
+  (let* ((status (or (debbugs-gnu-current-status)
+                     (gethash bugid debbugs-cache-data)
+                     (debbugs-get-status bugid)))
          (version
           (if (and
                (member message '("close" "done"
-- 
2.11.0

bug#35121: [debbugs.el] debbugs-make-control-message doesn't always ask for version

[Michael Albinus]

Noam Postavsky <npostavs@gmail.com> writes:

Hi Noam,

> When using debbugs-make-control-message to make a "done" or "fixed"
> control message from a message-mode buffer, it doesn't ask for for a
> version number.  That's because (debbugs-gnu-current-status) returns nil
> outside the *Bugs* buffer, so the (member "emacs" (cdr (assq 'package
> status))) check always fails.
>
> I think it should be okay to fallback to cache, or debbugs-get-status if
> the cache is empty, right?

Yes. Your patch LGTM.

> By the way, I wonder if we should ask for version even if the package is
> not Emacs (obviously the initial-input suggestion only works for Emacs),
> surely other packages have versions too?

I would suppose so. But in order to get feedback, you might ask on the
<help-debbugs@gnu.org> ML. People using debbugs.el for other projects
but Emacs are lurking there.

Best regards, Michael.

bug#35121: [debbugs.el] debbugs-make-control-message doesn't always ask for version

[Noam Postavsky]

tags 35121 fixed
close 35121 
quit

Michael Albinus <michael.albinus@gmx.de> writes:

>> I think it should be okay to fallback to cache, or debbugs-get-status if
>> the cache is empty, right?
>
> Yes. Your patch LGTM.

Pushed.

[1: 1a6a4a33a]: 2019-04-03 19:46:11 -0400
  Search further if d-g-cur-status is nil (Bug#35121)
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1a6a4a33a0933152d21e4da5ba052704bd292aec>


>> By the way, I wonder if we should ask for version even if the package is
>> not Emacs (obviously the initial-input suggestion only works for Emacs),
>> surely other packages have versions too?
>
> I would suppose so. But in order to get feedback, you might ask on the
> <help-debbugs@gnu.org> ML. People using debbugs.el for other projects
> but Emacs are lurking there.

Okay, I've sent a message, we'll see if anyone bites.