From: Noam Postavsky <npostavs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Robert Pluim <rpluim@gmail.com>,
l.charignon@gmail.com, 34341@debbugs.gnu.org
Subject: bug#34341: 26.1; url-retrieve-synchronously returns blank buffer
Date: Mon, 06 May 2019 20:16:52 -0400 [thread overview]
Message-ID: <87k1f3ktjf.fsf@gmail.com> (raw)
In-Reply-To: <83k1f3k3rm.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 06 May 2019 18:21:17 +0300")
[-- Attachment #1: Type: text/plain, Size: 1173 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Robert Pluim <rpluim@gmail.com>
>> Date: Mon, 06 May 2019 14:15:27 +0200
>> Cc: Laurent Charignon <l.charignon@gmail.com>, 34341@debbugs.gnu.org
>>
>> >>>>> On Mon, 06 May 2019 08:10:32 -0400, Noam Postavsky <npostavs@gmail.com> said:
>>
>> Noam> Thanks, I wasn't aware of this, I'll check if that helps
>> Noam> later today. I think it makes sense to backport regardless
>> Noam> though.
I can confirm that
(setq gnutls-algorithm-priority "NORMAL:-VERS-TLS1.3")
avoids the problem on my Arch box (has gnutls v3.6.7).
>> I do too, but last time Eli wasn't too enthusiastic about it.
>
> It's a complex change, and we don't even know whether emacs-26 will be
> used for another "regular" release. What if we need it for some
> emergency release, for example? Having to remember there was this
> cherry-pick, and branching from before it, reverting it, is not my
> idea of fun.
I found this smaller change fixes it also. Is it simple enough to for
emacs-26? Otherwise, we should set gnutls-algorithm-priority because
(as far as I understand) we have a broken TLS1.3 implementation at the
momement.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 1176 bytes --]
From 6d5f5670443f7adfbd6993173ad997ce25827775 Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@gmail.com>
Date: Mon, 6 May 2019 19:55:17 -0400
Subject: [PATCH] Handle GNUTLS_E_AGAIN in emacs_gnutls_read (Bug#34341)
* src/gnutls.c (emacs_gnutls_read): Similar to emacs_gnutls_write,
when gnutls_record_recv returns GNUTLS_E_AGAIN set errno to EGAIN.
---
src/gnutls.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/gnutls.c b/src/gnutls.c
index 3c16b6c9c3..b724c3592d 100644
--- a/src/gnutls.c
+++ b/src/gnutls.c
@@ -753,8 +753,15 @@ emacs_gnutls_read (struct Lisp_Process *proc, char *buf, ptrdiff_t nbyte)
/* The peer closed the connection. */
return 0;
else if (emacs_gnutls_handle_error (state, rtnval))
- /* non-fatal error */
- return -1;
+ {
+ /* If we get GNUTLS_E_AGAIN, then set errno appropriately so that
+ wait_reading_process_output retries the correct way instead of
+ erroring out. */
+ if (rtnval == GNUTLS_E_AGAIN)
+ errno = EAGAIN;
+ /* non-fatal error */
+ return -1;
+ }
else {
/* a fatal error occurred */
return 0;
--
2.11.0
next prev parent reply other threads:[~2019-05-07 0:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 4:55 bug#34341: 26.1; url-retrieve-synchronously returns blank buffer Laurent Charignon
2019-02-06 8:12 ` bug#34341: Seems fixed in latest master 5259fdf96073febd18e83785960c443bdf02a310 Laurent Charignon
2019-02-09 18:08 ` bug#34341: more observations Mikhail Rudenko
2019-05-04 15:18 ` bug#34341: 26.1; url-retrieve-synchronously returns blank buffer Noam Postavsky
2019-05-06 11:52 ` Robert Pluim
2019-05-06 12:10 ` Noam Postavsky
2019-05-06 12:15 ` Robert Pluim
2019-05-06 15:21 ` Eli Zaretskii
2019-05-07 0:16 ` Noam Postavsky [this message]
2019-05-07 2:36 ` Eli Zaretskii
2019-05-07 6:35 ` Robert Pluim
2019-05-12 13:01 ` Robert Pluim
2019-05-12 14:02 ` Eli Zaretskii
2019-05-12 14:55 ` Robert Pluim
2019-05-12 15:23 ` Eli Zaretskii
2019-05-12 15:39 ` Robert Pluim
2019-05-12 16:01 ` Eli Zaretskii
2019-05-14 0:21 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1f3ktjf.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=34341@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=l.charignon@gmail.com \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).