unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#36766: 27.0.50; Remove gnus-start-news-server
@ 2019-07-22 18:42 Eric Abrahamsen
  2019-07-23 17:26 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 5+ messages in thread
From: Eric Abrahamsen @ 2019-07-22 18:42 UTC (permalink / raw)
  To: 36766


I think this function can be removed entirely. It is the only place
where the obsolete variables `gnus-nntp-server' and
`gnus-secondary-servers' are referenced, and its main job seems to be
bailing on Gnus startup if a nntp server isn't available. Now that Gnus
doesn't insist on being a newsreader, there's no reason why it should
ever bail on startup, no matter what happened. The only bit of the
function that looks like it should be kept is:

(gnus-agent-read-servers-validate-native gnus-select-method)

Which updates from earlier versions, but that bit could be moved elsewhere.





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#36766: 27.0.50; Remove gnus-start-news-server
  2019-07-22 18:42 bug#36766: 27.0.50; Remove gnus-start-news-server Eric Abrahamsen
@ 2019-07-23 17:26 ` Lars Ingebrigtsen
  2019-07-23 18:34   ` Eric Abrahamsen
  0 siblings, 1 reply; 5+ messages in thread
From: Lars Ingebrigtsen @ 2019-07-23 17:26 UTC (permalink / raw)
  To: Eric Abrahamsen; +Cc: 36766

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> I think this function can be removed entirely. It is the only place
> where the obsolete variables `gnus-nntp-server' and
> `gnus-secondary-servers' are referenced, and its main job seems to be
> bailing on Gnus startup if a nntp server isn't available.

Yes, so when gnus-nntp-server is removed, that function should be
removed (is the plan).  It's only been obsolete since 24.1, though, so
that sounds too soon.  Perhaps for Emacs 28?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#36766: 27.0.50; Remove gnus-start-news-server
  2019-07-23 17:26 ` Lars Ingebrigtsen
@ 2019-07-23 18:34   ` Eric Abrahamsen
  2019-07-25  9:34     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 5+ messages in thread
From: Eric Abrahamsen @ 2019-07-23 18:34 UTC (permalink / raw)
  To: 36766

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> I think this function can be removed entirely. It is the only place
>> where the obsolete variables `gnus-nntp-server' and
>> `gnus-secondary-servers' are referenced, and its main job seems to be
>> bailing on Gnus startup if a nntp server isn't available.
>
> Yes, so when gnus-nntp-server is removed, that function should be
> removed (is the plan).  It's only been obsolete since 24.1, though, so
> that sounds too soon.  Perhaps for Emacs 28?

Oh! I was getting ahead of things, sorry. 28 sounds fine to me. I guess
I'll leave this bug report open for when the time comes.






^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#36766: 27.0.50; Remove gnus-start-news-server
  2019-07-23 18:34   ` Eric Abrahamsen
@ 2019-07-25  9:34     ` Lars Ingebrigtsen
  2019-07-25 16:13       ` Eric Abrahamsen
  0 siblings, 1 reply; 5+ messages in thread
From: Lars Ingebrigtsen @ 2019-07-25  9:34 UTC (permalink / raw)
  To: Eric Abrahamsen; +Cc: 36766

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Oh! I was getting ahead of things, sorry. 28 sounds fine to me. I guess
> I'll leave this bug report open for when the time comes.

I don't think that's necessary...  perhaps just add a comment to the
line before gnus-nntp-server that this function should be removed at the
same time?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#36766: 27.0.50; Remove gnus-start-news-server
  2019-07-25  9:34     ` Lars Ingebrigtsen
@ 2019-07-25 16:13       ` Eric Abrahamsen
  0 siblings, 0 replies; 5+ messages in thread
From: Eric Abrahamsen @ 2019-07-25 16:13 UTC (permalink / raw)
  To: 36766; +Cc: 36766-done

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> Oh! I was getting ahead of things, sorry. 28 sounds fine to me. I guess
>> I'll leave this bug report open for when the time comes.
>
> I don't think that's necessary...  perhaps just add a comment to the
> line before gnus-nntp-server that this function should be removed at the
> same time?

Okay, will do.






^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-07-25 16:13 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-22 18:42 bug#36766: 27.0.50; Remove gnus-start-news-server Eric Abrahamsen
2019-07-23 17:26 ` Lars Ingebrigtsen
2019-07-23 18:34   ` Eric Abrahamsen
2019-07-25  9:34     ` Lars Ingebrigtsen
2019-07-25 16:13       ` Eric Abrahamsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).