From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 17005@debbugs.gnu.org
Subject: bug#17005: 24.3.50; semantic is not finding cl-defun's and friends
Date: Thu, 15 Aug 2019 08:30:50 +0200 [thread overview]
Message-ID: <87k1bfrld1.fsf@gmail.com> (raw)
In-Reply-To: <87pnl7qlvs.fsf@mouse.gnus.org>
Lars Ingebrigtsen <larsi@gnus.org> writes:
> I'm not really a Semantic user, so I can't test this, but I assume by
> "some trivial changes" you meant something like this, which I've now
> applied to Emacs 27. If that's the wrong thing to do, please revert.
AFAIK cl-defun* doesn't exists, thus you need a few more changes, I am
not a semantic user as well, so maybe some more changes are needed.
diff --git a/lisp/cedet/semantic/bovine/el.el b/lisp/cedet/semantic/bovine/el.el
index d46b73ff308..5015db3fad7 100644
--- a/lisp/cedet/semantic/bovine/el.el
+++ b/lisp/cedet/semantic/bovine/el.el
@@ -245,9 +245,12 @@ Return a bovination list to use."
(eq (car form) 'define-overloadable-function))
))
defun
+ cl-defun
defun*
defsubst
+ cl-defsubst
defmacro
+ cl-defmacro
define-overload ;; @todo - remove after cleaning up semantic.
define-overloadable-function
)
@@ -392,6 +395,7 @@ Return a bovination list to use."
(cons nil nil)
)))
defstruct
+ cl-defstruct
)
(semantic-elisp-setup-form-parser
@@ -610,7 +614,7 @@ Returns non-nil it is not possible to go up a context."
(let ((last-up (semantic-up-context-default)))
(while
(and (not (looking-at
- "(\\(let\\*?\\|def\\(un\\|method\\|generic\\|\
+ "(\\(let\\*?\\|cl-defun\\|def\\(un\\|method\\|generic\\|\
define-mode-overload\\)\
\\|with-slots\\)"))
(not last-up))
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
next prev parent reply other threads:[~2019-08-15 6:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 9:05 bug#17005: 24.3.50; semantic is not finding cl-defun's and friends Thierry Volpiatto
2019-08-15 1:04 ` Lars Ingebrigtsen
2019-08-15 6:30 ` Thierry Volpiatto [this message]
2019-08-15 12:45 ` Noam Postavsky
2019-08-15 15:43 ` Thierry Volpiatto
2019-08-16 1:12 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1bfrld1.fsf@gmail.com \
--to=thierry.volpiatto@gmail.com \
--cc=17005@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).