From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#34720: 26.1; Reverting a GPG buffer moves all markers to the end of the file Date: Mon, 26 Aug 2019 10:14:10 +0200 Message-ID: <87k1b04a3x.fsf@gnus.org> References: <87a7ic9due.fsf@gnu.org> <87muhnrwvs.fsf@mouse.gnus.org> <875zmk5r5u.fsf@gnus.org> <83sgpofjc9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="73334"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34720@debbugs.gnu.org, dunni@gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 26 10:15:44 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i2AA9-000Isc-3x for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Aug 2019 10:15:41 +0200 Original-Received: from localhost ([::1]:50784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2AA7-0006z5-HL for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Aug 2019 04:15:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45457) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i2A9b-0006Wu-Hj for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 04:15:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i2A9X-0004Uv-Pm for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 04:15:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36722) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i2A9W-0004S2-CY for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 04:15:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i2A9W-0003xZ-5e for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2019 04:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Aug 2019 08:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34720 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 34720-submit@debbugs.gnu.org id=B34720.156680725815153 (code B ref 34720); Mon, 26 Aug 2019 08:15:02 +0000 Original-Received: (at 34720) by debbugs.gnu.org; 26 Aug 2019 08:14:18 +0000 Original-Received: from localhost ([127.0.0.1]:45543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2A8n-0003wL-Sc for submit@debbugs.gnu.org; Mon, 26 Aug 2019 04:14:18 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:49836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2A8k-0003wB-EU for 34720@debbugs.gnu.org; Mon, 26 Aug 2019 04:14:16 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i2A8g-0005A5-Ij; Mon, 26 Aug 2019 10:14:13 +0200 In-Reply-To: <83sgpofjc9.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 26 Aug 2019 10:59:18 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165892 Archived-At: Eli Zaretskii writes: > Markers cannot be preserved in every situation, there's no way around > this basic fact. No, but commands like `revert-buffer' (via insert-file-contents) try to keep most of them around. > replace-buffer-contents is a primitive, so it can legitimately rely on > Lisp programs to set up whatever preconditions it needs for it to > work. It MUST have a buffer to work with; if you want to replace with > a string, insert that string into a buffer and call the primitive. > Why is that a problem? Why MUST it have a buffer to get the input data from? You get a text from somewhere, and it often ends up in a string (as in the epa case). If you want to safely feed that to this function, you have to say something along the lines of (let ((buffer (current-buffer))) (with-temp-buffer (insert string) (let ((temp (current-buffer))) (with-current-buffer buffer (replace-buffer-contents temp))))) which is horrible, horrible, and horrible. No wonder this function has gotten one single usage after it was introduced two years ago. (Well, one usage to replace-region-contents, which then calls the function.) (Unless I'm grepping wrong.) >> Would anybody mind if I just write a `with-saved-markers' macro in >> subr-x, which would make all these problems to away and make the >> solution a two-liner in epa itself? > > What would that macro do, exactly? Gather the markers, execute the body, and then put the markers back where they were. Which is what replace-buffer-contents does, but for a whole lot more stuff. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no