* bug#7974: lisp-do-defun on defuns with trailing comments
@ 2011-02-03 16:39 Ken Olum
2019-10-03 16:08 ` Lars Ingebrigtsen
0 siblings, 1 reply; 2+ messages in thread
From: Ken Olum @ 2011-02-03 16:39 UTC (permalink / raw)
To: 7974; +Cc: kdo
If you say lisp-compile-defun on a defun which has a comment on the
line with the final closing parenthesis, then your defun does not get
compiled, because emacs sends lisp a form with some close parens added
at the end of the comment, and naturally lisp does not read them.
One cure for this would be to remove the line
(skip-chars-backward " \t\n\r\f") ; Makes allegro happy
from lisp-do-defun. Then emacs would keep the new line
that terminates the comment at the end of the defun and put the
close parens after that.
Ken
^ permalink raw reply [flat|nested] 2+ messages in thread* bug#7974: lisp-do-defun on defuns with trailing comments
2011-02-03 16:39 bug#7974: lisp-do-defun on defuns with trailing comments Ken Olum
@ 2019-10-03 16:08 ` Lars Ingebrigtsen
0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2019-10-03 16:08 UTC (permalink / raw)
To: Ken Olum; +Cc: 7974
Ken Olum <kdo@cosmos.phy.tufts.edu> writes:
> If you say lisp-compile-defun on a defun which has a comment on the
> line with the final closing parenthesis, then your defun does not get
> compiled, because emacs sends lisp a form with some close parens added
> at the end of the comment, and naturally lisp does not read them.
>
> One cure for this would be to remove the line
>
> (skip-chars-backward " \t\n\r\f") ; Makes allegro happy
>
> from lisp-do-defun. Then emacs would keep the new line
> that terminates the comment at the end of the defun and put the
> close parens after that.
But I guess that fix is there for a reason (that Allegro doesn't like
trailing white space), so I've fixed this in Emacs 27 in a different
manner that keeps the trailing comments out of the region altogether.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-03 16:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-03 16:39 bug#7974: lisp-do-defun on defuns with trailing comments Ken Olum
2019-10-03 16:08 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).