From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#34614: 26.1.92; When reading input in mini-buffer, message to each area overide the input prompt Date: Sun, 10 Nov 2019 01:05:08 +0200 Organization: LINKOV.NET Message-ID: <87k188abx7.fsf@mail.linkov.net> References: <5C701035.5020803@gmx.at> <87zhh88xyv.fsf@mail.linkov.net> <87y2wrnxnn.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="227357"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: "34614@debbugs.gnu.org" <34614@debbugs.gnu.org>, Zhang Haijun To: HaiJun Zhang Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 10 00:08:30 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iTZqH-000ww2-CJ for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Nov 2019 00:08:29 +0100 Original-Received: from localhost ([::1]:40282 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iTZqG-0000rn-6w for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Nov 2019 18:08:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37310) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iTZps-0000Px-Ta for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2019 18:08:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iTZpr-0001fq-Px for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2019 18:08:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41630) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iTZpr-0001fm-LB for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2019 18:08:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iTZpr-00012P-F4 for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2019 18:08:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Nov 2019 23:08:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34614 X-GNU-PR-Package: emacs Original-Received: via spool by 34614-submit@debbugs.gnu.org id=B34614.15733408353915 (code B ref 34614); Sat, 09 Nov 2019 23:08:03 +0000 Original-Received: (at 34614) by debbugs.gnu.org; 9 Nov 2019 23:07:15 +0000 Original-Received: from localhost ([127.0.0.1]:50449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iTZp2-000111-U2 for submit@debbugs.gnu.org; Sat, 09 Nov 2019 18:07:15 -0500 Original-Received: from flamingo.ash.relay.mailchannels.net ([23.83.222.60]:35833) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iTZp0-00010o-Hv for 34614@debbugs.gnu.org; Sat, 09 Nov 2019 18:07:11 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 1A8CE8C0A24; Sat, 9 Nov 2019 23:07:07 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a16.g.dreamhost.com (100-96-85-194.trex.outbound.svc.cluster.local [100.96.85.194]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 7ACD98C1072; Sat, 9 Nov 2019 23:07:06 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a16.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Sat, 09 Nov 2019 23:07:07 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Relation-Glossy: 283dad0f00d7a615_1573340826930_341214212 X-MC-Loop-Signature: 1573340826930:2206198415 X-MC-Ingress-Time: 1573340826929 Original-Received: from pdx1-sub0-mail-a16.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a16.g.dreamhost.com (Postfix) with ESMTP id 1A070A304F; Sat, 9 Nov 2019 15:07:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=linkov.net; bh=sCXKf9 NJ1EPsg1NXmYdc8epdZmE=; b=f0F6Xy+pxkzfTR+DGAq1zvsIe1sAFk2zn7isvR Vt7GBRd/PrFmysqz7iy/DCx4xqGqaN+So1umZ7sMHxdfhStrhwMef8H6AC72ivLW qVxBq6N2J2OYL2LD8BfKfqq2dnwI4PVIYjx6K7g38ETwjBGdZ7E5/NXcjDULzAEz AFmRE= Original-Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a16.g.dreamhost.com (Postfix) with ESMTPSA id 45A9FA3053; Sat, 9 Nov 2019 15:06:58 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a16 In-Reply-To: (HaiJun Zhang's message of "Fri, 8 Nov 2019 01:46:45 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171365 Archived-At: > I got it. Thanks for your explaination. > > It is strange that minibuffer-message-timeout is defined in C. > But the timeout is processed in lisp (in the function minibuffer-messag= e). > > =E5=9C=A8 2019=E5=B9=B411=E6=9C=888=E6=97=A5 +0800 AM6:58=EF=BC=8CJuri = Linkov =EF=BC=8C=E5=86=99=E9=81=93=EF=BC=9A > > The prompt is replaced with the message from autorevert. And af= ter > about 2~3 seconds (not fixed), the prompt comes back. What cont= rols > the delay(2~3 seconds)? It is not the value of > minibuffer-message-timeout, which is 0.6. Is this expected? > > The problem is that when auto-revert-handler calls minibuffer-messa= ge, > the current buffer is not the minibuffer, because functions that ca= ll > auto-revert-handler (auto-revert-notify-handler, auto-revert--end-l= ockout, > or auto-revert-buffers) change the current buffer using with-curren= t-buffer. > =20 > When the current buffer is not the minibuffer then minibuffer-messa= ge > just calls (message "%s" message) and then does > (sit-for (or minibuffer-message-timeout 1000000)) > > And it behaves differently with the following test code: > =20 > (progn (run-with-idle-timer 3 nil > (lambda () > (minibuffer-message "Reverting buffer `%s'." (buffer-name)))) > (call-interactively 'find-file)) > =20 > This works well. The prompt is NOT replaced. The message is app= ended > to the end of the prompt and disappears after 0.6 second. > > To work well like this, minibuffer-message should be called outside > of with-current-buffer code block. Yesterday I fixed Man-bgproc-sen= tinel > in bug#19064 to call minibuffer-message outside of with-current-buf= fer. > =20 > But auto-revert functions require complete rewrite. I don't see > how this could be fixed with a simple change. Actually I found a solution with two alternatives, and both works well, and I can't decide which is less error-prone. This patch shows both: diff --git a/lisp/autorevert.el b/lisp/autorevert.el index 9275513c8d..17678010f1 100644 --- a/lisp/autorevert.el +++ b/lisp/autorevert.el @@ -815,7 +815,13 @@ auto-revert-handler (when revert (when (and auto-revert-verbose (not (eq revert 'fast))) - (message "Reverting buffer `%s'." (buffer-name))) + ;; 1. + (with-selected-window (old-selected-window) + (minibuffer-message "Reverting buffer `%s'." (buffer-name))) + ;; 2. + ;; (with-current-buffer (window-buffer (old-selected-window)) + ;; (minibuffer-message "Reverting buffer `%s'." (buffer-name))= ) + ) ;; If point (or a window point) is at the end of the buffer, we ;; want to keep it at the end after reverting. This allows one ;; to tail a file.