From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#38289: 27.0.50; C-c C-w not working if signature from gnus-posting-styles applies Date: Fri, 22 Nov 2019 00:04:16 +0100 Message-ID: <87k17svnkf.fsf@gnus.org> References: <87o8x73v3l.fsf@gnu.org> <87eey1z6r0.fsf@gnus.org> <87ftih6k46.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="63629"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 38289@debbugs.gnu.org To: Amin Bandali Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 22 00:06:51 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iXvXF-000GK4-Mu for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Nov 2019 00:06:49 +0100 Original-Received: from localhost ([::1]:46466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXvXE-0005f3-Jf for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Nov 2019 18:06:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60839) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXvVk-00047p-A6 for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 18:05:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXvVi-0003qo-5H for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 18:05:16 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44691) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iXvVc-0003k0-P5 for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 18:05:10 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iXvVa-0005pM-CD; Thu, 21 Nov 2019 18:05:08 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Thu, 21 Nov 2019 23:05:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38289 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 38289-submit@debbugs.gnu.org id=B38289.157437749122345 (code B ref 38289); Thu, 21 Nov 2019 23:05:06 +0000 Original-Received: (at 38289) by debbugs.gnu.org; 21 Nov 2019 23:04:51 +0000 Original-Received: from localhost ([127.0.0.1]:53506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXvVI-0005oD-GH for submit@debbugs.gnu.org; Thu, 21 Nov 2019 18:04:48 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:38420) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXvUz-0005mX-1v for 38289@debbugs.gnu.org; Thu, 21 Nov 2019 18:04:30 -0500 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iXvUn-0005C8-C9; Fri, 22 Nov 2019 00:04:20 +0100 In-Reply-To: <87ftih6k46.fsf@gnu.org> (Amin Bandali's message of "Thu, 21 Nov 2019 15:38:01 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172180 Archived-At: Amin Bandali writes: > For instance, if `message-mode' was opened by > hitting `r' on an article in nnimap+gnu:INBOX > which has a custom signature set using > `gnus-posting-styles', if I manually remove the > prefilled signature and hit `C-c C-w', nothing > happens, as if `message-signature' was set to > nil; whereas it is actually t. Makes sense? Yes indeed -- I misread your bug report. And, yes, that's how this works. When doing the posting styles, Gnus sets the message variables buffer-locally: ((eq 'signature (car result)) (set (make-local-variable 'message-signature) nil) (set (make-local-variable 'message-signature-file) nil) I'm now quite sure what's the best way to fix this -- perhaps `C-c C-w' should consult the global values? But that may be equally wrong, because somebody may be setting that variable buffer-locally in a hook, for instance, and `C-c C-w' should do the obvious thing and work on that value. The nil case makes it seem obvious that Message should be doing something other than what it's doing now, but if you've set the signature via Gnus posting styles, and then deleted it, and then want to insert it again with `C-c C-w' -- shouldn't that work? I think it should. So that leaves the nil case -- `C-c C-w' could peek at the global version of the variable if it's buffer-locally nil? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no