From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#38317: Buffer-local variables don't work as history for read-from-minibuffer Date: Wed, 27 Nov 2019 12:53:23 +0100 Message-ID: <87k17lfscs.fsf@gnus.org> References: <87eey0lxxm.fsf@gmail.com> <87v9rcqbls.fsf@gnus.org> <5a0c68d0-4d25-bf8d-fbe8-f106b0f92210@gmx.at> <875zjareo1.fsf@gnus.org> <874kyu72kl.fsf@gmail.com> <87wobq5gs0.fsf@gmail.com> <87o8wyl2wa.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="64288"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 38317@debbugs.gnu.org To: Federico Tedin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 27 13:00:33 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iZvzk-000GVF-MJ for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Nov 2019 13:00:32 +0100 Original-Received: from localhost ([::1]:37452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZvzj-0008LG-EY for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Nov 2019 07:00:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50555) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZvtT-0000pn-Cy for bug-gnu-emacs@gnu.org; Wed, 27 Nov 2019 06:54:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZvtS-0006X9-7z for bug-gnu-emacs@gnu.org; Wed, 27 Nov 2019 06:54:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47548) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZvtS-0006Wv-44 for bug-gnu-emacs@gnu.org; Wed, 27 Nov 2019 06:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iZvtS-00070D-1W for bug-gnu-emacs@gnu.org; Wed, 27 Nov 2019 06:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Nov 2019 11:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38317 X-GNU-PR-Package: emacs Original-Received: via spool by 38317-submit@debbugs.gnu.org id=B38317.157485561426878 (code B ref 38317); Wed, 27 Nov 2019 11:54:01 +0000 Original-Received: (at 38317) by debbugs.gnu.org; 27 Nov 2019 11:53:34 +0000 Original-Received: from localhost ([127.0.0.1]:53521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZvt0-0006zS-Jn for submit@debbugs.gnu.org; Wed, 27 Nov 2019 06:53:34 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:55004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZvsz-0006zC-Bj for 38317@debbugs.gnu.org; Wed, 27 Nov 2019 06:53:33 -0500 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iZvsq-0001De-Kj; Wed, 27 Nov 2019 12:53:27 +0100 In-Reply-To: <87o8wyl2wa.fsf@gmail.com> (Federico Tedin's message of "Tue, 26 Nov 2019 22:54:29 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172522 Archived-At: Federico Tedin writes: > I've tested the following commands with it, using `read-from-minibuffer' > with a buffer-local HIST: > > - previous-history-element (M-p) > - next-history-element (M-n) > - previous-matching-history-element (M-r) > - next-matching-history-element (M-s) > - isearch-forward (C-s) > - isearch-backward (C-r) > > They've all worked correctly and used only the buffer's local history > value. I haven't tested the code, but it makes sense to me. I do wonder whether there are any instances of the variables that are local to the minibuffer... but I guess that's unlikely? > +** 'read-from-minibuffer' now works with buffer-local history variables > +The HIST argument of 'read-from-minibuffer' now works correctly with > +buffer-local variables. This means that different buffers can have > +their own separated input history list if desired. This should probably be documented in the manual, too? The patch otherwise looks good to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no