From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#33005: 27.0.50; Data loss with Gnus registry Date: Mon, 09 Dec 2019 14:29:38 -0800 Message-ID: <87k1753zfx.fsf@ericabrahamsen.net> References: <871s8yvsrq.fsf@web.de> <87imn6v01s.fsf@web.de> <87eexuuznq.fsf@web.de> <87sgm8tmq6.fsf@ericabrahamsen.net> <87wobk0xza.fsf@web.de> <87imn3tv1s.fsf@ericabrahamsen.net> <87imn2luz8.fsf@web.de> <87lfrtwyu5.fsf@ericabrahamsen.net> <87immwm5po.fsf@web.de> <87r21kuhmm.fsf@ericabrahamsen.net> <877e3bn7rw.fsf@web.de> <9B6350E4-ED1B-4E95-974E-7531C9987655@ericabrahamsen.net> <8736dzn6sn.fsf@web.de> <87blsnu6yu.fsf@ericabrahamsen.net> <87y2vrlpya.fsf@web.de> <87v9qvsigm.fsf@ericabrahamsen.net> <877e3624zd.fsf@web.de> <87zhg25ymg.fsf@ericabrahamsen.net> <87h82970i9.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="148001"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 33005@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 09 23:30:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ieRXf-000cMx-0M for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Dec 2019 23:30:11 +0100 Original-Received: from localhost ([::1]:47940 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ieRXd-0005O0-PQ for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Dec 2019 17:30:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33004) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ieRXX-0005Nn-IM for bug-gnu-emacs@gnu.org; Mon, 09 Dec 2019 17:30:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ieRXW-0000nC-G3 for bug-gnu-emacs@gnu.org; Mon, 09 Dec 2019 17:30:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48591) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ieRXW-0000mm-CV for bug-gnu-emacs@gnu.org; Mon, 09 Dec 2019 17:30:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ieRXW-0006Y4-8Y for bug-gnu-emacs@gnu.org; Mon, 09 Dec 2019 17:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Dec 2019 22:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33005 X-GNU-PR-Package: emacs Original-Received: via spool by 33005-submit@debbugs.gnu.org id=B33005.157593058925108 (code B ref 33005); Mon, 09 Dec 2019 22:30:02 +0000 Original-Received: (at 33005) by debbugs.gnu.org; 9 Dec 2019 22:29:49 +0000 Original-Received: from localhost ([127.0.0.1]:54564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ieRXJ-0006Wt-12 for submit@debbugs.gnu.org; Mon, 09 Dec 2019 17:29:49 -0500 Original-Received: from ericabrahamsen.net ([52.70.2.18]:59126 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ieRXG-0006WY-Rl for 33005@debbugs.gnu.org; Mon, 09 Dec 2019 17:29:47 -0500 Original-Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 90F80FA0E3; Mon, 9 Dec 2019 22:29:40 +0000 (UTC) In-Reply-To: <87h82970i9.fsf@web.de> (Michael Heerdegen's message of "Mon, 09 Dec 2019 20:38:22 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173122 Archived-At: On 12/09/19 20:38 PM, Michael Heerdegen wrote: > Eric Abrahamsen writes: > >> Thanks for your continued patience with these problems. Don't >> give up on the registry! > > Ok, I won't. > > I wanted now to add a hack to my config to save a backup of the registry > save file every time it is saved. > > But now I wonder if that would not be a good idea anyway? I think it > could be done like in `gnus-save-newsrc-file' (look for > `backup-buffer'). Does that make sense? > > I think I would then advice `gnus-registry-save' so that lots of backups > are kept, in a separate folder, to prevent future data loss. There are plenty of places where you could do a backup. The registry itself is saved on the `gnus-save-newsrc-hook', that's a fine spot. I was going to say you could add a method to `eieio-persistent-save', maybe an :after method, and do it there, but now I wonder if you might get into some sort of recursive loop, since you'd want to use `eieio-persistent-save' in there, as well. I was thinking you should do it at the lowest level possible, but this might actually be too low. Part of the reason for "going low" is that there are routines for making sure that non-ascii group names are mangled properly before saving. Ooh, I just realized -- Lars wasn't into me properly encoding Gnus group names in the .newsrc.eld file, but there's no reason the registry has to be under that restriction, as the data is meant to be transient at some level. I could leave the decoding routines in place and get rid of the encoders. Anyway! That's a different question.