unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Wolfgang Scherer <Wolfgang.Scherer@gmx.de>
Cc: 37215@debbugs.gnu.org
Subject: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings
Date: Wed, 22 Jan 2020 13:43:15 +0100	[thread overview]
Message-ID: <87k15jy84c.fsf@gnus.org> (raw)
In-Reply-To: <ca5e7ef7-fb79-c18d-c490-d0a600d198a6@gmx.de> (Wolfgang Scherer's message of "Sun, 5 Jan 2020 04:59:57 +0100")

Wolfgang Scherer <Wolfgang.Scherer@gmx.de> writes:

> Am 15.09.19 um 15:12 schrieb Lars Ingebrigtsen:
>> Wolfgang Scherer <Wolfgang.Scherer@gmx.de> writes:
>>
>>> +        ;; FIXME this is a pcvs variable.
>>> +        (if (bound-and-true-p cvs-sort-ignore-file)
>>> +            (sort-lines nil (point-min) (point-max)))
>> Does it make sense to heed a pcvs variable here?  I think it would be
>> surprising that vc-cvs behaves differently depending on whether you've
>> loaded pcvs or not.
>
> Just to clarifiy: my patch does not introduce this FIXME. Only the
> indentation is changed. This question should be handled in a separate
> bug report.

Right; sorry.  Looking at the patch again, I don't quite get the logic here:

> -(defun vc-cvs-ignore (file &optional _directory _remove)
> -  "Ignore FILE under CVS."
> -  (vc-cvs-append-to-ignore (file-name-directory file) file))
> +(defun vc-cvs-ignore (file &optional directory _remove)
> +  "Ignore FILE under CVS.
> +FILE is either absolute or relative to DIRECTORY."
> +  (setq file (directory-file-name (expand-file-name file directory)))
> +  (vc-cvs-append-to-ignore (file-name-directory file) (file-name-nondirectory file)))

This is basically

(file-name-nondirectory (directory-file-name (expand-file-name "foo" directory)))

isn't it?  In what circumstances does that evaluate to something other
than "foo"?  That is, what DIRECTORY is doesn't seem to matter, if I'm
reading this right?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2020-01-22 12:43 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-28 22:32 bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings Wolfgang Scherer
2019-09-15 13:12 ` Lars Ingebrigtsen
2020-01-05  3:59   ` Wolfgang Scherer
2020-01-22 12:43     ` Lars Ingebrigtsen [this message]
2020-01-30 19:44       ` Wolfgang Scherer
2020-02-13 19:36         ` Eli Zaretskii
2020-02-14  1:24           ` Wolfgang Scherer
2020-02-14  8:33             ` Eli Zaretskii
2020-02-15  1:42               ` Wolfgang Scherer
2020-02-15  7:44                 ` Eli Zaretskii
2020-02-15 12:55                   ` Dmitry Gutov
2020-02-19 23:02                     ` Wolfgang Scherer
2020-02-16  0:20                   ` Wolfgang Scherer
2020-02-19 23:06                   ` Wolfgang Scherer
2020-02-21  9:31                     ` Eli Zaretskii
2020-02-21 10:16                       ` Dmitry Gutov
2020-02-21 20:44                         ` Wolfgang Scherer
2020-02-21 21:30                           ` Dmitry Gutov
2020-02-21 22:23                             ` Wolfgang Scherer
2020-02-21 20:32                       ` Wolfgang Scherer
2020-02-22  8:59                         ` Eli Zaretskii
2020-02-14  2:50           ` Wolfgang Scherer
2020-02-14  8:39             ` Eli Zaretskii
2020-02-14  9:24               ` Eli Zaretskii
2020-02-28 16:07 ` Mattias Engdegård
2020-02-28 16:24   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k15jy84c.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=37215@debbugs.gnu.org \
    --cc=Wolfgang.Scherer@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).