From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Wojciech Siewierski Newsgroups: gmane.emacs.bugs Subject: bug#41261: 27.0.90; Dired default file operation target no longer guessed Date: Thu, 14 May 2020 23:40:50 +0200 Message-ID: <87k11echzx.fsf@localhost> References: <875zcyhhtd.fsf@localhost> <87lflutufp.fsf@gmail.com> <83sgg24d1g.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="10367"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41261@debbugs.gnu.org To: Eli Zaretskii , =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 14 23:42:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jZLcJ-0002b3-9W for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 May 2020 23:42:11 +0200 Original-Received: from localhost ([::1]:56490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZLcH-0001bU-Uk for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 May 2020 17:42:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50880) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZLcA-0001bN-Hv for bug-gnu-emacs@gnu.org; Thu, 14 May 2020 17:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51793) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jZLcA-0006xv-8l for bug-gnu-emacs@gnu.org; Thu, 14 May 2020 17:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jZLcA-0005oJ-6R for bug-gnu-emacs@gnu.org; Thu, 14 May 2020 17:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Wojciech Siewierski Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 May 2020 21:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41261 X-GNU-PR-Package: emacs Original-Received: via spool by 41261-submit@debbugs.gnu.org id=B41261.158949246622242 (code B ref 41261); Thu, 14 May 2020 21:42:02 +0000 Original-Received: (at 41261) by debbugs.gnu.org; 14 May 2020 21:41:06 +0000 Original-Received: from localhost ([127.0.0.1]:35106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZLbG-0005mg-4R for submit@debbugs.gnu.org; Thu, 14 May 2020 17:41:06 -0400 Original-Received: from smtpo68.poczta.onet.pl ([141.105.16.18]:43172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZLbE-0005m2-73 for 41261@debbugs.gnu.org; Thu, 14 May 2020 17:41:05 -0400 Original-Received: from localhost (host-37-190-145-58.dynamic.mm.pl [37.190.145.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: wojciech.siewierski@onet.pl) by smtp.poczta.onet.pl (Onet) with ESMTPSA id 49NQ2X5D4qz20Y27Q; Thu, 14 May 2020 23:40:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=onet.pl; s=2011; t=1589492454; bh=K4ii/OVG+Y5FskJuI+s13gDoqxG91w1LnAlbbvnJCa8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=r38NwkgvTv5n0ylcHD8Okj3VYXp3Kb5gX1JYfczJtrmdU2le3qh7xxufUAEvDaX1y bJLmZNYd0P3t5m7UWjPRzJpRQ2orZ/cVU0NAyhfz+0KeVYsP68f5jBeyJP3M5kVX5F EyEKDWsehBZ4Jo4sIAV8ZEadt3QbcIRB+lIIR3p8= In-Reply-To: <83sgg24d1g.fsf@gnu.org> X-ONET_PL-MDA-SEGREGATION: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180280 Archived-At: Eli Zaretskii writes: >> From: K=C3=A9vin Le Gouguec >> Date: Thu, 14 May 2020 17:20:10 +0200 >> Cc: 41261@debbugs.gnu.org >>=20 >> Wojciech Siewierski writes: >>=20 >> > Test scenario, from 'emacs -Q': >> > 1. Open two dired buffers in two windows. >> > 2. Try moving a file by pressing 'R'. >> > 3. The currently suggested directory should be the file's original >> > directory, that's expected. >> > 4. Press M-n. >> > 5. The currently suggested directory should be the directory of the >> > second buffer window. >> > >> > That was the case in Emacs 26.3 but not in Emacs 27.0.90 which now >> > changes the moved file's directory into its full current path upon >> > pressing M-n. Just to be clear, I do not want the second directory to >> > be the initial default (i.e. what setting dired-dwim-target to t would >> > do), I only expect this behavior after pressing M-n. >>=20 >> If I'm not mistaken, this change in behaviour has been introduced in >> bug#35385. > > I'm not sure I understand how that could be possible, since the change > for bug#35385 didn't change any behaviors, it just added new functions > that can be optionally used as values of dired-dwim-target. > > Could you please bisect to see what change broke this? This behavior > wasn't supposed to change in Emacs 27. > > Thanks. I've bisected it and it seems it's indeed related to bug#35385, in commit d0351f4d2010e3e8f3ada04b045dede10f110d7f. Previously dired-dwim-target-recent's body was called unconditionally, now it's no longer the case. If I replace dired-dwim-target in the second part of the cond with a simple t, it seems to be back working. Setting dired-dwim-target also seems to still be working as expected. I noticed M-n cycles between all dired windows' current directories, so I assume the new functionality works too. I'm not sure if it's a full fix, can somebody take it from here? Thank you --=20 Wojciech Siewierski