From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#41531: 27.0.91; Better handle asynchronous eldoc backends Date: Wed, 08 Jul 2020 16:12:40 +0100 Message-ID: <87k0zef3br.fsf@gmail.com> References: <875zckuet9.fsf@gmail.com> <87sgecssch.fsf@gmail.com> <87tuynsdp6.fsf@gmail.com> <5d768a69-3574-10c5-e80a-8ab77ec60462@yandex.ru> <87h7umop62.fsf@gmail.com> <671983cf-e4f5-f128-541b-ceac793f35e5@yandex.ru> <877dvfiofy.fsf@gmail.com> <3211602a-ccc6-aa53-d192-77f27c2060ce@yandex.ru> <5a258c2b-39e7-76d7-0867-181ae3171710@yandex.ru> <7f1ec72b-2608-ad60-573d-528d22671ff6@yandex.ru> <7cc227db-f748-67d8-83b3-75502b9dbd9f@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7621"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 41531@debbugs.gnu.org, Stefan Monnier , andreyk.mad@gmail.com To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 08 17:13:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jtBl1-0001lJ-DV for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Jul 2020 17:13:11 +0200 Original-Received: from localhost ([::1]:36114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jtBl0-0004Ds-1E for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Jul 2020 11:13:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54426) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtBks-0004Cc-DH for bug-gnu-emacs@gnu.org; Wed, 08 Jul 2020 11:13:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55619) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jtBks-0001nb-2i for bug-gnu-emacs@gnu.org; Wed, 08 Jul 2020 11:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jtBkr-0006T2-Tz for bug-gnu-emacs@gnu.org; Wed, 08 Jul 2020 11:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Jul 2020 15:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41531 X-GNU-PR-Package: emacs Original-Received: via spool by 41531-submit@debbugs.gnu.org id=B41531.159422117124840 (code B ref 41531); Wed, 08 Jul 2020 15:13:01 +0000 Original-Received: (at 41531) by debbugs.gnu.org; 8 Jul 2020 15:12:51 +0000 Original-Received: from localhost ([127.0.0.1]:38932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jtBkg-0006SZ-9J for submit@debbugs.gnu.org; Wed, 08 Jul 2020 11:12:51 -0400 Original-Received: from mail-wm1-f48.google.com ([209.85.128.48]:55417) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jtBke-0006SM-BM for 41531@debbugs.gnu.org; Wed, 08 Jul 2020 11:12:48 -0400 Original-Received: by mail-wm1-f48.google.com with SMTP id g75so3614377wme.5 for <41531@debbugs.gnu.org>; Wed, 08 Jul 2020 08:12:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=JSpg5unCxqWnXUsUvu2+Z0vifH96jB45jawovCQ5r1Y=; b=jorUetZr7pX2v3mmOOP2ds07WKBwHzRXYhnMdl3WABV24P0eRTeA2bWquQOoIInJj4 yef5FYTyNk8HUIHL6S8movXlf8EOoj+Kq3WfyullnqQeipAWE8igqBQ3JZh1JWhWswrX tADMzcBE1fH7xiuaX5QsJBoAOOg3MLzK8eJTRiVuEXOi6QzGoA0IkKam0piOZpx3rqv4 XTK3ElXvF6Mjn2SzjEqK2DpdsBEMGymt39rRKjpXmfjjCy4QEbqpC9V3ReBbEs/VHlFE IdMjrW8pMNda5o7Og7Q9eYtJrPX/GreLOO3vtDWZQvM/oJlUVtvfZgB+dU1R5ABUoXdO W4Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=JSpg5unCxqWnXUsUvu2+Z0vifH96jB45jawovCQ5r1Y=; b=R7S/bQ1vVrY4l7D8zprb3DEMsPbrZhengTUuzsfSxtRsPdkTIBTBOEiyyqhCZTw5HX sgFLVlr+aGN7Hltx1STaCdJRokZy9a00ZJqrIYDJiYITAlgGjMnVRAe4XWMeq5CRMDww Fk354Cvt0jVv03J0uUEUEkyuX+SRnFVSSpn4KkWj8SFDMhh+ZOiaNSjJRJVSVVigaNEP a/kj20agD13ywT4DL7Yf0ReqHa5wQRhyCzWLssU32MCrt5X5Fsii2zznpPXOeSKppNEs xBFg4SODWmsDt6L5LUeT5090T6yixLuH8WST96WBp7DpcpAIyuiIKcjGWWr7A5RymIQ/ aMxQ== X-Gm-Message-State: AOAM532UAq8m0d/7U9dAkGFWChuNCqjUXpfL3Lw3PqHEIAmvKeoxmSmL bYgGftckBUPUD9kQKOa0mDI= X-Google-Smtp-Source: ABdhPJzIOYsqPMNzud4qtqyPiROBxNUWRgD7nmQv3SlcLfh9m9rflABVY38jo/43M580ojqJuN6PWQ== X-Received: by 2002:a1c:7717:: with SMTP id t23mr9641530wmi.75.1594221162535; Wed, 08 Jul 2020 08:12:42 -0700 (PDT) Original-Received: from krug ([2001:818:d820:9500:824a:171:15a:2213]) by smtp.gmail.com with ESMTPSA id r28sm397388wrr.20.2020.07.08.08.12.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 08:12:41 -0700 (PDT) In-Reply-To: <7cc227db-f748-67d8-83b3-75502b9dbd9f@yandex.ru> (Dmitry Gutov's message of "Wed, 8 Jul 2020 17:21:57 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182841 Archived-At: Dmitry Gutov writes: > On 08.07.2020 16:25, Stefan Monnier wrote: >> - do a quick version of the code for yourself. >> - then compare that with Joao's version. >> - then do a mix of: >> - argue to change or remove some parts of his code (those that would >> make it difficult for you to install your code on top of his) >> - keep the other changes to apply them after he installs his > > Since he went ahead, ignored the review and pushed the changes, > apparently I can just do the same now. > > That just leaves the buggy new features which went in without proper > justification. Can I go ahead and remove them, then? I think you should M-x report-emacs-bug and explain the bug.=20 Please stop falsely claiming I "ignored" you review. This is distateful and offensive. I replied to both emails: neither were a code review like Eli's and Stefan's were, which were much easier to follow. For the first one I replied diligently to each point as I could, especially when direct mentions to code that weren't related to futures and when I could understand your question. While the first email was already quite full of tension and off-hand remarks about my code being offensive and undemonstrated claims about code being bad in general, the second one was worse in that respect, it was purely opinative and again conflated most issues with your penchant for an implementation based on futures, making it extremely hard to follow your point, as I already told you. Therefore, I suggest you describe the issues with M-x report-emacs-bug for bugs and for features that you don't understand the value of. Make a separate bug report for each problem. Again, I promise to reply to those. Here are suggestions for subject lines of those bug reports, as I gathered them from my reading of your emails: - No purpose in `eldoc-documentation-enthusiast` - `eldoc-documentation-compose` causes blinking - `eldoc-documentation-functions` should use futures library - `eldoc-print-current-symbol-info` is extremely complicated - This much simpler patch would solve all of Eldoc's asynchronous problems - Eldoc now eats my homework Etc, etc. Hopefully some progress can be made in those discussions. Thank you very much, Jo=C3=A3o