From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#41438: [PATCH] Allow windmove keys to be bound without prefix or modifiers Date: Sun, 09 Aug 2020 02:54:17 +0300 Organization: LINKOV.NET Message-ID: <87k0y8vfom.fsf@mail.linkov.net> References: <87mu36enhl.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22616"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 41438@debbugs.gnu.org, larsi@gnus.org To: "Philip K." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 09 02:16:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4Z0V-0005mU-FU for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Aug 2020 02:16:11 +0200 Original-Received: from localhost ([::1]:45008 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4Z0T-0000ly-SE for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Aug 2020 20:16:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36472) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4Z0M-0000lb-5S for bug-gnu-emacs@gnu.org; Sat, 08 Aug 2020 20:16:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48208) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k4Z0L-00075s-Rf for bug-gnu-emacs@gnu.org; Sat, 08 Aug 2020 20:16:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k4Z0L-0002wm-Nu for bug-gnu-emacs@gnu.org; Sat, 08 Aug 2020 20:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Aug 2020 00:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41438 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41438-submit@debbugs.gnu.org id=B41438.159693213211292 (code B ref 41438); Sun, 09 Aug 2020 00:16:01 +0000 Original-Received: (at 41438) by debbugs.gnu.org; 9 Aug 2020 00:15:32 +0000 Original-Received: from localhost ([127.0.0.1]:59754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4Yzs-0002w4-2O for submit@debbugs.gnu.org; Sat, 08 Aug 2020 20:15:32 -0400 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:33941) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4Yzo-0002vp-PS for 41438@debbugs.gnu.org; Sat, 08 Aug 2020 20:15:30 -0400 X-Originating-IP: 91.129.102.47 Original-Received: from mail.gandi.net (m91-129-102-47.cust.tele2.ee [91.129.102.47]) (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 50EFA40002; Sun, 9 Aug 2020 00:15:20 +0000 (UTC) In-Reply-To: <87mu36enhl.fsf@posteo.net> (Philip K.'s message of "Fri, 07 Aug 2020 12:53:10 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184374 Archived-At: > But there are a few general issues I noticed: > > 1. windmove-display-{same-window,new-{frame,tab}} can disturb regular > input when the modifier is set to shift or none. Possible solutions > could be to prohibit using these modifiers or to add a prefix key and > generate a warning when eg. "S-t" or "t" would be rebound. Perhaps displaying a warning should be sufficient. > 2. The new function windmove--unbind works with the global-map, so when > someone sets a prefix to none, and then changes it to something else, > the arrow keys are left undefined. I could either see this being > fixed by using a separate map or by somehow memorising what the > previous key was (eg. by using the property list of the windmove > command's symbol). I'm not sure whether such complication is necessary. Usually users will try to customize the option and then restart Emacs.