From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#43103: 28.0.50; Default ElDoc composition strategy in Elisp mode (eldoc-documentation-strategy) Date: Sat, 29 Aug 2020 21:13:31 +0100 Message-ID: <87k0xhi51w.fsf@gmail.com> References: <87h7sla2gc.fsf@gmail.com> <83wo1hxx4c.fsf@gnu.org> <87r1rpigff.fsf@gmail.com> <83tuwlxqow.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30831"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43103@debbugs.gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 29 22:14:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kC7En-0007vf-Kr for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Aug 2020 22:14:09 +0200 Original-Received: from localhost ([::1]:41000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kC7Em-00034H-Gn for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Aug 2020 16:14:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kC7Eg-000346-Pr for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2020 16:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37658) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kC7Eg-0006vu-Fm for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2020 16:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kC7Eg-0005L4-Ar for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2020 16:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Aug 2020 20:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43103 X-GNU-PR-Package: emacs Original-Received: via spool by 43103-submit@debbugs.gnu.org id=B43103.159873202520494 (code B ref 43103); Sat, 29 Aug 2020 20:14:02 +0000 Original-Received: (at 43103) by debbugs.gnu.org; 29 Aug 2020 20:13:45 +0000 Original-Received: from localhost ([127.0.0.1]:49204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC7EP-0005KT-DZ for submit@debbugs.gnu.org; Sat, 29 Aug 2020 16:13:45 -0400 Original-Received: from mail-wr1-f53.google.com ([209.85.221.53]:39283) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC7EL-0005KE-EM for 43103@debbugs.gnu.org; Sat, 29 Aug 2020 16:13:43 -0400 Original-Received: by mail-wr1-f53.google.com with SMTP id a17so1436181wrn.6 for <43103@debbugs.gnu.org>; Sat, 29 Aug 2020 13:13:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=2zbnKfxWB+V0AAVLOIrLDFnnR6EjrtyjTxNls8vT2Bk=; b=A1JL+d+OWZPg0y1UCs8gMxBTEapbg/OvPOXFlzY901JxEQsKinSHlAs/GBv13eS7m6 oeBuI/rV9sRNkmnY7wRcCAq4FwxAkSWR/ZnKi0kjQYwlCVM/tq23p5wMlrpbhn6d/90L MPxlotHbe7Bw8v8v/v8qn2PZxgEjo3bm4sXPKw38LSaUW+Bnbdai6wCAS+Abl4isELhP MZ10vkiCviDaYxrb6r7vNrtWtbCsXuN8v6ZvCOKMmn/UzoRYaMMpOEZPEyN+WjAsXDjN VNKgxBYK9seSnsq1pedOrD6lbXKJDySHmUb23wdMW0yksGyL7YnzutIH5VvxnDxwjz85 asog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=2zbnKfxWB+V0AAVLOIrLDFnnR6EjrtyjTxNls8vT2Bk=; b=L6MSvud6+4KFOPiZI8VEUs8LuQuR8IWDWWAX7vOP63c6FrfWobrmXhSU7iKuyz8OlE c3V8PM0dHolTBWOGEAz99gDxrf6Br0ysb4H+4QtPTLL/Lvjgt+Hd2kyIe9CCzdFUoqbo ZF3MhPtbXy5TfM0z6SSSxeuJ1JOFBJ2f8K/loHIRuuEhAlecOgyNoqn/r/9zGOD7uuM9 rycMxstd6Nm8XpGSaspSi3ncDGCXuXtti5hqfy8wuwu9EQknCIawb8zyFRVLJfhQs2K2 zUnqLJgOpP6lfmTohMVKsEnCHMe3Rwf7m+jetlHkX/NzTtrdQDHJmc2WGWJyqaUv2cS7 N4hw== X-Gm-Message-State: AOAM532gQMuPJ90joAeSdQoSiydxpmLlTxcIKwEql0JllU6qY3Nrs2W7 J08Du+5dFUOsNynDOIZ/hfQ= X-Google-Smtp-Source: ABdhPJxmISlz0G63Gd+uPd2D5TvlnSxYOFse246EPZmaush6DOToZwQxJQy54hTL08Y/qvGAe5cYqA== X-Received: by 2002:a05:6000:162d:: with SMTP id v13mr5050768wrb.12.1598732015639; Sat, 29 Aug 2020 13:13:35 -0700 (PDT) Original-Received: from krug (a83-132-192-71.cpe.netcabo.pt. [83.132.192.71]) by smtp.gmail.com with ESMTPSA id h184sm3842901wmh.41.2020.08.29.13.13.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Aug 2020 13:13:34 -0700 (PDT) In-Reply-To: <83tuwlxqow.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 29 Aug 2020 21:17:03 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186677 Archived-At: Eli Zaretskii writes: >> From: Jo=C3=A3o T=C3=A1vora >> Cc: 43103@debbugs.gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca >> Date: Sat, 29 Aug 2020 17:07:48 +0100 >>=20 >> Eli Zaretskii writes: >>=20 >> > How will the proposed change modify the behavior in the use case with >> > which you started this message? >>=20 >> In the use case I started this message with, the user has enabled >> Flymake. Instead of seeing only the function signature in the echo area >> -- and being denied the presumed Flymake diagnostic "beneath it" -- this >> user would now see both items of information in two lines of said echo >> area. > > So the user will see both the function's signature and the Flymake's > error message because the call's syntax is not yet complete? That > sounds sub-optimal, doesn't it? why show an error message when the > user is clearly still typing the code? For me it's really not clear. What if the user changed the function signature elsewhere or the compilation the error check is based on might is looking at a different version of the library that has another protocol. When point is on those invalid calls, it's quite useful to be alerted to both the error and the signature. Also note this happens in any mode that uses Flymake and provide signatures, not just Elisp. So, situations where the user is typing function calls from scratch do happen, but they're not necessarily the majority -- it depends on the editing work. I will agree with you that displaying the transient error on those situations is alarmist and not very useful, but it's better fixed by adjusting 'flymake-no-changes-timeout' (or some other heuristic that makes Flymake less eager) than asserting that the simultaneous display of both pieces of information isn't useful _in general_. It is. In fact, I recall bug reports in Eglot that repeateadly state so. >> A similar reasoning applies to other situations with two competing >> different sources of context or "at point" documentation. Currently, >> even without Flymake there are function signatures and variable >> docstrings, for example. > > I'm talking specifically about Flymake, because it reports errors, > not just any information. More precisely, it reports "diagnostics", which may be errors, warnings, notes, or really any annotation about a region in your source. Anyway, from your statement, it seems you'd be OK (or at least find less problematic) that the two Flymake-unrelated lines: eldoc-idle-delay: Number of seconds of idle time to wait before printin= g. run-with-idle-timer: (SECS REPEAT FUNCTION &rest ARGS) [SECS is boldfa= ce] Being shown when point hovers on the second atom of the form (run-with-idle-timer eldoc-idle-delay nil ...) ?