From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#19032: bug#43120: 28.0.50; fido-mode: M-j before completions appear selects wrong choice Date: Wed, 09 Sep 2020 20:13:28 +0100 Message-ID: <87k0x2vk4n.fsf@gmail.com> References: <8736433l4c.fsf@iris.silentflame.com> <87o8mpd1fw.fsf@gnus.org> <87tuwewik5.fsf@iris.silentflame.com> <87zh66qoi9.fsf@gnus.org> <87pn72w7j2.fsf@iris.silentflame.com> <87eenifcgr.fsf@gnus.org> <87mu25wqdf.fsf@iris.silentflame.com> <87k0x876ls.fsf@gnus.org> <87k0x8tf1n.fsf@iris.silentflame.com> <87363w2ajd.fsf@gnus.org> <87tuwaoj6g.fsf@gmail.com> <871rjcwsmr.fsf@gmail.com> <87y2ljcaml.fsf@mail.parknet.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23363"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: OGAWA Hirofumi , Lars Ingebrigtsen , 43120@debbugs.gnu.org, 19032@debbugs.gnu.org, Sean Whitton To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 09 21:14:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kG5Xp-0005ws-Qr for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Sep 2020 21:14:13 +0200 Original-Received: from localhost ([::1]:34544 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kG5Xo-0006MW-Th for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Sep 2020 15:14:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37148) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kG5Xe-0006LG-Qf for bug-gnu-emacs@gnu.org; Wed, 09 Sep 2020 15:14:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51425) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kG5Xe-0003X3-GU for bug-gnu-emacs@gnu.org; Wed, 09 Sep 2020 15:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kG5Xe-0005eI-BS for bug-gnu-emacs@gnu.org; Wed, 09 Sep 2020 15:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Sep 2020 19:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19032 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 19032-submit@debbugs.gnu.org id=B19032.159967882021668 (code B ref 19032); Wed, 09 Sep 2020 19:14:02 +0000 Original-Received: (at 19032) by debbugs.gnu.org; 9 Sep 2020 19:13:40 +0000 Original-Received: from localhost ([127.0.0.1]:34736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG5XH-0005dP-RO for submit@debbugs.gnu.org; Wed, 09 Sep 2020 15:13:40 -0400 Original-Received: from mail-wm1-f46.google.com ([209.85.128.46]:51762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG5XF-0005d8-I6; Wed, 09 Sep 2020 15:13:38 -0400 Original-Received: by mail-wm1-f46.google.com with SMTP id w2so3362933wmi.1; Wed, 09 Sep 2020 12:13:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=5YGRHx5oa+q8uO7teXhj3ocKPiZYBpAmE4A/ELHfs28=; b=Ep8OAWKrYhjGKMsZ8pWcOCLaipMH5JtUWI0akPLDByHbt9hNkk4aT/Xi+3tdY+pw+h MUJ0ly0CBIUfqTYRa4bgvFlH6hxLNTM3cACAbPB+SOix+tt1+PVoc6kvyQSUzPNz9FVT xNwimD58vViQZLG9aogvjyYDINOPX8nthXGtw/BNDZCc+XDvtJNoW0dI6696XnUKfVYW tjh+O48qxcmuf9KL79U5Z1OzXvwipeUdqYGHj9bN7Zq/Ebq1o5wPrgdJmjKI8AxRCosn c4A01xEntH13WtAuoIevqDHniyAOaOBL+N6tfbJicUGzrg8k0FjGAvZ2mM1oIMD02m2G Ph5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=5YGRHx5oa+q8uO7teXhj3ocKPiZYBpAmE4A/ELHfs28=; b=fNfM3IpjQUqBO4TUegJi0soD+OyfIT2P641qP7FItHrClPuMf797QNZe6yFUQuvSGc FNauAR/t2A6k90vXdL2puOUPteLxeH4FIBObqx269gCdlY2ZhkUq+cvOXnNWHmPMt0jB 4UW8REIk76LVMsNe5k3wQdQcbvlWAPo0HSLRurH63MKshtoIvsmWHCKgILRNiepLnPHk UIE5BO3kTuZwBTCYQYo1CBar3zjNM6qL+77NeD7oDtVn71Hz1lmCN+61acNIrhKGW0MQ LFNaOKcLIzhWQRUZ5BVeq1rhFjzW6+cdepS2/Xr8H4sGovjkZSFnIJucr6Ff2FZYejEO qH9A== X-Gm-Message-State: AOAM530HkZYoKfXUEMZfX7EOKdly0nGi5qGrDlNi3N/mCL0eAaOsYo8o AzN4KMZRR/COi+sgAeQQN5c= X-Google-Smtp-Source: ABdhPJzV0OInTkMG04X3zmwXFuDkMDsAFkdM6+bi+YvKj20IJC+PKAAndvrtro5UiYuXoxPINQUwHA== X-Received: by 2002:a1c:5a56:: with SMTP id o83mr5106611wmb.77.1599678811664; Wed, 09 Sep 2020 12:13:31 -0700 (PDT) Original-Received: from krug ([89.180.151.22]) by smtp.gmail.com with ESMTPSA id m3sm80384wme.31.2020.09.09.12.13.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 12:13:31 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Wed, 09 Sep 2020 13:52:10 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187696 Archived-At: Stefan Monnier writes: >> Nope, sorry. You're right. It should read minibuffer-complete-and-exit t= here >> of course. > > IIRC this depends on whether the completion is `require-match` or not. If so, shouldn't minibuffer-complete-and-exit take care of that? I mean, I've remapped the binding to _that_ command, so unless it's making some "(interactive)" magic, which it is not, calling it from lisp in the normal case as it should be completely equivalent. I've gone ahead and commited the fix, as it fixes Hirofumi's problem, as he described it. Jo=C3=A3o