From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#27229: eldoc wrong highlighting for "when" Date: Sun, 04 Oct 2020 01:49:23 +0200 Message-ID: <87k0w6dg58.fsf@web.de> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23195"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "Charles A. Roelli" , 27229@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 04 01:50:48 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kOrIe-0005vQ-I6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Oct 2020 01:50:48 +0200 Original-Received: from localhost ([::1]:55588 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kOrIc-0001aH-V9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Oct 2020 19:50:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60448) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kOrHu-0001aB-8E for bug-gnu-emacs@gnu.org; Sat, 03 Oct 2020 19:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33078) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kOrHt-0005HC-Tt for bug-gnu-emacs@gnu.org; Sat, 03 Oct 2020 19:50:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kOrHt-0002dS-Ru for bug-gnu-emacs@gnu.org; Sat, 03 Oct 2020 19:50:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Oct 2020 23:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27229 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 27229-submit@debbugs.gnu.org id=B27229.160176897510090 (code B ref 27229); Sat, 03 Oct 2020 23:50:01 +0000 Original-Received: (at 27229) by debbugs.gnu.org; 3 Oct 2020 23:49:35 +0000 Original-Received: from localhost ([127.0.0.1]:44624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOrHT-0002cg-0a for submit@debbugs.gnu.org; Sat, 03 Oct 2020 19:49:35 -0400 Original-Received: from mout.web.de ([212.227.17.11]:56593) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kOrHQ-0002cR-Rj for 27229@debbugs.gnu.org; Sat, 03 Oct 2020 19:49:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1601768965; bh=P8nkIvByV0M8tO4QflP7n9AYoZtsdr5yWnyPgTBkph8=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=bZCZiSTThT/0GdjJyKqCETqW2vImLngpN1/PsEivyvuCTugIyO34GTRGvl0eS8Cig N9LB1bbdfRqVAEt7L8szpSSZHt1fzb/yJnxoEeX7KlQzYzUaZ6kas2GT+2Ya0We26K dlXvZ4d86YEB9F9yfFG8kJfQbcOc7YPfdySmgYjQ= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([94.218.220.78]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MSqXM-1jxzyN0jJW-00Umf8; Sun, 04 Oct 2020 01:49:25 +0200 In-Reply-To: (Stefan Kangas's message of "Sun, 16 Aug 2020 03:16:08 -0700") X-Provags-ID: V03:K1:eisLE2aDAF1/oOEvtmKF0IZDhRdUDf4ssQdI9hCuBzPcI3H5XvE ej3HFKg7OjF05gB3OotXFSFQthVaNT9UCefoV/vC0Mc6SUJZuPr6Zlq5ttkGTtxNXBFigUL 0Hn5/hUbmN/b/gtVRx4zfNc2q37c1TKbxjjrrgemZ6m8afAyT5AmYBYhxu05IhXqmoWq0xs 5kE58gFAVWLn06Tn3CsDg== X-UI-Out-Filterresults: notjunk:1;V03:K0:4VSpWy0RfrU=:CgHM6/Oi2qPXyeOuLN5Fxx +YjdSjgsuCzcKDTFZjctEXNv6/UXQ+8520EuyXRLqc/xxApoLd9llgD0K+dEB00U9T2YDfBtt Gsp3osoOWhwY5kvu/lpGMFqkrZa4f+9isdURNanVCx6ZiUnTB446t2udx5yvkPYI+tU932P9x FyhYN8A8YvRJWEx25qhm383E2X1PbLqW59nlmYvUUOFfi57L0mRtRzVhrYMuetg1lub6Y4T47 2/8AJLU1dA7t2cuu4XlvQDAeeK+HhJXn1KwFR4hVJghKxS0XsA3YWB7le4TUjsoU6hF2zgqgz hEYhav5ktrJ+9EXIAIkWKDpC1GUqGgbBsmzecGNJ9cYK5OFvMeXkXFkKijLov5PQvnM9rzMbU aljgr9M1uWF5h8Y85v7xITOICEEsySy3CiZ9e6LzAIut6KE8gZ1n0tCIx4VsS84ETkhQNEm1t lyL1XjTeO+LwUPh2kO6MZKHlJvfnori4XdZlssHjOg1er1vszvCiK4LGtxhIMZT3y1ee0SiNv ufGAqFQC7t2xqO4F8anoLUylqXoswkHHO92Pp+Qs2Ypq22CLaxDxvsQ+7SFay/nRDougBI3VV Q4MAdEFzD1ct8RlNxfAiWk2jORunU8uqZgTy0knzwsQeMGymyvh1ZRith1RsFk4W+xdz6cr1k UqhgXkk2NQY8SdnwU6fTMdkPGbfN3j2ykE6LiqyFAFZgN3b2qlABLjzd6r354Ov2OddYi8Gv0 g9HssiS8Mpys6aPbY5Mfho2eLJmPmLTybDMMpt1vVG+ap1gZv5MjWYwLNZiINT0ZHICLk8cB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189731 Archived-At: Stefan Kangas writes: > "Charles A. Roelli" writes: > > > From emacs -q, type "(when x y z": COND is highlighted > > instead of BODY. This is a regression from the behavior > > of 24.5 (with eldoc-mode on). > > I can reproduce this on current master. Seems this code is the culprit (`elisp--highlight-function-argument'): | ;; Back to index 0 in ARG1 ARG2 ARG2 ARG3 etc... | ;; like in `setq'. | ((or (and (string-match-p "\\.\\.\\.\\'" argument) | (string= argument (car (last args-lst)))) | (and (string-match-p "\\.\\.\\.\\'" | (substring args 1 (1- (length args)))) | (= (length (remove "..." args-lst)) 2) | (> index 1) (eq (logand index 1) 1))) | (setq index 0)) In general, the problem is that "..." can have different meanings (it's not clear which arguments have to be repeated), so this is not trivial to fix I think. Michael.