From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tomas Nordin Newsgroups: gmane.emacs.bugs Subject: bug#44858: [PATCH] Make byte-compiler warn about wide docstrings Date: Thu, 03 Dec 2020 21:18:48 +0100 Message-ID: <87k0tyabiv.fsf@fliptop.i-did-not-set--mail-host-address--so-tickle-me> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23530"; mail-complaints-to="usenet@ciao.gmane.io" To: Stefan Kangas , 44858@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 03 21:19:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kkv4K-00061c-IR for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Dec 2020 21:19:12 +0100 Original-Received: from localhost ([::1]:41934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kkv4J-0006qP-JQ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Dec 2020 15:19:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37892) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkv4B-0006nQ-3N for bug-gnu-emacs@gnu.org; Thu, 03 Dec 2020 15:19:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58559) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kkv4A-0003bL-R2 for bug-gnu-emacs@gnu.org; Thu, 03 Dec 2020 15:19:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kkv4A-0005V5-Hh for bug-gnu-emacs@gnu.org; Thu, 03 Dec 2020 15:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tomas Nordin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Dec 2020 20:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44858 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44858-submit@debbugs.gnu.org id=B44858.160702673921135 (code B ref 44858); Thu, 03 Dec 2020 20:19:02 +0000 Original-Received: (at 44858) by debbugs.gnu.org; 3 Dec 2020 20:18:59 +0000 Original-Received: from localhost ([127.0.0.1]:41872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkv47-0005Uo-Ah for submit@debbugs.gnu.org; Thu, 03 Dec 2020 15:18:59 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:56168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kkv44-0005Ua-H9 for 44858@debbugs.gnu.org; Thu, 03 Dec 2020 15:18:57 -0500 Original-Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 347A0160060 for <44858@debbugs.gnu.org>; Thu, 3 Dec 2020 21:18:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1607026730; bh=1BycjXSeJAUjSLjNC1POaMtqKuFUmzrEllKUbV/ik3k=; h=From:To:Subject:Date:From; b=QXjPwccid2B2cGTOo8wIIhGD0zbkX/H9mxfnh/xHluS8CDW+1PVNk9rc9Q8Jpjp9g oMAH0nhwH86MNPUbHH0rbLtVGVe5bqUwcwdGH+0n9/RHvPMvoApUdEy/pNKx6z0IhL w7w/D7mmnVy682DgDqO4fEkC+LOlcIW5B/c5ETni/YJUDtGxNwj7G6oXfSRNex/zoJ A24AqhpKbm55natBatLlKJRIvs2n1ZeVl2PoN107mQQKpSB+5KKTn7xD24G62p87gs n7tQY1dJ0LTPp0BDvzkExu3jSq56pEiXhdUmS0rFFK5C1QcgthRpHjUV5uDhfIOwss uttBVIoFi/MIg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Cn6c93Bt4z9rxQ; Thu, 3 Dec 2020 21:18:49 +0100 (CET) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194924 Archived-At: Stefan Kangas writes: > Thoughts? One thing that caught my eye @@ -322,6 +323,8 @@ byte-compile-warnings make-local calls to make-variable-buffer-local that may be incorrect. mapcar mapcar called for effect. constants let-binding of, or assignment to, constants/nonvariables. + docstrings docstrings that are too wide (no longer than 80 characters, + or `fill-column', whichever is bigger) suspicious constructs that usually don't do what the coder wanted. Should 'no' maybe be removed? (if to tell something that should not be). -- Tomas