From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#44611: Prefix arg for xref-goto-xref Date: Tue, 22 Dec 2020 10:58:35 +0200 Organization: LINKOV.NET Message-ID: <87k0tab3y0.fsf@mail.linkov.net> References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> <83v9cwsct7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23135"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: dgutov@yandex.ru, joaotavora@gmail.com, 44611@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 22 10:18:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1krdo1-0005uB-Ob for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Dec 2020 10:18:09 +0100 Original-Received: from localhost ([::1]:39602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1krdo0-0006kN-QK for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Dec 2020 04:18:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49080) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1krdnu-0006k2-1V for bug-gnu-emacs@gnu.org; Tue, 22 Dec 2020 04:18:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37372) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1krdnt-0004jG-Ph for bug-gnu-emacs@gnu.org; Tue, 22 Dec 2020 04:18:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1krdnt-0002xU-Iu for bug-gnu-emacs@gnu.org; Tue, 22 Dec 2020 04:18:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Dec 2020 09:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44611 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 44611-submit@debbugs.gnu.org id=B44611.160862865811324 (code B ref 44611); Tue, 22 Dec 2020 09:18:01 +0000 Original-Received: (at 44611) by debbugs.gnu.org; 22 Dec 2020 09:17:38 +0000 Original-Received: from localhost ([127.0.0.1]:48918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krdnK-0002wF-ND for submit@debbugs.gnu.org; Tue, 22 Dec 2020 04:17:38 -0500 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:41585) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krdnI-0002vv-Tu for 44611@debbugs.gnu.org; Tue, 22 Dec 2020 04:17:25 -0500 Original-Received: from mail.gandi.net (m91-129-99-98.cust.tele2.ee [91.129.99.98]) (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 078E610000D; Tue, 22 Dec 2020 09:17:15 +0000 (UTC) In-Reply-To: <83v9cwsct7.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 20 Dec 2020 17:43:32 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196564 Archived-At: >> And since the new keybinding have no disastrous effect, it would safer >> for the users to adapt to the new keybinding. > > What disastrous effects? AFAICT, TAB buries the XREF buffer, which is > not a disaster. It takes the same amount of efforts to bring it back: either by finding the buried buffer in the buffer list, or running project-find-regexp again. > More generally, I think it's wrong to try to make XREF buffers behave > like *Grep* buffers. They are different beasts, I think we > established this long ago, when Xref was added to Emacs (I think I > even made a comment regarding the difference, and Dmitry responded to > the effect that this was intended). *XREF* and *Grep* look > differently and behave differently, and it's impossible to make them > be similar enough. They might be different when *xref* is used as a completions buffer when the *xref* buffer is created by 'M-.' (xref-find-definitions). Moreover, now it's possible to use the real *Completions* buffer by customizing xref-show-definitions-function to xref--show-defs-minibuffer. Even is this case TAB doesn't close the *Completions* buffer. But a completely separate case is when the *xref* buffer is created by such grep-like commands as project-find-regexp. So currently there are two different uses of the *xref* buffer: 1. as a transient completions buffer that could be buried after a completion is selected from the buffer; 2. as a grep buffer for visiting the found matches. In the second case, it's natural to type TAB to navigate results. Should these cases use different modes with different buffer names? Such as a buffer name *xgrep*?