From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#45617: loses the edit region. Works in 23.3, broke in 26.3 Date: Fri, 15 Jan 2021 10:54:56 +0200 Organization: LINKOV.NET Message-ID: <87k0sezj07.fsf@mail.linkov.net> References: <000001d6e16c$984bcb70$c8e36250$@net> <83turycc18.fsf@gnu.org> <87ble4ob6v.fsf@mail.linkov.net> <000601d6e2ea$8f6601e0$ae3205a0$@net> <877dorkznt.fsf@mail.linkov.net> <002701d6e39b$4ac35680$e04a0380$@net> <8735ze9e09.fsf@mail.linkov.net> <83mtxm0vzd.fsf@gnu.org> <002d01d6e478$ca50cdf0$5ef269d0$@net> <87k0sgirr0.fsf@mail.linkov.net> <002101d6eadc$e816a070$b843e150$@net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18156"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 45617@debbugs.gnu.org To: "Bob Floyd" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 15 10:20:20 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l0LHI-0004d0-Tf for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Jan 2021 10:20:20 +0100 Original-Received: from localhost ([::1]:37608 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0LHH-0008MR-Uq for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Jan 2021 04:20:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44058) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0LF5-0001kF-BR for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2021 04:18:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56590) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l0LF5-0002Mo-4E for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2021 04:18:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l0LF4-0007u6-V0 for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2021 04:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Jan 2021 09:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45617 X-GNU-PR-Package: emacs Original-Received: via spool by 45617-submit@debbugs.gnu.org id=B45617.161070224230317 (code B ref 45617); Fri, 15 Jan 2021 09:18:02 +0000 Original-Received: (at 45617) by debbugs.gnu.org; 15 Jan 2021 09:17:22 +0000 Original-Received: from localhost ([127.0.0.1]:39899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0LEQ-0007sv-2F for submit@debbugs.gnu.org; Fri, 15 Jan 2021 04:17:22 -0500 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:34229) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0LEN-0007sg-S5 for 45617@debbugs.gnu.org; Fri, 15 Jan 2021 04:17:20 -0500 X-Originating-IP: 91.129.98.64 Original-Received: from mail.gandi.net (m91-129-98-64.cust.tele2.ee [91.129.98.64]) (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id EDACE240006; Fri, 15 Jan 2021 09:17:12 +0000 (UTC) In-Reply-To: <002101d6eadc$e816a070$b843e150$@net> (Bob Floyd's message of "Thu, 14 Jan 2021 17:22:34 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197977 Archived-At: > I've removed the earlier patch and installed these changes. Now testing it! > Thanks. > > -----Original Message----- > (defun query-replace-read-args (prompt regexp-flag &optional noerror) > (unless noerror > (barf-if-buffer-read-only)) > + (save-mark-and-excursion > (let* ((from (query-replace-read-from prompt regexp-flag)) > (to (if (consp from) (prog1 (cdr from) (setq from (car from))) > (query-replace-read-to from prompt regexp-flag)))) It seems this is what we need to push to be able to close this bug report. Indeed, it fixes only query-replace commands. But fixing all commands that use the minibuffer is not as easy as adding 'save-mark-and-excursion' like in the patch above. The problem is that 'read-from-minibuffer' is implemented in C. If it was implemented in Lisp, it would be easy to add just 'save-mark-and-excursion', but in C this is impossible.