From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#42425: 26.3.50; Compilation warnings when compiling eldoc.el under Emacs 26.3 Date: Sat, 23 Jan 2021 19:31:27 +0100 Message-ID: <87k0s3v728.fsf@gnus.org> References: <878s8kyc90.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22973"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 42425@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 23 19:32:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3Nhj-0005qC-Io for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Jan 2021 19:32:11 +0100 Original-Received: from localhost ([::1]:39276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3Nhi-0007AF-K5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Jan 2021 13:32:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46666) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3Nha-00078I-3u for bug-gnu-emacs@gnu.org; Sat, 23 Jan 2021 13:32:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51940) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l3NhZ-0008Pk-Rv for bug-gnu-emacs@gnu.org; Sat, 23 Jan 2021 13:32:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l3NhZ-0003qB-Op for bug-gnu-emacs@gnu.org; Sat, 23 Jan 2021 13:32:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Jan 2021 18:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42425 X-GNU-PR-Package: emacs Original-Received: via spool by 42425-submit@debbugs.gnu.org id=B42425.161142669914734 (code B ref 42425); Sat, 23 Jan 2021 18:32:01 +0000 Original-Received: (at 42425) by debbugs.gnu.org; 23 Jan 2021 18:31:39 +0000 Original-Received: from localhost ([127.0.0.1]:35253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3NhD-0003pa-C4 for submit@debbugs.gnu.org; Sat, 23 Jan 2021 13:31:39 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:54874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3NhC-0003pM-HF for 42425@debbugs.gnu.org; Sat, 23 Jan 2021 13:31:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=KV/wPy5a/YVrIOfiGDMM1YmdpAYxshqtMVJMa1rlxBA=; b=Ohxqq1Hp1CBOZYhJHooWp4+/u/ AocKPCffNsK8Mja3uv4FuxN4rmn0H325gc/E8AT51zFalfIfPlg39uAeKLpowQmDE0jTlNH2nJdAg LD2YYLdc9CGWmXL5yF30OROgyv/qQbJpuLQoQW3FJb5B3bRa65aisViR/Dkfwcs/Io/I=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3Nh2-0003qf-Ih; Sat, 23 Jan 2021 19:31:31 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEX9/f3O0NCdoaB9 goFRWVYwOTYhUjn///+LlGGjAAAAAWJLR0QHFmGI6wAAAAlwSFlzAAALEgAACxIB0t1+/AAAAAd0 SU1FB+UBFxIaAaJ721QAAAFZSURBVDjLfVRJUsMwEDSEBwSK3EOB7ymi3B0s3yHR6AfS/5+AZtNm Q19SmVbP0hp5GBQvxtr5bejxYIAw79v44wICd2zO53hias0FKtxL/BUaXHMi6KDJDj3x84cAHBNP KwKmdUuMG80GG9hvZnKca6Q/PgYfhLDcF7sRY/TBZ8Jpsz6iwocoRCqyUwEpKF2qAUepHVURRTGx Hz5mJIEjV0Y8URFBicuasDT7ggRFlLCWbqsQAFUqJOwiEU4I1pHzC3bH7YAQ1jABrPDUNY6YaxCR XIRAvBSv2vX0w8Vv1YAhUNM64CGbGLUrTPVdTGSFEpPYjocB/SUXyfbuopDgi2qulhWWF7taBiTK Msj6UJivNhGnenXzljjZd11Rh+a4sqKcy1mEoRk40z/PQB/O+WxM/QqKZOkEq4U/lWc7rl7Nxgfg 3nw0CtPGE/PB8a8unvD8bubPEv4FZ+wvnMp3ApcAAAAZdEVYdGNvbW1lbnQAQ3JlYXRlZCB3aXRo IEdJTVDnr0DLAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTAxLTIzVDE4OjI2OjAxKzAwOjAwBatW dgAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wMS0yM1QxODoyNjowMSswMDowMHT27soAAAAASUVO RK5CYII= X-Now-Playing: Herbert's _Part Three_: "People That Make The Music" In-Reply-To: (Philipp Stephani's message of "Sat, 23 Jan 2021 18:35:07 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198448 Archived-At: Philipp Stephani writes: >> Doing so seems easy enough, but I'm not sure how high our ambitions are >> for doing warning-free ELPA packages on older Emacs versions? (I've >> added Jo=C3=A3o to the CCs.) > > I think our ambitions should be quite high. (I personally think we > should treat almost all compiler warnings as errors/bugs and fix them > whenever realistically possible.) Building Emacs has traditionally been watching a wall of warnings scroll by. This has recently changed, but shows that "no warnings" isn't a value held universally by the Emacs developers. I think that the Emacs build should be warning free -- on our main, current targets. Jumping through hoops to avoid warnings on older Emacs versions normally isn't worth spending time on, in my opinion. But we really have no policy here. >> > 2. Probably eldoc should protect against newer Elisp functions being n= ot >> > yet available, as calling such functions will likely result in erro= rs >> > at runtime. >> >> Doesn't it do that? What functions is it using that's not available? > > At least the current master version looks fine, though the byte > compiler isn't smart enough to detect that. The problematic uses are > in eldoc--eval-expression-setup. I'm not sure I follow you here -- are you saying that eldoc doesn't work on Emacs 26 because of the usages in `eldoc--eval-expression-setup'? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no