From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#46641: process-tests assume network connection Date: Sun, 21 Feb 2021 14:41:11 +0100 Message-ID: <87k0r1k07c.fsf@gnus.org> References: <4lpn0wndla.fsf@fencepost.gnu.org> <871rd9smip.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29199"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Glenn Morris , 46641@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 21 14:42:47 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lDp0Y-0007SF-3T for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Feb 2021 14:42:46 +0100 Original-Received: from localhost ([::1]:55928 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lDp0X-000060-0n for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Feb 2021 08:42:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52306) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDozu-0008W7-Nm for bug-gnu-emacs@gnu.org; Sun, 21 Feb 2021 08:42:09 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42158) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lDozq-0004wI-0a for bug-gnu-emacs@gnu.org; Sun, 21 Feb 2021 08:42:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lDozp-0003Nc-Ug for bug-gnu-emacs@gnu.org; Sun, 21 Feb 2021 08:42:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Feb 2021 13:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46641 X-GNU-PR-Package: emacs Original-Received: via spool by 46641-submit@debbugs.gnu.org id=B46641.161391488212945 (code B ref 46641); Sun, 21 Feb 2021 13:42:01 +0000 Original-Received: (at 46641) by debbugs.gnu.org; 21 Feb 2021 13:41:22 +0000 Original-Received: from localhost ([127.0.0.1]:53704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDozC-0003Mj-Cd for submit@debbugs.gnu.org; Sun, 21 Feb 2021 08:41:22 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:35704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDozB-0003MW-I6 for 46641@debbugs.gnu.org; Sun, 21 Feb 2021 08:41:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QKMRFZLSg52SG7sR4eMTcZPpXm8IPtutwKOsy1Vul8M=; b=jKGux+zYYMEiKXcRYJUpZN9pbD zLlNW+2S91ckQp0mexNzLQjcG5x4tYZaF24KLhgK5I51tJWWcJxwxHZCCwKD9RRL13k5lZ9cRtVgz 1ahmsnQG6E2l0s2jI8L6I6O8Nf3L5nR4+YO22kuELW+hJFEqzHRqrsjJ03MvQLvEtFOg=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lDoz2-0008VU-S9; Sun, 21 Feb 2021 14:41:15 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEXv4c/BtaeJgHdW UUv///8yXQ++AAAAAWJLR0QEj2jZUQAAAAd0SU1FB+UCFQ0GEaNowHsAAAGkSURBVDjLXVOLFcMg CARdAM0Cigsksv9uBVFjw2sT4/HxDgQkWPauzAIXoJgpI3aCYlv6wAKx9atH5tYqCzexVe9sgDTO 7elcxX79ynLxUzQVdw5Xy5wSM+tf/TgXQC7wb+wvZPoA8zvKnedOhUBNhukBMZkHU7jVFfWTrdLK glBj13c7I4pXiY+7vBGEZdcAnBHiuRK8iqVh80MgllVsPGlTCWU40wSS5wlSNIKm/1eIZfhApnEO 1S2xBX7aFYQly/Axf+V+H+G2OwlaLlxAdD5pSTTkmQz/0jsPTw4ZPoYzrGn9UHDEBTribWvL+Q7X 0V6smGmxul4ghUe73eaR0Iu3fp6NVI84glD7gy9j2sSCSBkk0oiqWz0HtlVY/QVvtbWW1hC4DJcK WbFOgKgeco23Z3cyx8XawNgKe2UAvnyS8qDBIi2JNJWuaaiiRUdOnBkZkRC+VnVa3EXnzC+FF692 13CfzP+7M/j3pIR2o+Zs6+CmCaRzNHbxHBIvtUuU0uwI8pxOCgQ2HhkcsI7Q8tKhhUsB624sKDek GT5AB3S8uPwAvKgswflmujsAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjEtMDItMjFUMTM6MDY6MTcr MDA6MDAxgsZ6AAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTAyLTIxVDEzOjA2OjE3KzAwOjAwQN9+ xgAAAABJRU5ErkJggg== X-Now-Playing: Ishmael Ensemble's _Blue Note Re:imagined (1)_: "Search For Peace" In-Reply-To: <871rd9smip.fsf@gmail.com> (Robert Pluim's message of "Sun, 21 Feb 2021 12:11:58 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200493 Archived-At: Robert Pluim writes: > Glenn> Some process-tests fail if the system has no network connection. > Glenn> I don't know what the appropriate skip-unless condition to test for > Glenn> network access is. > > Glenn> Ref: https://bugs.debian.org/982969 > > So Debian deliberately cripple their test environment, run the network > tests for an editor which can do network access, and we have to adapt > our tests? I am not amused. > > I guess we could wrap them all in > > (skip-unless (dns-query "google.com")) It'd be nice if Emacs did have a predicate for "is there any network here?" But I don't know what that would look like. That is, there's a difference between having a local network (i.e., 127.0.0.1), and being on the Internet. But if any of our tests require Emacs to be on a functioning internet connection, they should indeed be guarded by something like the `skip-unless' you propose. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no