From: akater <nuclearspace@gmail.com>
To: 47327@debbugs.gnu.org
Subject: bug#47327: 28.0.50; (cl-generic) eql specializer not evaluated
Date: Mon, 22 Mar 2021 17:08:09 +0000 [thread overview]
Message-ID: <87k0pz5d6u.fsf@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2136 bytes --]
In ~(eql VAL)~ specializer, ~VAL~ should evaluate during evaluation of
the macroexpanded ~cl-defmethod~ form.
For some reason =cl-generic.el= does not do that (it does not evaluate
the specializer form at all). Here's a hack fix that seems to work for
me but I do not have a deep enough understanding of ~cl-generic~ to
actually suggest it:
#+begin_src emacs-lisp :results none
(cl-defmethod cl-generic-generalizers ((specializer (head cl:eql)))
"Support for (eql VAL) specializers.
These match if the argument is `eql' to VAL."
(let ((value (eval (cadr specializer) t)))
(setf (car specializer) 'eql)
(puthash value specializer cl--generic-eql-used))
(list cl--generic-eql-generalizer))
#+end_src
Rationale:
(1) See Common Lisp HyperSpec:
#+begin_quote
The parameter specializer name ~(eql eql-specializer-form)~
indicates that the corresponding argument must be eql to the object
that is the value of ~eql-specializer-form~ for the method to be applicable.
The ~eql-specializer-form~ is evaluated
at the time that the expansion of the defmethod macro is evaluated.
#+end_quote
---
[[http://www.lispworks.com/documentation/HyperSpec/Body/m_defmet.htm][Macro
DEFMETHOD]]
(2) With eql specializer form not evaluated it does not seem possible to
e.g. use a custom method combination, even though ~cl-generic~ informs
that it is possible. The only way I can think of, is
specializing ~cl-generic-combine-methods~ on the particular generic
function:
#+begin_src emacs-lisp :results none :eval never
(cl-defmethod cl-generic-combine-methods ((generic
(cl:eql
(cl--generic
'my-generic-function)))
methods)
"Use `my-method-combination' method for generic function `my-generic-function'."
(my-method-combination generic methods))
#+end_src
which is impossible if the specializer form is not evaluated.
(3) With eql specializer form not evaluated, it is only possible to
dispatch on eql numbers or eql symbols which is needlessly limited.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 865 bytes --]
next reply other threads:[~2021-03-22 17:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 17:08 akater [this message]
2021-03-23 23:19 ` bug#47327: 28.0.50; (cl-generic) eql specializer not evaluated Michael Heerdegen
2021-03-23 23:32 ` akater
2021-03-24 0:22 ` Michael Heerdegen
2021-07-02 11:25 ` akater
2021-07-16 3:03 ` Michael Heerdegen
2021-07-16 21:00 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-19 21:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-20 2:28 ` akater
2021-08-03 16:00 ` akater
2021-08-03 23:02 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-10 12:39 ` Madhu
2021-08-10 12:56 ` Christian Albrecht via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-19 11:41 ` Madhu
2021-08-19 13:10 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0pz5d6u.fsf@gmail.com \
--to=nuclearspace@gmail.com \
--cc=47327@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).