From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#48264: [PATCH v3 07/15] Add BVAR_OR_DEFAULT macro as a stub Date: Fri, 07 May 2021 09:05:26 -0400 Message-ID: <87k0oar8x5.fsf@catern.com> References: <877dkbsj9d.fsf@catern.com> <20210506213346.9730-8-sbaugh@catern.com> <837dkaddbc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27398"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48264@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 07 15:06:32 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lf0Bc-00071A-Mj for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 15:06:32 +0200 Original-Received: from localhost ([::1]:34480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lf0Bb-0001du-NQ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 09:06:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lf0B8-0000qV-8m for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 09:06:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60480) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lf0B7-0005sB-Vh for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 09:06:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lf0B7-0006aL-Q1 for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 09:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 May 2021 13:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48264 X-GNU-PR-Package: emacs Original-Received: via spool by 48264-submit@debbugs.gnu.org id=B48264.162039273125302 (code B ref 48264); Fri, 07 May 2021 13:06:01 +0000 Original-Received: (at 48264) by debbugs.gnu.org; 7 May 2021 13:05:31 +0000 Original-Received: from localhost ([127.0.0.1]:43792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lf0Ac-0006a2-VP for submit@debbugs.gnu.org; Fri, 07 May 2021 09:05:31 -0400 Original-Received: from venus.catern.com ([68.183.49.163]:59996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lf0Aa-0006Zw-Hb for 48264@debbugs.gnu.org; Fri, 07 May 2021 09:05:29 -0400 Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=98.7.229.235; helo=localhost; envelope-from=sbaugh@catern.com; receiver= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=catern.com; s=mail; t=1620392727; bh=rqx12c3duSB4+mpSWInFdQFSGLzwi3J+VzwkelfnGqA=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=jeT6VE1VqghrIhclHqCjsos1imiEc+QlR6mEVphqoRi3Jk4+gYqKvm1vekKRx3i5H bpmm/yamEhqdCi3XApcCmOjM1iwuEXMozhqh3b/aSiEigt+RO1wP1ngyGbKrlgKar0 jt0QwOTg0u4PwvANatPF0VQOK+GUMzn31imH9QMM= Original-Received: from localhost (cpe-98-7-229-235.nyc.res.rr.com [98.7.229.235]) by venus.catern.com (Postfix) with ESMTPSA id A80D22E9748; Fri, 7 May 2021 13:05:27 +0000 (UTC) In-Reply-To: <837dkaddbc.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205930 Archived-At: Eli Zaretskii writes: >> From: Spencer Baugh >> Date: Thu, 6 May 2021 17:33:38 -0400 >> Cc: Spencer Baugh >> >> For buffer variables without a default, we still use BVAR. For any >> buffer variable with a default, we use BVAR_OR_DEFAULT. A later >> commit will statically enforce this. > > This part says they are the same: > >> --- a/src/buffer.h >> +++ b/src/buffer.h >> @@ -284,6 +284,8 @@ struct buffer_text >> >> #define BVAR(buf, field) ((buf)->field ## _) >> >> +#define BVAR_OR_DEFAULT(buf, field) BVAR (buf, field) > > What am I missing here? The commit message is accurate - we indeed use BVAR for buffer variables without a default, and BVAR_OR_DEFAULT for buffer variables with a default. It's just that in this commit, those two behave identically. The immediate next commit makes them different. I split it up in this way because this commit is the result of a big tree-wide sed, no actual meaningful change; I think it's much easier to understand the next commit when the two are kept separate. > Also, I have a question: suppose we have a variable that is defined > with DEFVAR_LISP, and then some Lisp calls make-variable-buffer-local: > how will that work with these two macros when the C code needs to > access the buffer-local value? Nothing in these changes affect variables that are made into buffer-locals from Lisp code; these changes only affect variables built-in to Emacs that were defined with DEFVAR_PER_BUFFER. So that will just work the same as it does today - accesses to such variables don't go through BVAR today.