From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#47300: delete-window to select window with same position Date: Mon, 31 May 2021 23:46:49 +0300 Organization: LINKOV.NET Message-ID: <87k0nefwq6.fsf@mail.linkov.net> References: <87a6qw43gg.fsf@mail.linkov.net> <87pmxodrmq.fsf@gnus.org> <7f870f9b-95ad-6b5d-82aa-1bcfe5cc880a@gmx.at> <87fsyk0w92.fsf@mail.linkov.net> <2ec3b911-4fb1-4b13-a5b8-28278a5c43ba@gmx.at> <87h7iyzvh5.fsf@mail.linkov.net> <0c239adb-e9d5-1fe9-4c4c-2da1603002f7@gmx.at> <87mtsmmpey.fsf@mail.linkov.net> <1032ab23-3905-1b3f-917c-60ccd12337b3@gmx.at> <87v9752n4r.fsf@mail.linkov.net> <63612145-5eaa-0766-30cc-f30f7e7e1700@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29899"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , 47300@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 31 22:59:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lnp0G-0007gG-81 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 31 May 2021 22:59:16 +0200 Original-Received: from localhost ([::1]:56798 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lnp0F-00039T-AA for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 31 May 2021 16:59:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35010) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnp03-00039F-AU for bug-gnu-emacs@gnu.org; Mon, 31 May 2021 16:59:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51701) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lnp02-0006ti-BS for bug-gnu-emacs@gnu.org; Mon, 31 May 2021 16:59:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lnp02-0001ND-9k for bug-gnu-emacs@gnu.org; Mon, 31 May 2021 16:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 May 2021 20:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47300 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47300-submit@debbugs.gnu.org id=B47300.16224947155241 (code B ref 47300); Mon, 31 May 2021 20:59:02 +0000 Original-Received: (at 47300) by debbugs.gnu.org; 31 May 2021 20:58:35 +0000 Original-Received: from localhost ([127.0.0.1]:35014 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnozb-0001MT-D4 for submit@debbugs.gnu.org; Mon, 31 May 2021 16:58:35 -0400 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:58045) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnozY-0001MF-HE for 47300@debbugs.gnu.org; Mon, 31 May 2021 16:58:33 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 1A1FC240002; Mon, 31 May 2021 20:58:24 +0000 (UTC) In-Reply-To: <63612145-5eaa-0766-30cc-f30f7e7e1700@gmx.at> (martin rudalics's message of "Thu, 27 May 2021 17:20:51 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207735 Archived-At: > + (when (and (>= x (nth 0 edges)) (< x (nth 2 edges)) > + (>= y (nth 1 edges)) (< y (nth 3 edges))) > > We have to mention the "<" somewhere. For two side-by-side windows with > the right window's point at 1, we obviously must avoid the left window's > right edge because the X, Y coordinates set by pos_visible_p are the top > left edge of the character box at that position, i.e., 0, 0. > > But OTOH the "<" leaves the right edge of a frame's rightmost window > unhandled and someone might use that function for other purposes. I changed <= to < to fix only Y coordinates for top/bottom windows, but maybe X coordinates should still use <= ? > It would be a tad more elegant to just save `posn-at-point' here ... > > + (setq posn-at-point-x (+ (nth 0 edges) (car posn-at-point)) > + posn-at-point-y (+ (nth 1 edges) (cdr posn-at-point)))))) > ;; Actually delete WINDOW. > (delete-window-internal window) > (window--pixel-to-total frame horizontal) > - (when (and frame-selected > > ... and delay extracting its car and cdr until here. > > + (when (and posn-at-point-x posn-at-point-y > + (setq window-at-posn-at-point > + (window-at-pos posn-at-point-x posn-at-point-y frame))) Please note that the crucial difference is that now it uses frame relative positions rather than window relative ones with '(window-edges window nil nil t)' of the window to be deleted, and window coordinates added to X and Y of posn-at-point. > I'd still urge you to transfer the `get-mru-window' call here too, that > is, the entire > > /* Now look whether `get-mru-window' gets us something. */ > mru_window = call1 (Qget_mru_window, frame); > if (WINDOW_LIVE_P (mru_window) > && EQ (XWINDOW (mru_window)->frame, frame)) > new_selected_window = mru_window; > > /* If all ended up well, we now promote the mru window. */ > if (EQ (FRAME_SELECTED_WINDOW (f), selected_window)) > Fselect_window (new_selected_window, Qnil); > else > fset_selected_window (f, new_selected_window); > > block, and to include the > > (when (and frame-selected > (window-parameter > (frame-selected-window frame) 'no-other-window)) > ;; `delete-window-internal' has selected a window that should > ;; not be selected, fix this here. > (other-window -1 frame)) > > so we can avoid selecting a new window up to four times when deleting a > window (the one remaining call in `delete-window-internal' does not > record the window and has to stay there). It's simply not nice to do > that. 1. `get-mru-window' could be one possible choice of the new option. 2. `use-posn-at-point' could be another choice. 3. Selecting the first window could remain in `delete-window-internal'. 4. But what to do with this code block with '(other-window -1 frame)'? Should this be simply deleted?