From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#48782: 28.0.50; fido-mode: shell variables distort find-file behaviour Date: Sat, 05 Jun 2021 21:51:39 +0100 Message-ID: <87k0n8vxus.fsf@gmail.com> References: <855373175.142584.1622568557185@office.mailbox.org> <874kecxiiz.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26728"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: simon254@mailbox.org, 48782-done@debbugs.gnu.org To: 48782@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 05 22:52:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lpdH6-0006hT-UW for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Jun 2021 22:52:09 +0200 Original-Received: from localhost ([::1]:52732 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpdH6-00006B-07 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Jun 2021 16:52:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55432) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpdH0-00005c-1m for bug-gnu-emacs@gnu.org; Sat, 05 Jun 2021 16:52:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38625) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lpdGz-0003Dn-RE for bug-gnu-emacs@gnu.org; Sat, 05 Jun 2021 16:52:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lpdGz-0004Hh-LY for bug-gnu-emacs@gnu.org; Sat, 05 Jun 2021 16:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Jun 2021 20:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48782 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed X-Debbugs-Original-To: simon254--- via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Original-Received: via spool by submit@debbugs.gnu.org id=B.162292631316454 (code B ref -1); Sat, 05 Jun 2021 20:52:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 Jun 2021 20:51:53 +0000 Original-Received: from localhost ([127.0.0.1]:50171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpdGr-0004HK-H3 for submit@debbugs.gnu.org; Sat, 05 Jun 2021 16:51:53 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:40078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpdGl-0004Gv-CD for submit@debbugs.gnu.org; Sat, 05 Jun 2021 16:51:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55398) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpdGl-0008Pl-2q for bug-gnu-emacs@gnu.org; Sat, 05 Jun 2021 16:51:47 -0400 Original-Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:43904) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lpdGi-00030P-Bi for bug-gnu-emacs@gnu.org; Sat, 05 Jun 2021 16:51:46 -0400 Original-Received: by mail-wr1-x430.google.com with SMTP id u7so7392715wrs.10 for ; Sat, 05 Jun 2021 13:51:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=7s9/FfK+g73vpKJANeLPY5bYehRsE4ww4DOLEjkiHro=; b=vQRZtKt0qFlx89tQQSd6O6oP31FXHFBz1c2O37GUiiRiuAtZPyv6MqJF2VxqbrZQIv K/ON52qOEHgi9hNxnjV4izVnFfj4qOVZ/XC1m0L7AQ7WltcnnB7xV9Fvf18VUV2+DVBN NSCIyLQ8CNq0c9pEzbffdKBUIeqImycm+7377RkKDdpFMK/w8vLSc6uIgy4+D8+4mN26 j5dfkfW4salA1HJymp3ia1xmdPaowD+hzWqgPe+m7DgWnSleDZ/V9rW+ObrbchiuwfQq BnnPgJVhrdAac3V3iI4vJyKpNio67tQRoIQkVgfKBeLuDzi0haEOh5dZ8n3bwvi/brYc iAxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=7s9/FfK+g73vpKJANeLPY5bYehRsE4ww4DOLEjkiHro=; b=rElvNrwp4XhjVYYbk0uPgac2gJ+nmysWbzbnjiKBCjUK+kC+V1NzXODitfQevRDjGj xNv7CqzwHEZoywdgmpFUpnni5z1aicgsSdRnqeYnObOLqbOolheYdRL36IGTuvzcWQ/B gTdKfkTAtMciFxeoaX5FmhCd6Xrht3DnfNAOuG40aeBle55ACnaPyXhoVVK8iDxEeYOf Zkoklz+UjUb3t49SL04uZLFDV7VXIgts75kGg8e94n89QRJwgqQBB9h1gjbXF5cU60AH 21GXKYglnEHeQgXJOg4Zux6NJAEtGUPMxeETZe8ibpa1+xwimmN7sRRjpZBUosed5Qjq 4Pxg== X-Gm-Message-State: AOAM533fOXSQ8m8hda09+hxdTpTUF86FXuvCN/dRyIG91AJXvjv0fpTE fqG7CNfbV/GJj3V9TByZiQY= X-Google-Smtp-Source: ABdhPJzn2RyGLV3PJvNKEalKYpYMPD8QXuguCrUsfeU7R1HfHSdBm+E1Rrc5uLaK6v7XJCWphZv9lg== X-Received: by 2002:adf:fac6:: with SMTP id a6mr10177757wrs.251.1622926302319; Sat, 05 Jun 2021 13:51:42 -0700 (PDT) Original-Received: from krug (a94-133-55-152.cpe.netcabo.pt. [94.133.55.152]) by smtp.gmail.com with ESMTPSA id p6sm10851394wrf.51.2021.06.05.13.51.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Jun 2021 13:51:41 -0700 (PDT) In-Reply-To: <874kecxiiz.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sat, 05 Jun 2021 19:39:48 +0100") Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=joaotavora@gmail.com; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208074 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > tag 48782 important > thanks > > simon254--- via "Bug reports for GNU Emacs, the Swiss army knife of text > editors" writes: > >> with emacs -Q >> >> 1)=20 >> M-x -> fido-mode >> C-x C-f -> type "$HOME" -> enter opens dired buffer in $HOME directory >> instead of continuing find-file $HOME to select a file to open > > Thanks, I reproduced this and will try to fix it. Doesn't seem very > hard, but we'll see. I pushed a commit to master that should fix it. It's 45d711a356b4c5e75d0b6e4391313ca34f57b4bb, a very simple patch: diff --git a/lisp/icomplete.el b/lisp/icomplete.el index 03a191cb0b..08b4ef2030 100644 --- a/lisp/icomplete.el +++ b/lisp/icomplete.el @@ -331,7 +331,8 @@ icomplete-fido-ret (file-name-directory (icomplete--field-string)))) (current (car completion-all-sorted-completions)) (probe (and dir current - (expand-file-name (directory-file-name current) dir))= )) + (expand-file-name (directory-file-name current) + (substitute-env-vars dir))))) (cond ((and probe (file-directory-p probe) (not (string=3D current "./= "))) (icomplete-force-complete)) (t Closing this bug, but I'll reopen if it ends up not doing what you wanted. Jo=C3=A3o