From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#39452: [PATCH] vc-git-state fails for filenames with wildcards Date: Thu, 22 Jul 2021 14:42:41 +0200 Message-ID: <87k0lildtq.fsf@gnus.org> References: <83h802g77h.fsf@gnu.org> <8f427281-510c-30c3-995f-364e22d9c1e2@yandex.ru> <85y2texxso.fsf@gmail.com> <52f47a82-b93e-d9c2-ee94-752b289d4b96@yandex.ru> <85lfp7ygk3.fsf@gmail.com> <87pmxwgcps.fsf@gnus.org> <1cb67253-c43f-caac-ee83-1241edaaeeaa@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9202"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Noam Postavsky , 39452@debbugs.gnu.org, Wolfgang.Scherer@gmx.de To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 22 14:44:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6Y3l-0002DR-3w for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Jul 2021 14:44:17 +0200 Original-Received: from localhost ([::1]:56744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6Y3k-0006aa-3M for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Jul 2021 08:44:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52632) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6Y3X-0006HX-1r for bug-gnu-emacs@gnu.org; Thu, 22 Jul 2021 08:44:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56329) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6Y3W-0007pP-PO for bug-gnu-emacs@gnu.org; Thu, 22 Jul 2021 08:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m6Y3W-0003eK-Nh for bug-gnu-emacs@gnu.org; Thu, 22 Jul 2021 08:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Jul 2021 12:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39452-submit@debbugs.gnu.org id=B39452.162695778413928 (code B ref 39452); Thu, 22 Jul 2021 12:44:02 +0000 Original-Received: (at 39452) by debbugs.gnu.org; 22 Jul 2021 12:43:04 +0000 Original-Received: from localhost ([127.0.0.1]:39635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6Y2Q-0003c1-98 for submit@debbugs.gnu.org; Thu, 22 Jul 2021 08:43:04 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:54480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6Y2N-0003bl-R7 for 39452@debbugs.gnu.org; Thu, 22 Jul 2021 08:42:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YdUNCLAkWon3S44OkshSaL7GIWu3XfDTwx96jaIiUI0=; b=o0sA98deGaiJ6u2kMiJcugh4jX IxCQgqOcLR+34VRIvDIHLjRnw35bHorT5FhFd0VDL1/0H/mmvLRNn3NskKCyIybML6V32+xoBBod2 +2PT+VCvkNF80UXiMG69kGTwG6NGEwDfy5LVjndYhzdc2fjbCnmg6fxmC5um4h0AgNao=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6Y2E-0002My-C2; Thu, 22 Jul 2021 14:42:45 +0200 X-Now-Playing: John T. Gast's _Inna Babalon_: "Jah Guidance" In-Reply-To: <1cb67253-c43f-caac-ee83-1241edaaeeaa@yandex.ru> (Dmitry Gutov's message of "Mon, 17 May 2021 04:05:15 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210516 Archived-At: Dmitry Gutov writes: > On 12.05.2021 19:04, Lars Ingebrigtsen wrote: >> Wolfgang's patch is larger, but doesn't have these drawbacks (if I >> understand things correctly) -- so wouldn't it make sense to apply >> Wolfgang's patch here? > > It's a pretty big fix for a straightforward (if fundamental) problem. > > The existence of the FAQ entry personally just tells me that the other > approach has been proven in the field (by Magit), and if a FAQ entry > is enough, the side-effects are probably not that common or > serious. Because users, in general, don't read documentation. > > But other opinions welcome. Nobody had any opinions, and the "if it's good enough for Magit" argument is a good one. So I went ahead and applied Dmitry's patch to Emacs 28, and we'll see whether there's any push back on that... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no