From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#30529: 26.0.91; minibuffer errors change standard-output Date: Thu, 12 Aug 2021 17:04:44 +0200 Message-ID: <87k0kq901f.fsf@igel.home> References: <85po510xv9.fsf@gmail.com> <874klcql7u.fsf@gnus.org> <87360sdvwg.fsf@tcd.ie> <878s16k9zn.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22725"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Cc: "Basil L. Contovounesios" , f.j.wright@live.co.uk, Francis Wright , 30529@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 12 17:05:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mECGc-0005ft-Bn for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 Aug 2021 17:05:10 +0200 Original-Received: from localhost ([::1]:51384 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mECGb-00056x-Au for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 Aug 2021 11:05:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mECGU-00056h-8d for bug-gnu-emacs@gnu.org; Thu, 12 Aug 2021 11:05:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56345) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mECGU-0006Ip-1x for bug-gnu-emacs@gnu.org; Thu, 12 Aug 2021 11:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mECGT-0004bt-T7 for bug-gnu-emacs@gnu.org; Thu, 12 Aug 2021 11:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Aug 2021 15:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30529 X-GNU-PR-Package: emacs Original-Received: via spool by 30529-submit@debbugs.gnu.org id=B30529.162878069017701 (code B ref 30529); Thu, 12 Aug 2021 15:05:01 +0000 Original-Received: (at 30529) by debbugs.gnu.org; 12 Aug 2021 15:04:50 +0000 Original-Received: from localhost ([127.0.0.1]:39658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mECGI-0004bP-FH for submit@debbugs.gnu.org; Thu, 12 Aug 2021 11:04:50 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.9]:57865) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mECGG-0004bG-2T for 30529@debbugs.gnu.org; Thu, 12 Aug 2021 11:04:49 -0400 Original-Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4GlqjV42pxz1qwyH; Thu, 12 Aug 2021 17:04:46 +0200 (CEST) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4GlqjV3Y2pz1qqkb; Thu, 12 Aug 2021 17:04:46 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id ZSFqUm8ESoxm; Thu, 12 Aug 2021 17:04:45 +0200 (CEST) X-Auth-Info: X5EIllBRUKukClGJxzDUCf3i3Ld5nxTw+hMOStwoqVl91sYiO4CmG/OBK4njmXPa Original-Received: from igel.home (ppp-46-244-180-181.dynamic.mnet-online.de [46.244.180.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 12 Aug 2021 17:04:45 +0200 (CEST) Original-Received: by igel.home (Postfix, from userid 1000) id 21A932C25BC; Thu, 12 Aug 2021 17:04:44 +0200 (CEST) X-Yow: .. I see TOILET SEATS... In-Reply-To: <878s16k9zn.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 12 Aug 2021 16:34:20 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211687 Archived-At: On Aug 12 2021, Lars Ingebrigtsen wrote: > "Basil L. Contovounesios" writes: > >>> This problem is still present in Emacs 28. I tried following the code >>> logic for a couple of minutes to see just what it is that's (re)setting >>> `standard-output' here, but was unable to locate the location. >>> >>> Anybody know? >> >> Just from a quick grep, could it be recursive_edit_1? > > Found the culprit! cmd_error sets standard_output to t! > > The following patch fixes the reported issue (and doesn't lead to any > regressions in the test suite), but this code has been like this > forever, so I'm a bit leery about applying it. > > And perhaps the > > old_level = Vprint_level; > old_length = Vprint_length; > > stuff should also be changed to specbinding? Or do we want to avoid > specbind here totally for some reason? The commit for those lines just > says: > > (cmd_error): Bind Vprint_level and Vprint_length. > > I mean, we had specbind before 1995, I think? > > So... any comments/insights here? I think the intention is to get out of any situation that may result in repeated errors. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."