From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Peter Münster" <pm@a16n.net>
Cc: 50000@debbugs.gnu.org
Subject: bug#50000: 27.2; tagging marked thumbnails
Date: Sat, 14 Aug 2021 13:51:44 +0200 [thread overview]
Message-ID: <87k0koutv3.fsf@gnus.org> (raw)
In-Reply-To: <87lf558pik.fsf@a16n.net> ("Peter Münster"'s message of "Fri, 13 Aug 2021 15:04:19 +0200")
Peter Münster <pm@a16n.net> writes:
> Perhaps at least menu bindings. A patch is attached (with also some
> refactoring).
Looks mostly good, but:
> (image-dired-tag-thumbnail, image-dired-tag-thumbnail-remove): Rename to
> plural forms, because they can handle now also all marked thumbnails.
We can't rename functions in this way -- people may be referring to the
old names, and that could would then break. You could add obsolete
aliases, but it's generally not worth it. Can you respin the patch
without the function renames?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-08-14 11:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 10:01 bug#50000: 27.2; tagging marked thumbnails Peter Münster
2021-08-11 12:21 ` Lars Ingebrigtsen
2021-08-11 14:31 ` Peter Münster
2021-08-11 16:02 ` Lars Ingebrigtsen
2021-08-13 13:04 ` Peter Münster
2021-08-14 11:51 ` Lars Ingebrigtsen [this message]
2021-08-16 7:38 ` Peter Münster
2021-08-16 12:07 ` Lars Ingebrigtsen
2021-08-16 15:33 ` Peter Münster
2021-08-18 12:54 ` Lars Ingebrigtsen
2021-08-18 15:01 ` Peter Münster
2021-08-19 13:03 ` Lars Ingebrigtsen
2021-08-20 7:13 ` Peter Münster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0koutv3.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=50000@debbugs.gnu.org \
--cc=pm@a16n.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).