From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#34715: bug#32736: bug#34715: bug#32736: 26; Bind `C-x 5 2' to `clone-frame' by default Date: Thu, 02 Sep 2021 09:44:24 +0200 Message-ID: <87k0jzbew7.fsf@gnus.org> References: <17bef02b-7dd4-4086-828f-59488a836ac1@default> <8735qofx6h.fsf@gnus.org> <83fsuoqx75.fsf@gnu.org> <87eea8e9u6.fsf@gnus.org> <83bl5cquu4.fsf@gnu.org> <87a6kwe7n9.fsf@gnus.org> <875yvke7kt.fsf@gnus.org> <87zgswcsdq.fsf@gnus.org> <835yvkqtc3.fsf@gnu.org> <87v93kcrbu.fsf@gnus.org> <834kb4qof0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20323"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 34715@debbugs.gnu.org, 32736@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 02 09:45:29 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mLhPb-00052c-Tk for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Sep 2021 09:45:27 +0200 Original-Received: from localhost ([::1]:58276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLhPa-00027t-P7 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Sep 2021 03:45:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLhPC-00026n-VA for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 03:45:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56260) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mLhPC-0002z0-NU for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 03:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mLhPC-00061K-Ei for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 03:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Sep 2021 07:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34715 X-GNU-PR-Package: emacs Original-Received: via spool by 34715-submit@debbugs.gnu.org id=B34715.163056869023077 (code B ref 34715); Thu, 02 Sep 2021 07:45:02 +0000 Original-Received: (at 34715) by debbugs.gnu.org; 2 Sep 2021 07:44:50 +0000 Original-Received: from localhost ([127.0.0.1]:39572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLhOw-0005zy-2x for submit@debbugs.gnu.org; Thu, 02 Sep 2021 03:44:50 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:41282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLhOl-0005zU-FX; Thu, 02 Sep 2021 03:44:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=11AHI/2Oz8Bx6YjT1Xe4mRbTVBqcbCg9Ix07P3DLq2o=; b=XQbUglYv0O/3YXxkkUJrLVvzdB jOWJiOhzLrKjCJAN2yHeXTTgdS+gp0P+riwAzPDo6LjbjhIv7ptzAWRcohSlJGfcjN2WKY+e+ieTm q9BODucJvfQ6BRcp87TvejhDH/+SnkbP5Zqim6yfGGuZ7EMjqP5LilTRt5erdNKerKHM=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mLhOa-0004uy-Iq; Thu, 02 Sep 2021 09:44:28 +0200 In-Reply-To: <834kb4qof0.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 01 Sep 2021 18:57:23 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213246 Archived-At: Eli Zaretskii writes: >> The following is the minimal case for reproduction here: >> >> (let ((default-frame-alist >> '((background-color . "red")))) >> (make-frame)) >> >> This reliably makes all the faces go AWOL on the new frame. (It doesn't >> matter what the colour is.) > > Shouldn't we copy the parameters alist? Maybe even deep-copy? Do you mean in this particular test case or in `clone-frame'? If it's the latter, the list we get is fresh (but not very deep). If it's this particular test case, then I don't understand what you mean. > And faces are supposed to be frame-local, so maybe faces also need to > be copied? Otherwise, you are basically manipulating faces that don't > "belong" to the frame, no? And likewise with frame's parameters > alist, I think. Anyway, debugging further shows that the problem seems to be in `frame-set-background-mode', but I've yet to isolate what exactly is triggering the bug. (dolist (face (face-list)) (and (not (get face 'face-override-spec)) [...] (face-spec-match-p face (face-user-default-spec face) frame))) (push face locally-modified-faces))) ;; Now change to the new frame parameters (modify-frame-parameters frame params) ;; For all unmodified named faces, choose face specs ;; matching the new frame parameters. (dolist (face (face-list)) (unless (memq face locally-modified-faces) (face-spec-recalc face frame))))))))) The face-spec-recalc messes up the face... but so does the call to face-spec-match-p, apparently? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no